iio: buffer-dmaengine: make use of the 'struct device *' argument
Nuno Sa
reviewerPATCH 1/1 iio: buffer-dmaengine: make use of the 'struct device *' argument
Respect the @dev argument in devm_iio_dmaengine_buffer_setup() and bind the IIO DMA buffer lifetime to that device.
For the only user of this function, the IIO parent device is the struct device being passed to the API so no real fix in here (just consistency with other IIO APIs).
--- drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/buffer/industrialio-buffer-dmaengine.c +1 -2
@@ -279,8 +279,7 @@ int devm_iio_dmaengine_buffer_setup(struct device *dev, {struct iio_buffer *buffer; - buffer =devm_iio_dmaengine_buffer_alloc (indio_dev->dev.parent, - channel); + buffer =devm_iio_dmaengine_buffer_alloc (dev, channel);if (IS_ERR (buffer))return PTR_ERR (buffer);
---
base-commit: 3f4525f924e21d4f532517b17a20ffa5df7c0db7
change-id: 20240109-dmaengine_use_device-853f196ec78f --
Thanks!
- Nuno Sá
Quoted 33 lines · Nuno Sa
Respect the @dev argument in
devm_iio_dmaengine_buffer_setup()and bind the IIO DMA buffer lifetime to that device.For the only user of this function, the IIO parent device is the struct device being passed to the API so no real fix in here (just consistency with other IIO APIs).
Signed-off-by Nuno Sa <[email protected]>--- drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/iio/buffer/industrialio-buffer-dmaengine.c +1
-3@@ -279,8 +279,7 @@ int devm_iio_dmaengine_buffer_setup(struct device *dev, {struct iio_buffer *buffer; - buffer =devm_iio_dmaengine_buffer_alloc (indio_dev->dev.parent, - channel); + buffer =devm_iio_dmaengine_buffer_alloc (dev, channel);if (IS_ERR (buffer))return PTR_ERR (buffer); ---base-commit:
3f4525f924e21d4f532517b17a20ffa5df7c0db7
change-id: 20240109-dmaengine_use_device-853f196ec78f --
Quoted 4 lines
Thanks!
- Nuno Sá
I noticed this too but didn't get around to fixing it yet. ;-)
Quoted 34 lines · On Tue, 9 Jan 2024 11:56:47 -0600 David Lechner <[email protected]> wrote:
Quoted 33 lines · Nuno Sa
Respect the @dev argument in
devm_iio_dmaengine_buffer_setup()and bind the IIO DMA buffer lifetime to that device.For the only user of this function, the IIO parent device is the struct device being passed to the API so no real fix in here (just consistency with other IIO APIs).
Signed-off-by Nuno Sa <[email protected]>--- drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/iio/buffer/industrialio-buffer-dmaengine.c +1
-3@@ -279,8 +279,7 @@ int devm_iio_dmaengine_buffer_setup(struct device *dev, {struct iio_buffer *buffer; - buffer =devm_iio_dmaengine_buffer_alloc (indio_dev->dev.parent, - channel); + buffer =devm_iio_dmaengine_buffer_alloc (dev, channel);if (IS_ERR (buffer))return PTR_ERR (buffer); ---base-commit:
3f4525f924e21d4f532517b17a20ffa5df7c0db7
change-id: 20240109-dmaengine_use_device-853f196ec78f --
Quoted 8 lines
Quoted 4 lines
Thanks!
- Nuno SáI noticed this too but didn't get around to fixing it yet. ;-)
Reviewed-by David Lechner <[email protected]>
Applied