Skip to contentSkip to conversation

iio: buffer-dmaengine: make use of the 'struct device *' argument

PATCH Applied Nuno Sa 3 participants 3 messages Jan 9, 2024 – Jan 13, 2024 IIO

lore
Share & tools
lore

Nuno Sa

author reviewer
#0 lore raw

PATCH 1/1 iio: buffer-dmaengine: make use of the 'struct device *' argument

Respect the @dev argument in devm_iio_dmaengine_buffer_setup() and bind the IIO DMA buffer lifetime to that device.

For the only user of this function, the IIO parent device is the struct device being passed to the API so no real fix in here (just consistency with other IIO APIs).

---
 drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/buffer/industrialio-buffer-dmaengine.c +1 -2
index 5f85ba38e6f6..45fe7d0d42ee 100644
@@ -279,8 +279,7 @@ int devm_iio_dmaengine_buffer_setup(struct device *dev,
 {
 	struct iio_buffer *buffer;
 
-	buffer = devm_iio_dmaengine_buffer_alloc(indio_dev->dev.parent,
-						 channel);
+	buffer = devm_iio_dmaengine_buffer_alloc(dev, channel);
 	if (IS_ERR(buffer))
 		return PTR_ERR(buffer);
 

---
base-commit: 3f4525f924e21d4f532517b17a20ffa5df7c0db7
change-id: 20240109-dmaengine_use_device-853f196ec78f --

Thanks!
- Nuno Sá

reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 33 lines · Nuno Sa

Respect the @dev argument in devm_iio_dmaengine_buffer_setup() and bind the IIO DMA buffer lifetime to that device.

For the only user of this function, the IIO parent device is the struct device being passed to the API so no real fix in here (just consistency with other IIO APIs).

---
 drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/buffer/industrialio-buffer-dmaengine.c +1 -3
index 5f85ba38e6f6..45fe7d0d42ee 100644
@@ -279,8 +279,7 @@ int devm_iio_dmaengine_buffer_setup(struct device *dev,
 {
        struct iio_buffer *buffer;
 
-       buffer = devm_iio_dmaengine_buffer_alloc(indio_dev->dev.parent,
-                                                channel);
+       buffer = devm_iio_dmaengine_buffer_alloc(dev, channel);
        if (IS_ERR(buffer))
                return PTR_ERR(buffer);
 
 
---

base-commit: 3f4525f924e21d4f532517b17a20ffa5df7c0db7
change-id: 20240109-dmaengine_use_device-853f196ec78f --

Quoted 4 lines

Thanks!
- Nuno Sá

I noticed this too but didn't get around to fixing it yet. ;-)

maintainer Applied
#2 lore raw
Quoted 34 lines · On Tue, 9 Jan 2024 11:56:47 -0600 David Lechner <[email protected]> wrote:
Quoted 33 lines · Nuno Sa

Respect the @dev argument in devm_iio_dmaengine_buffer_setup() and bind the IIO DMA buffer lifetime to that device.

For the only user of this function, the IIO parent device is the struct device being passed to the API so no real fix in here (just consistency with other IIO APIs).

---
 drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/buffer/industrialio-buffer-dmaengine.c +1 -3
index 5f85ba38e6f6..45fe7d0d42ee 100644
@@ -279,8 +279,7 @@ int devm_iio_dmaengine_buffer_setup(struct device *dev,
 {
        struct iio_buffer *buffer;
 
-       buffer = devm_iio_dmaengine_buffer_alloc(indio_dev->dev.parent,
-                                                channel);
+       buffer = devm_iio_dmaengine_buffer_alloc(dev, channel);
        if (IS_ERR(buffer))
                return PTR_ERR(buffer);
 
 
---

base-commit: 3f4525f924e21d4f532517b17a20ffa5df7c0db7
change-id: 20240109-dmaengine_use_device-853f196ec78f --

Quoted 8 lines
Quoted 4 lines

Thanks!
- Nuno Sá

I noticed this too but didn't get around to fixing it yet. ;-)

Applied