Skip to contentSkip to conversation

cxl: Remove duplicated include in cdat.c

PATCH In review Yang Li 4 participants 4 messages Jan 9, 2024 – Jan 12, 2024 CXL

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 cxl: Remove duplicated include in cdat.c

The header files core.h is included twice in cdat.c, so one inclusion can be removed.

---
 drivers/cxl/core/cdat.c | 1 -
 1 file changed, 1 deletion(-)
drivers/cxl/core/cdat.c +0 -1
index f5e649407b8b..6fe11546889f 100644
@@ -9,7 +9,6 @@
 #include "cxlmem.h"
 #include "core.h"
 #include "cxl.h"
-#include "core.h"
 
 struct dsmas_entry {
 	struct range dpa_range;
Signature · 1 line
2.20.1.7.g153144c
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Tue, 9 Jan 2024 08:47:28 +0800 Yang Li <[email protected]> wrote:

The header files core.h is included twice in cdat.c, so one inclusion can be removed.

Obviously correct :)

Quoted 16 lines
---
 drivers/cxl/core/cdat.c | 1 -
 1 file changed, 1 deletion(-)
drivers/cxl/core/cdat.c +0 -1
index f5e649407b8b..6fe11546889f 100644
@@ -9,7 +9,6 @@
 #include "cxlmem.h"
 #include "core.h"
 #include "cxl.h"
-#include "core.h"
 
 struct dsmas_entry {
 	struct range dpa_range;
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Yang Li
Quoted 4 lines · Yang Li

The header files core.h is included twice in cdat.c, so one inclusion can be removed.

Quoted 16 lines
---
 drivers/cxl/core/cdat.c | 1 -
 1 file changed, 1 deletion(-)
drivers/cxl/core/cdat.c +0 -1
index f5e649407b8b..6fe11546889f 100644
@@ -9,7 +9,6 @@
 #include "cxlmem.h"
 #include "core.h"
 #include "cxl.h"
-#include "core.h"
 
 struct dsmas_entry {
 	struct range dpa_range;
#3 lore raw
In reply to Yang Li
Quoted 13 lines · Yang Li

The header files core.h is included twice in cdat.c, so one inclusion can be removed.

---
 drivers/cxl/core/cdat.c | 1 -
 1 file changed, 1 deletion(-)
drivers/cxl/core/cdat.c +0 -0
index f5e649407b8b..6fe11546889f 100644

drivers/cxl/core/cdat.c line 12

Quoted 4 lines
drivers/cxl/core/cdat.c +0 -1
@@ -9,7 +9,6 @@
 #include "cxlmem.h"
 #include "core.h"
 #include "cxl.h"
-#include "core.h"

I believe that was due to a bad merge by me. That's fixed up now with a better merge commit.

Thanks for spotting this though!