Skip to contentSkip to conversation

rootfs.py: check depmodwrapper execution result

PATCH New [email protected] 1 participant 1 message Jan 9, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rootfs.py: check depmodwrapper execution result

From: Yang Xu <[email protected]>

The execution result of depmodwrapper is not checked which makes depmod generation failed sliently and hard to detect.

So check exection result and stop building if depmodwrapper failed.

---
 meta/lib/oe/rootfs.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/lib/oe/rootfs.py +2 -1
index 1a48ed10b3..3f27164536 100644
@@ -349,7 +349,8 @@ class Rootfs(object, metaclass=ABCMeta):
             bb.utils.mkdirhier(versioned_modules_dir)
 
             bb.note("Running depmodwrapper for %s ..." % versioned_modules_dir)
-            self._exec_shell_cmd(['depmodwrapper', '-a', '-b', self.image_rootfs, kernel_ver, kernel_package_name])
+            if self._exec_shell_cmd(['depmodwrapper', '-a', '-b', self.image_rootfs, kernel_ver, kernel_package_name]):
+                bb.fatal("Kernel modules dependency generation failed")
 
     """
     Create devfs:
Signature · 1 line
2.25.1