Skip to contentSkip to conversation

tests/kms_plane_cursor: Skip unneeded overlay requirement

PATCH New Rob Clark 2 participants 3 messages Jan 10, 2024 – Jan 11, 2024

lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 tests/kms_plane_cursor: Skip unneeded overlay requirement

From: Rob Clark <[email protected]>

Tests that aren't using an overlay plan should not require one.

Some qcom devices only have primary and cursor planes (but those planes are not restricted to a single CRTC). Requiring an overlay plane even for subtests that didn't need one, was causing all the tests to SKIP.

---
 tests/kms_plane_cursor.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
tests/kms_plane_cursor.c +9 -5
index dd33d8129626..5b3cdc06901b 100644
@@ -91,7 +91,8 @@ typedef struct data {
 } data_t;
 
 /* Common test setup. */
-static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
+static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output,
+		      unsigned int flags)
 {
 	data->pipe_id = pipe_id;
 	data->pipe = &data->display.pipes[data->pipe_id];
@@ -100,7 +101,8 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
 	data->mode = igt_output_get_mode(data->output);
 
 	data->primary = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_PRIMARY);
-	data->overlay = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_OVERLAY);
+	if (flags & TEST_OVERLAY)
+		data->overlay = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_OVERLAY);
 	data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
 
 	igt_info("Using (pipe %s + %s) to run the subtest.\n",
@@ -123,7 +125,8 @@ static void test_fini(data_t *data)
 	igt_pipe_crc_free(data->pipe_crc);
 	igt_display_reset(&data->display);
 	igt_plane_set_fb(data->primary, NULL);
-	igt_plane_set_fb(data->overlay, NULL);
+	if (data->overlay)
+		igt_plane_set_fb(data->overlay, NULL);
 	igt_plane_set_fb(data->cursor, NULL);
 	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
@@ -167,7 +170,8 @@ static void test_cursor_pos(data_t *data, int x, int y, unsigned int flags)
 	igt_paint_color(cr, x, y, cw, ch, 1.0, 0.0, 1.0);
 	igt_put_cairo_ctx(cr);
 
-	igt_plane_set_fb(data->overlay, NULL);
+	if (flags & TEST_OVERLAY)
+		igt_plane_set_fb(data->overlay, NULL);
 	igt_plane_set_fb(data->cursor, NULL);
 	igt_display_commit_atomic(&data->display, 0, NULL);
 
@@ -333,7 +337,7 @@ igt_main
 				if (!intel_pipe_output_combo_valid(display))
 					continue;
 
-				test_init(&data, pipe, output);
+				test_init(&data, pipe, output, tests[i].flags);
 
 				for (j = 0; j < ARRAY_SIZE(cursor_sizes); j++) {
 					int size = cursor_sizes[j];
Signature · 1 line
2.43.0
#1 lore raw

✗ Fi.CI.BAT: failure for tests/kms_plane_cursor: Skip unneeded overlay requirement

== Series Details ==

== Series Details ==

Series: tests/kms_plane_cursor: Skip unneeded overlay requirement
URL : https://patchwork.freedesktop.org/series/128460/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14109 -> IGTPW_10506
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_10506 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10506, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/index.html

Participating hosts (36 -> 35)
------------------------------

Additional (1): bat-kbl-2
Missing (2): bat-rpls-2 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_10506:

### IGT changes ###

#### Possible regressions ####

* igt@i915_suspend@basic-s2idle-without-i915:
- bat-mtlp-6: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14109/bat-mtlp-6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-mtlp-6/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_10506 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@debugfs_test@basic-hwmon:
- bat-jsl-1: NOTRUN -> [SKIP][3] ([i915#9318])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-jsl-1/igt@[email protected]

* igt@fbdev@info:
- bat-kbl-2: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1849])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-kbl-2/igt@[email protected]

* igt@gem_exec_suspend@basic-s0@smem:
- bat-mtlp-6: [PASS][5] -> [FAIL][6] ([i915#10054]) +1 other test fail
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14109/bat-mtlp-6/igt@gem_exec_suspend@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-mtlp-6/igt@gem_exec_suspend@[email protected]

* igt@gem_huc_copy@huc-copy:
- bat-jsl-1: NOTRUN -> [SKIP][7] ([i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-jsl-1/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- bat-kbl-2: NOTRUN -> [SKIP][8] ([fdo#109271]) +36 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-kbl-2/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- bat-jsl-1: NOTRUN -> [SKIP][9] ([i915#4613]) +3 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-jsl-1/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- bat-adln-1: [PASS][10] -> [DMESG-FAIL][11] ([i915#10010])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14109/bat-adln-1/igt@i915_selftest@live@gt_pm.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-adln-1/igt@i915_selftest@live@gt_pm.html

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-jsl-1: NOTRUN -> [SKIP][12] ([i915#4103]) +1 other test skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-jsl-1/igt@[email protected]

* igt@kms_dsc@dsc-basic:
- bat-jsl-1: NOTRUN -> [SKIP][13] ([i915#3555] / [i915#9886])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-jsl-1/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- bat-jsl-1: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-jsl-1/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- bat-jsl-1: NOTRUN -> [SKIP][15] ([i915#3555])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/bat-jsl-1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#10010]: https://gitlab.freedesktop.org/drm/intel/issues/10010
[i915#10054]: https://gitlab.freedesktop.org/drm/intel/issues/10054
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9886]: https://gitlab.freedesktop.org/drm/intel/issues/9886

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7668 -> IGTPW_10506

CI-20190529: 20190529
CI_DRM_14109: 7648a2467ba20e0e894af11fdbeed39c88017ff8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10506: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/index.html
IGT_7668: 3f2879fef93c0c546a2f1c0aa48a9cc2a594b9d2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/index.html

#2 lore raw

✓ CI.xeBAT: success for tests/kms_plane_cursor: Skip unneeded overlay requirement

In reply to Rob Clark
== Series Details ==

== Series Details ==

Series: tests/kms_plane_cursor: Skip unneeded overlay requirement
URL : https://patchwork.freedesktop.org/series/128460/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7668_BAT -> XEIGTPW_10506_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (3 -> 4)
------------------------------

Additional (1): bat-dg2-oem2

Known issues
------------

Here are the changes found in XEIGTPW_10506_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-oem2: NOTRUN -> [SKIP][1] ([Intel XE#623])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/bat-dg2-oem2/igt@[email protected]

* igt@kms_dsc@dsc-basic:
- bat-dg2-oem2: NOTRUN -> [SKIP][2] ([Intel XE#455])
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/bat-dg2-oem2/igt@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- bat-adlp-7: [PASS][3] -> [FAIL][4] ([Intel XE#480]) +1 other test fail
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7668/bat-adlp-7/igt@kms_flip@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/bat-adlp-7/igt@kms_flip@[email protected]

* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-oem2: NOTRUN -> [SKIP][5] ([i915#5274])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/bat-dg2-oem2/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-dg2-oem2: NOTRUN -> [FAIL][6] ([Intel XE#608])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/bat-dg2-oem2/igt@[email protected]

* igt@xe_exec_fault_mode@twice-bindexecqueue-userptr-invalidate:
- bat-dg2-oem2: NOTRUN -> [SKIP][7] ([Intel XE#288]) +32 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/bat-dg2-oem2/igt@[email protected]

* igt@xe_huc_copy@huc_copy:
- bat-dg2-oem2: NOTRUN -> [SKIP][8] ([Intel XE#255])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/bat-dg2-oem2/igt@xe_huc_copy@huc_copy.html

* igt@xe_pat@pat-index-xe2:
- bat-dg2-oem2: NOTRUN -> [SKIP][9] ([Intel XE#977])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/bat-dg2-oem2/igt@[email protected]

* igt@xe_pat@pat-index-xehpc:
- bat-dg2-oem2: NOTRUN -> [SKIP][10] ([Intel XE#979]) +1 other test skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/bat-dg2-oem2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[Intel XE#255]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/255
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
[Intel XE#608]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/608
[Intel XE#623]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/623
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[Intel XE#977]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/977
[Intel XE#979]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/979
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274

Build changes
-------------

* IGT: IGT_7668 -> IGTPW_10506

IGTPW_10506: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10506/index.html
IGT_7668: 3f2879fef93c0c546a2f1c0aa48a9cc2a594b9d2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-614-bb9e8031d2feb59becdea41e54e62f1bc47f3ef9: bb9e8031d2feb59becdea41e54e62f1bc47f3ef9

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10506/index.html