Skip to contentSkip to conversation

staging: vt6655: Remove extra blank lines between code blocks

PATCH Superseded Pranav Athreya 3 participants 7 messages Jan 11, 2024 1 message not in the archive Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vt6655: Remove extra blank lines between code blocks

Adhere to Linux kernel coding style.

Reported by checkpatch:

drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines

drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
are included in .gitignore.

---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vt6655/rxtx.h +0 -1
index a67757c9bb5c..be1e5180d57b 100644
@@ -19,7 +19,6 @@
 #define DEFAULT_MSDU_LIFETIME_RES_64us	8000 /* 64us */
 #define DEFAULT_MGN_LIFETIME_RES_64us	125  /* 64us */
 
-
 /*---------------------  Export Definitions -------------------------*/
 
 /*---------------------  Export Variables  --------------------------*/
Signature · 1 line
2.34.1
#1 lore raw
Quoted 9 lines · Pranav Athreya

Adhere to Linux kernel coding style.

Reported by checkpatch:

drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines

drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
are included in .gitignore.

*.mod.c files are not something that you can change, and are not in your patch either:

Quoted 4 lines
---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)

So the text is not correct :(

thanks,

greg k-h

A message that is not in the archive (sent off-list or not yet received): CAP1Lp88vEZJtd69Njf9uZ5VXypwZ-5vLdBHf2xoLSpqmeyEQiA@mail.gmail.com

#3 lore raw

My apologies, resending this as plain text.

Greg,

Thank you for reviewing my patch! Shall I amend the commit and send a revision of the patch?
If I understand you correctly, I should remove all mention of the .mod.c file from the commit,
which will leave the new text as such:

Adhere to Linux kernel coding style.

Reported by checkpatch:

drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines

---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vt6655/rxtx.h +0 -1
index a67757c9bb5c..be1e5180d57b 100644
@@ -19,7 +19,6 @@
 #define DEFAULT_MSDU_LIFETIME_RES_64us 8000 /* 64us */
 #define DEFAULT_MGN_LIFETIME_RES_64us  125  /* 64us */
 
-
 /*---------------------  Export Definitions -------------------------*/
 
 /*---------------------  Export Variables  --------------------------*/

Yours Sincerely,

Pranav.

Yours Sincerely,

Pranav.

Quoted 63 lines · Pranav Athreya

Greg,

Thank you for reviewing my patch! Shall I amend the commit and send a revision of the patch? If I understand you correctly, I should remove all mention of the .mod.c file from the commit, which will leave the new text as such:

Adhere to Linux kernel coding style.

Reported by checkpatch:

drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines

---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vt6655/rxtx.h +0 -1
index a67757c9bb5c..be1e5180d57b 100644
@@ -19,7 +19,6 @@
 #define DEFAULT_MSDU_LIFETIME_RES_64us 8000 /* 64us */
 #define DEFAULT_MGN_LIFETIME_RES_64us  125  /* 64us */
 
-
 /*---------------------  Export Definitions -------------------------*/
 
 /*---------------------  Export Variables  --------------------------*/

Yours Sincerely,

Pranav.

Quoted 25 lines · Greg Kroah-Hartman
Quoted 9 lines · Pranav Athreya

Adhere to Linux kernel coding style.

Reported by checkpatch:

drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines

drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
are included in .gitignore.

*.mod.c files are not something that you can change, and are not in your patch either:

Quoted 4 lines
---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)

So the text is not correct :(

thanks,

greg k-h

#4 lore raw
Quoted 6 lines · Pranav Athreya

My apologies, resending this as plain text.

Greg,

Thank you for reviewing my patch! Shall I amend the commit and send a revision of the patch?

Yes, please read the kernel documentation for how to submit a new version of a patch.

thanks,

greg k-h

#5 lore raw
Quoted 2 lines · Greg Kroah-Hartman

Yes, please read the kernel documentation for how to submit a new version of a patch.

Reading the docs now and will send the patch right after. My sincere apologies for the top posting.

Yours Sincerely,

Pranav.