fs/proc/task_mmu.c: add_to_pagemap: Remove useless parameter addr
Subsystems (3)
PATCH 1/1 fs/proc/task_mmu.c: add_to_pagemap: Remove useless parameter addr
From: Hui Zhu <[email protected]>
Function parameters addr of add_to_pagemap is useless. This commit remove it.
Signed-off-by Hui Zhu <[email protected]>
--- fs/proc/task_mmu.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
fs/proc/task_mmu.c +6 -7
@@ -1352,8 +1352,7 @@ static inline pagemap_entry_t make_pme(u64 frame, u64 flags)return (pagemap_entry_t ) { .pme = (frame &PM_PFRAME_MASK ) | flags }; } -static int add_to_pagemap (unsigned long addr,pagemap_entry_t *pme, -struct pagemapread *pm) +static int add_to_pagemap (pagemap_entry_t *pme,struct pagemapread *pm) { pm->buffer[pm->pos++] = *pme;if (pm->pos >= pm->len)
@@ -1380,7 +1379,7 @@ static int pagemap_pte_hole(unsigned long start, unsigned long end, hole_end = end;for (; addr < hole_end; addr +=PAGE_SIZE ) { - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err) goto out; }
@@ -1392,7 +1391,7 @@ static int pagemap_pte_hole(unsigned long start, unsigned long end,if (vma->vm_flags &VM_SOFTDIRTY ) pme =make_pme (0 ,PM_SOFT_DIRTY );for (; addr <min (end, vma->vm_end); addr +=PAGE_SIZE ) { - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err) goto out; }
@@ -1519,7 +1518,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,for (; addr != end; addr +=PAGE_SIZE ) {pagemap_entry_t pme =make_pme (frame, flags); - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err)break ;if (pm->show_pfn) {
@@ -1547,7 +1546,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,pagemap_entry_t pme; pme =pte_to_pagemap_entry (pm, vma, addr,ptep_get (pte)); - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err)break ; }
@@ -1597,7 +1596,7 @@ static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask,for (; addr != end; addr +=PAGE_SIZE ) {pagemap_entry_t pme =make_pme (frame, flags); - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err)return err;if (pm->show_pfn && (flags &PM_PRESENT ))
Signature · 1 line
2.19.1.6.gb485710b
Quoted 6 lines · Hui Zhu
From: Hui Zhu <[email protected]>
Function parameters addr of
add_to_pagemapis useless. This commit remove it.Signed-off-by Hui Zhu <[email protected]>
Reviewed-by Muhammad Usama Anjum <[email protected]>
Tested-by Muhammad Usama Anjum <[email protected]>
Quoted 63 lines
--- fs/proc/task_mmu.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)fs/proc/task_mmu.c +6
-7@@ -1352,8 +1352,7 @@ static inline pagemap_entry_t make_pme(u64 frame, u64 flags)return (pagemap_entry_t ) { .pme = (frame &PM_PFRAME_MASK ) | flags }; } -static int add_to_pagemap (unsigned long addr,pagemap_entry_t *pme, -struct pagemapread *pm) +static int add_to_pagemap (pagemap_entry_t *pme,struct pagemapread *pm) { pm->buffer[pm->pos++] = *pme;if (pm->pos >= pm->len)@@ -1380,7 +1379,7 @@ static int pagemap_pte_hole(unsigned long start, unsigned long end, hole_end = end;for (; addr < hole_end; addr +=PAGE_SIZE ) { - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err) goto out; }@@ -1392,7 +1391,7 @@ static int pagemap_pte_hole(unsigned long start, unsigned long end,if (vma->vm_flags &VM_SOFTDIRTY ) pme =make_pme (0 ,PM_SOFT_DIRTY );for (; addr <min (end, vma->vm_end); addr +=PAGE_SIZE ) { - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err) goto out; }@@ -1519,7 +1518,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,for (; addr != end; addr +=PAGE_SIZE ) {pagemap_entry_t pme =make_pme (frame, flags); - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err)break ;if (pm->show_pfn) {@@ -1547,7 +1546,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,pagemap_entry_t pme; pme =pte_to_pagemap_entry (pm, vma, addr,ptep_get (pte)); - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err)break ; }@@ -1597,7 +1596,7 @@ static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask,for (; addr != end; addr +=PAGE_SIZE ) {pagemap_entry_t pme =make_pme (frame, flags); - err =add_to_pagemap (addr, &pme, pm); + err =add_to_pagemap (&pme, pm);if (err)return err;if (pm->show_pfn && (flags &PM_PRESENT ))
Signature · 2 lines
BR, Muhammad Usama Anjum