mm: vmalloc: Mark vmap_init_free_space() with __init tag
Subsystems (2)
Uladzislau Rezki (Sony)
maintainerPATCH 1/1 mm: vmalloc: Mark vmap_init_free_space() with __init tag
The vmap_init_free_space() function is called only once therefore tag it with __init. Apart of that it access the "vmlist" variable that is located in ".init.data" section.
Reported-by kernel test robot <[email protected]>
Fixes 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")
Signed-off-by Uladzislau Rezki (Sony) <[email protected]>
--- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/vmalloc.c +1 -1
@@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);#endif -static void vmap_init_free_space (void ) +static void __init vmap_init_free_space (void ) {unsigned long vmap_start =1 ;const unsigned long vmap_end =ULONG_MAX ;
Signature · 1 line
2.39.2
Looks good:
Reviewed-by Christoph Hellwig <[email protected]>
Quoted 26 lines · Uladzislau Rezki (Sony)
The
vmap_init_free_space()function is called only once therefore tag it with__init. Apart of that it access the "vmlist" variable that is located in ".init.data" section.Reported-by kernel test robot <[email protected]>Fixes 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")Signed-off-by Uladzislau Rezki (Sony) <[email protected]>--- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/vmalloc.c +1
-2@@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);#endif -static void vmap_init_free_space (void ) +static void __init vmap_init_free_space (void ) {unsigned long vmap_start =1 ;const unsigned long vmap_end =ULONG_MAX ; --
Quoted 2 lines
2.39.2
Looks good to me too. Feel free to add:
Reviewed-by Lorenzo Stoakes <[email protected]>
Quoted 17 lines · Uladzislau Rezki (Sony)
The
vmap_init_free_space()function is called only once therefore tag it with__init. Apart of that it access the "vmlist" variable that is located in ".init.data" section.Reported-by kernel test robot <[email protected]>Fixes 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")Signed-off-by Uladzislau Rezki (Sony) <[email protected]>--- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/vmalloc.c +0
-0
mm/vmalloc.c module_init(proc_vmalloc_init); · line 4840
Quoted 8 lines
mm/vmalloc.c +1
-1@@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);#endif -static void vmap_init_free_space (void ) +static void __init vmap_init_free_space (void ) {unsigned long vmap_start =1 ;const unsigned long vmap_end =ULONG_MAX ;
LGTM
Reviewed-by Anshuman Khandual <[email protected]>