Skip to contentSkip to conversation

kernel-devsrc: copy source files under tools/

PATCH In review [email protected] 2 participants 5 messages Jan 12, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel-devsrc: copy source files under tools/

From: Chen Qi <[email protected]>

The source files under tools/ also need to be copied because in some case, they'll be needed. For example, in case that the CONFIG_DEBUG_INFO_BTF is enabled, we'll get the following error without this patch when doing 'make prepare'.

No rule to make target '/.../tools/bpf/resolve_btfids/main.o', needed by '/.../tools/bpf/resolve_btfids/resolve_btfids-in.o'. Stop.

---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-kernel/linux/kernel-devsrc.bb +1 -0
index ce5777fbe9..c2aeb8e216 100644
@@ -62,6 +62,7 @@ do_install() {
 	cd ${S}
 	cp --parents $(find  -type f -name "Makefile*" -o -name "Kconfig*") $kerneldir/build
 	cp --parents $(find  -type f -name "Build" -o -name "Build.include") $kerneldir/build
+	cp --parents $(find tools/  -type f -name "*.c" -o -name "*.h") $kerneldir/build
     )
 
     # then drop all but the needed Makefiles/Kconfig files
Signature · 1 line
2.34.1
#1 lore raw
Quoted 11 lines · Chen Qi via lists.openembedded.org

From: Chen Qi <[email protected]>

The source files under tools/ also need to be copied because in some case, they'll be needed. For example, in case that the CONFIG_DEBUG_INFO_BTF is enabled, we'll get the following error without this patch when doing 'make prepare'.

No rule to make target '/.../tools/bpf/resolve_btfids/main.o', needed by '/.../tools/bpf/resolve_btfids/resolve_btfids-in.o'. Stop.

Tools has been excluded on purpose, as it is relatively large (and complex) compared to the rest of the curated files.

Figure out just what you need for bpf, and copy only those files.

Bruce

Quoted 29 lines
---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-kernel/linux/kernel-devsrc.bb +1 -1
index ce5777fbe9..c2aeb8e216 100644
@@ -62,6 +62,7 @@ do_install() {
        cd ${S}
        cp --parents $(find  -type f -name "Makefile*" -o -name "Kconfig*") $kerneldir/build
        cp --parents $(find  -type f -name "Build" -o -name "Build.include") $kerneldir/build
+       cp --parents $(find tools/  -type f -name "*.c" -o -name "*.h") $kerneldir/build
     )
 
     # then drop all but the needed Makefiles/Kconfig files
--

2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193563): https://lists.openembedded.org/g/openembedded-core/message/193563
Mute This Topic: https://lists.openembedded.org/mt/103676210/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#2 lore raw
Quoted 12 lines · Bruce Ashfield
Quoted 10 lines · Chen Qi via lists.openembedded.org

From: Chen Qi <[email protected]>

The source files under tools/ also need to be copied because in some case, they'll be needed. For example, in case that the CONFIG_DEBUG_INFO_BTF is enabled, we'll get the following error without this patch when doing 'make prepare'.

No rule to make target '/.../tools/bpf/resolve_btfids/main.o', needed by '/.../tools/bpf/resolve_btfids/resolve_btfids-in.o'. Stop.

Quoted 7 lines

Tools has been excluded on purpose, as it is relatively large (and complex) compared to the rest of the curated files.

Figure out just what you need for bpf, and copy only those files.

Bruce

I can do that. However, I want to raise my concern here first. Does the 30M really matter, compared to the potential errors that would possibly give users bad impression?

Before enabling CONFIG_DEBUG_INFO_BTF, things were working pretty well for us. In fact, I was a little surprised that adding extra configs would result in failure of 'make prepare'.

Not sure if CONFIG_DEBUG_INFO_BTF is the last one. I guess it's probably not.

Again, if users are using kernel-devsrc for compiling things, do they really care about the 30M size?

Regards,

Qi

Quoted 30 lines
Quoted 29 lines
---
  meta/recipes-kernel/linux/kernel-devsrc.bb | 1 +
  1 file changed, 1 insertion(+)
meta/recipes-kernel/linux/kernel-devsrc.bb +1 -1
index ce5777fbe9..c2aeb8e216 100644
@@ -62,6 +62,7 @@ do_install() {
         cd ${S}
         cp --parents $(find  -type f -name "Makefile*" -o -name "Kconfig*") $kerneldir/build
         cp --parents $(find  -type f -name "Build" -o -name "Build.include") $kerneldir/build
+       cp --parents $(find tools/  -type f -name "*.c" -o -name "*.h") $kerneldir/build
      )
 
      # then drop all but the needed Makefiles/Kconfig files
--

2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193563): https://lists.openembedded.org/g/openembedded-core/message/193563
Mute This Topic: https://lists.openembedded.org/mt/103676210/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
Quoted 17 lines · ChenQi
Quoted 15 lines · Bruce Ashfield
Quoted 10 lines · Chen Qi via lists.openembedded.org

From: Chen Qi <[email protected]>

The source files under tools/ also need to be copied because in some case, they'll be needed. For example, in case that the CONFIG_DEBUG_INFO_BTF is enabled, we'll get the following error without this patch when doing 'make prepare'.

No rule to make target '/.../tools/bpf/resolve_btfids/main.o', needed by '/.../tools/bpf/resolve_btfids/resolve_btfids-in.o'. Stop.

Tools has been excluded on purpose, as it is relatively large (and complex) compared to the rest of the curated files.

Quoted 8 lines
Quoted 4 lines

Figure out just what you need for bpf, and copy only those files.

Bruce

I can do that. However, I want to raise my concern here first. Does the 30M really matter, compared to the potential errors that would possibly give users bad impression?

Yes, it actually does matter.

That's the entire design principle behind devsrc. It is carefully curated.

Considering something like this pops up every couple of years, I'm quite confident that there are very few bad impressions to be made.

As you could see from the file that there are many specific copies from the tools/ directory structure. That should be the hint that if we wanted to copy tools in its entirety .. we would have done that long ago.

Quoted 10 lines

Before enabling CONFIG_DEBUG_INFO_BTF, things were working pretty well for us. In fact, I was a little surprised that adding extra configs would result in failure of 'make prepare'.

Not sure if CONFIG_DEBUG_INFO_BTF is the last one. I guess it's probably not.

Again, if users are using kernel-devsrc for compiling things, do they really care about the 30M size?

It's not relevant if they do or don't care. It is the principle of keeping it as minimal as possible and not doing things "just in case".

There's a bugzilla that I've attached a patch that creates a parallel full source copy of the kernel, but we've never merged it as keeping to the low footprint design principle is important.

Bruce

Quoted 37 lines

Regards,

Qi

Quoted 30 lines
Quoted 29 lines
---
  meta/recipes-kernel/linux/kernel-devsrc.bb | 1 +
  1 file changed, 1 insertion(+)
meta/recipes-kernel/linux/kernel-devsrc.bb +1 -1
index ce5777fbe9..c2aeb8e216 100644
@@ -62,6 +62,7 @@ do_install() {
         cd ${S}
         cp --parents $(find  -type f -name "Makefile*" -o -name "Kconfig*") $kerneldir/build
         cp --parents $(find  -type f -name "Build" -o -name "Build.include") $kerneldir/build
+       cp --parents $(find tools/  -type f -name "*.c" -o -name "*.h") $kerneldir/build
      )
 
      # then drop all but the needed Makefiles/Kconfig files
--

2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193563): https://lists.openembedded.org/g/openembedded-core/message/193563
Mute This Topic: https://lists.openembedded.org/mt/103676210/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#4 lore raw
Quoted 44 lines · Bruce Ashfield
Quoted 16 lines · ChenQi
Quoted 15 lines · Bruce Ashfield
Quoted 10 lines · Chen Qi via lists.openembedded.org

From: Chen Qi <[email protected]>

The source files under tools/ also need to be copied because in some case, they'll be needed. For example, in case that the CONFIG_DEBUG_INFO_BTF is enabled, we'll get the following error without this patch when doing 'make prepare'.

No rule to make target '/.../tools/bpf/resolve_btfids/main.o', needed by '/.../tools/bpf/resolve_btfids/resolve_btfids-in.o'. Stop.

Tools has been excluded on purpose, as it is relatively large (and complex) compared to the rest of the curated files.

Quoted 7 lines
Quoted 4 lines

Figure out just what you need for bpf, and copy only those files.

Bruce

I can do that. However, I want to raise my concern here first. Does the 30M really matter, compared to the potential errors that would possibly give users bad impression?

Yes, it actually does matter.

That's the entire design principle behind devsrc. It is carefully curated.

Considering something like this pops up every couple of years, I'm quite confident that there are very few bad impressions to be made.

As you could see from the file that there are many specific copies from the tools/ directory structure. That should be the hint that if we wanted to copy tools in its entirety .. we would have done that long ago.

Quoted 9 lines

Before enabling CONFIG_DEBUG_INFO_BTF, things were working pretty well for us. In fact, I was a little surprised that adding extra configs would result in failure of 'make prepare'.

Not sure if CONFIG_DEBUG_INFO_BTF is the last one. I guess it's probably not.

Again, if users are using kernel-devsrc for compiling things, do they really care about the 30M size?

Quoted 9 lines

It's not relevant if they do or don't care. It is the principle of keeping it as minimal as possible and not doing things "just in case".

There's a bugzilla that I've attached a patch that creates a parallel full source copy of the kernel, but we've never merged it as keeping to the low footprint design principle is important.

Bruce

Got it. Thanks for the info.

Regards,

Qi

Quoted 35 lines
Quoted 34 lines

Regards,

Qi

Quoted 29 lines
Quoted 29 lines
---
   meta/recipes-kernel/linux/kernel-devsrc.bb | 1 +
   1 file changed, 1 insertion(+)
meta/recipes-kernel/linux/kernel-devsrc.bb +1 -1
index ce5777fbe9..c2aeb8e216 100644
@@ -62,6 +62,7 @@ do_install() {
          cd ${S}
          cp --parents $(find  -type f -name "Makefile*" -o -name "Kconfig*") $kerneldir/build
          cp --parents $(find  -type f -name "Build" -o -name "Build.include") $kerneldir/build
+       cp --parents $(find tools/  -type f -name "*.c" -o -name "*.h") $kerneldir/build
       )
 
       # then drop all but the needed Makefiles/Kconfig files
--

2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193563): https://lists.openembedded.org/g/openembedded-core/message/193563
Mute This Topic: https://lists.openembedded.org/mt/103676210/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-