Skip to contentSkip to conversation

bus: tegra-aconnect: Update dependency to ARCH_TEGRA

PATCH Applied Peter Robinson 5 participants 8 messages Jan 12, 2024 – Jan 22, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 bus: tegra-aconnect: Update dependency to ARCH_TEGRA

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get this driver.

Fixes 46a88534afb59 ("bus: Add support for Tegra ACONNECT")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>

---

v2: fix spelling of option

 drivers/bus/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/bus/Kconfig +3 -2
index e6742998f372c..b003dad62d596 100644
@@ -186,11 +186,12 @@ config SUNXI_RSB
 
 config TEGRA_ACONNECT
 	tristate "Tegra ACONNECT Bus Driver"
-	depends on ARCH_TEGRA_210_SOC
+	depends on ARCH_TEGRA
 	depends on OF && PM
 	help
 	  Driver for the Tegra ACONNECT bus which is used to interface with
-	  the devices inside the Audio Processing Engine (APE) for Tegra210.
+	  the devices inside the Audio Processing Engine (APE) for
+	  Tegra210/Tegra186/Tegra194/Tegra234.
 
 config TEGRA_GMI
 	tristate "Tegra Generic Memory Interface bus driver"
Signature · 1 line
2.43.0
#1 lore raw

PATCH v2 2/2 dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get this driver.

Fixes 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sameer Pujar <[email protected]>
Cc Laxman Dewangan <[email protected]>

---

v2: fix spelling of option

 drivers/dma/Kconfig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/dma/Kconfig +7 -7
index 70ba506dabab5..de6eb370d485d 100644
@@ -629,16 +629,16 @@ config TEGRA20_APB_DMA
 
 config TEGRA210_ADMA
 	tristate "NVIDIA Tegra210 ADMA support"
-	depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST)
+	depends on (ARCH_TEGRA || COMPILE_TEST)
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help
-	  Support for the NVIDIA Tegra210 ADMA controller driver. The
-	  DMA controller has multiple DMA channels and is used to service
-	  various audio clients in the Tegra210 audio processing engine
-	  (APE). This DMA controller transfers data from memory to
-	  peripheral and vice versa. It does not support memory to
-	  memory data transfer.
+	  Support for the NVIDIA Tegra210/Tegra186/Tegra194/Tegra234 ADMA
+	  controller driver. The DMA controller has multiple DMA channels
+	  and is used to service various audio clients in the Tegra210
+	  audio processing engine (APE). This DMA controller transfers
+	  data from memory to peripheral and vice versa. It does not
+	  support memory to memory data transfer.
 
 config TIMB_DMA
 	tristate "Timberdale FPGA DMA support"
Signature · 1 line
2.43.0
maintainer Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA

Adding Vinod ...

Quoted 37 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get this driver.

Fixes 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sameer Pujar <[email protected]>
Cc Laxman Dewangan <[email protected]>

---

v2: fix spelling of option

  drivers/dma/Kconfig | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)
drivers/dma/Kconfig +1 -6
index 70ba506dabab5..de6eb370d485d 100644
@@ -629,16 +629,16 @@ config TEGRA20_APB_DMA
 
  config TEGRA210_ADMA
  	tristate "NVIDIA Tegra210 ADMA support"
-	depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST)
+	depends on (ARCH_TEGRA || COMPILE_TEST)
  	select DMA_ENGINE
  	select DMA_VIRTUAL_CHANNELS
  	help
-	  Support for the NVIDIA Tegra210 ADMA controller driver. The
-	  DMA controller has multiple DMA channels and is used to service
-	  various audio clients in the Tegra210 audio processing engine
-	  (APE). This DMA controller transfers data from memory to
-	  peripheral and vice versa. It does not support memory to

drivers/dma/Kconfig config TEGRA20_APB_DMA · line 644

Quoted 10 lines
drivers/dma/Kconfig +6 -1
-	  memory data transfer.
+	  Support for the NVIDIA Tegra210/Tegra186/Tegra194/Tegra234 ADMA
+	  controller driver. The DMA controller has multiple DMA channels
+	  and is used to service various audio clients in the Tegra210
+	  audio processing engine (APE). This DMA controller transfers
+	  data from memory to peripheral and vice versa. It does not
+	  support memory to memory data transfer.
 
  config TIMB_DMA
  	tristate "Timberdale FPGA DMA support"

Thanks!

Jon

Signature · 1 line
nvpublic
#3 lore raw

Re: [PATCH v2 2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA

In reply to Peter Robinson
Quoted 12 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get this driver.

Fixes 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sameer Pujar <[email protected]>
Cc Laxman Dewangan <[email protected]>
Quoted 6 lines

---

v2: fix spelling of option

 drivers/dma/Kconfig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Same comments as for the ACONNECT patch.

Thierry

maintainer Reviewed-by on v2 1/2
#4 lore raw
In reply to Peter Robinson
Quoted 26 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get this driver.

Fixes 46a88534afb59 ("bus: Add support for Tegra ACONNECT")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>

---

v2: fix spelling of option

  drivers/bus/Kconfig | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/bus/Kconfig +0 -1
index e6742998f372c..b003dad62d596 100644
@@ -186,11 +186,12 @@ config SUNXI_RSB
 
  config TEGRA_ACONNECT
  	tristate "Tegra ACONNECT Bus Driver"
-	depends on ARCH_TEGRA_210_SOC

drivers/bus/Kconfig config SUNXI_RSB · line 197

Quoted 10 lines
drivers/bus/Kconfig +3 -1
+	depends on ARCH_TEGRA
  	depends on OF && PM
  	help
  	  Driver for the Tegra ACONNECT bus which is used to interface with
-	  the devices inside the Audio Processing Engine (APE) for Tegra210.
+	  the devices inside the Audio Processing Engine (APE) for
+	  Tegra210/Tegra186/Tegra194/Tegra234.
 
  config TEGRA_GMI
  	tristate "Tegra Generic Memory Interface bus driver"

Thanks!

Jon

Signature · 1 line
nvpublic
#5 lore raw
In reply to Peter Robinson
Quoted 3 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific

I prefer spelling these out as Tegra210 for better greppability.

Quoted 20 lines

ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get this driver.

Fixes 46a88534afb59 ("bus: Add support for Tegra ACONNECT")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>

---

v2: fix spelling of option

 drivers/bus/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/bus/Kconfig +0 -0
index e6742998f372c..b003dad62d596 100644
@@ -186,11 +186,12 @@ config SUNXI_RSB
 

drivers/bus/Kconfig config SUNXI_RSB · line 194

Quoted 10 lines
drivers/bus/Kconfig +3 -2
 config TEGRA_ACONNECT
 	tristate "Tegra ACONNECT Bus Driver"
-	depends on ARCH_TEGRA_210_SOC
+	depends on ARCH_TEGRA
 	depends on OF && PM
 	help
 	  Driver for the Tegra ACONNECT bus which is used to interface with
-	  the devices inside the Audio Processing Engine (APE) for Tegra210.
+	  the devices inside the Audio Processing Engine (APE) for
+	  Tegra210/Tegra186/Tegra194/Tegra234.

Perhaps we want to say something like "Tegra210 and later"? I know it's going to be in at least one more, but I would think it's likely that it will stay around even longer.

Sameer, have you seen any indication that ACONNECT will go away in some future chip?

Thierry

#6 lore raw
Quoted 40 lines · Thierry Reding
Quoted 3 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific

I prefer spelling these out as Tegra210 for better greppability.

Quoted 20 lines

ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get this driver.

Fixes 46a88534afb59 ("bus: Add support for Tegra ACONNECT")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>

---

v2: fix spelling of option

  drivers/bus/Kconfig | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/bus/Kconfig +0 -0
index e6742998f372c..b003dad62d596 100644
@@ -186,11 +186,12 @@ config SUNXI_RSB
 

drivers/bus/Kconfig config SUNXI_RSB · line 194

Quoted 10 lines
drivers/bus/Kconfig +3 -2
  config TEGRA_ACONNECT
  	tristate "Tegra ACONNECT Bus Driver"
-	depends on ARCH_TEGRA_210_SOC
+	depends on ARCH_TEGRA
  	depends on OF && PM
  	help
  	  Driver for the Tegra ACONNECT bus which is used to interface with
-	  the devices inside the Audio Processing Engine (APE) for Tegra210.
+	  the devices inside the Audio Processing Engine (APE) for
+	  Tegra210/Tegra186/Tegra194/Tegra234.

Perhaps we want to say something like "Tegra210 and later"? I know it's going to be in at least one more, but I would think it's likely that it will stay around even longer.

Quoted 2 lines

Sameer, have you seen any indication that ACONNECT will go away in some future chip?

Yes, no signs of this going away. "Tegra210 and later" looks good.

maintainer Applied
#7 lore raw

Re: (subset) [PATCH v2 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA

In reply to Peter Robinson
Quoted 8 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just T210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes 210 you don't get this driver.

[...]

Applied, thanks!

[2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA

      commit: 33b7db45533af240fe44e809f9dc4d604cf82d07

Best regards,

Signature · 1 line
~Vinod