Skip to contentSkip to conversation

ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

PATCH Superseded Kenzo Gomez 3 participants 8 messages Jan 12, 2024 – Jan 30, 2024 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

Add new model entry into configuration table.

---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/cs35l41_hda_property.c +2 -0
index c1afb721b4c6..adfb31a6bf1e 100644
@@ -67,6 +67,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431DA2", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "10431E02", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
+	{ "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "10431EE2", I2C, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
 	{ "10431F12", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431F1F", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },
@@ -371,6 +372,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431D1F", generic_dsd_config },
 	{ "CSC3551", "10431DA2", generic_dsd_config },
 	{ "CSC3551", "10431E02", generic_dsd_config },
+	{ "CSC3551", "104316A3", generic_dsd_config },
 	{ "CSC3551", "10431EE2", generic_dsd_config },
 	{ "CSC3551", "10431F12", generic_dsd_config },
 	{ "CSC3551", "10431F1F", generic_dsd_config },
Signature · 1 line
2.43.0
#1 lore raw

Hi,

Quoted 8 lines

-----Original Message-----
From: Kenzo Gomez <[email protected]>
Sent: Friday, January 12, 2024 4:32 PM
To: [email protected]
Cc: Kenzo Gomez <[email protected]>; James Schulman <[email protected]>; David Rhodes <[email protected]>; Richard Fitzgerald <[email protected]>; Jaroslav Kysela <[email protected]>;

Takashi

Quoted 27 lines

Iwai <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]
Subject: [PATCH] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

Add new model entry into configuration table.

---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/cs35l41_hda_property.c +0 -0
index c1afb721b4c6..adfb31a6bf1e 100644
@@ -67,6 +67,7 @@ static const struct cs35l41_config
 cs35l41_config_table[] = {
 	{ "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431DA2", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "10431E02", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,

0, 0 }, 1, 2, 0, 0, 0, 0 },

sound/pci/hda/cs35l41_hda_property.c +1 -0
+	{ "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
Quoted 1 line

0, 0 }, 1, 2, 0, 0, 0, 0 },

This entry looks correct, but this table is supposed to be sorted by SSID,
can you move the entry to its correct location?

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_prop_model · line 376

Quoted 12 lines

{ "10431EE2", I2C, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
0, 0 }, 0, -1, -1, 0, 0, 0 },
{ "10431F12", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
0, 0 }, 0, 1, -1, 1000, 4500, 24 },
{ "10431F1F", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT,
0, 0 }, 1, -1, 0, 0, 0, 0 },

sound/pci/hda/cs35l41_hda_property.c +1 -0
@@ -371,6 +372,7 @@ static const struct cs35l41_prop_model
 cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431D1F", generic_dsd_config },
 	{ "CSC3551", "10431DA2", generic_dsd_config },
 	{ "CSC3551", "10431E02", generic_dsd_config },
+	{ "CSC3551", "104316A3", generic_dsd_config },

Same with this table, it should be sorted by SSID.

Quoted 6 lines
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "CSC3551", "10431EE2", generic_dsd_config },
 	{ "CSC3551", "10431F12", generic_dsd_config },

{ "CSC3551", "10431F1F", generic_dsd_config },
--
2.43.0

Thanks,
Stefan

#2 lore raw

PATCH v2 1/1 ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

In reply to Kenzo Gomez

Add new model entry into configuration table.

---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/cs35l41_hda_property.c +2 -0
index c1afb721b4c6..9ec5773e580e 100644
@@ -54,6 +54,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431533", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431573", SPI, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431663", SPI, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+	{ "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316D3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316F3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104317F3", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -358,6 +359,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431533", generic_dsd_config },
 	{ "CSC3551", "10431573", generic_dsd_config },
 	{ "CSC3551", "10431663", generic_dsd_config },
+	{ "CSC3551", "104316A3", generic_dsd_config },
 	{ "CSC3551", "104316D3", generic_dsd_config },
 	{ "CSC3551", "104316F3", generic_dsd_config },
 	{ "CSC3551", "104317F3", generic_dsd_config },
Signature · 1 line
2.43.0
#3 lore raw
Quoted 4 lines · Kenzo Gomez

Add new model entry into configuration table.

This isn't applied cleanly to the latest code, as there were code changes to drop some fields.

Please rebase on top of for-linus branch of sound.git tree (or the latest Linus tree) and resubmit.

thanks,

Takashi

Quoted 27 lines
---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/cs35l41_hda_property.c +2 -0
index c1afb721b4c6..9ec5773e580e 100644
@@ -54,6 +54,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431533", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431573", SPI, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431663", SPI, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+	{ "104316A3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316D3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316F3", SPI, 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104317F3", I2C, 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -358,6 +359,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431533", generic_dsd_config },
 	{ "CSC3551", "10431573", generic_dsd_config },
 	{ "CSC3551", "10431663", generic_dsd_config },
+	{ "CSC3551", "104316A3", generic_dsd_config },
 	{ "CSC3551", "104316D3", generic_dsd_config },
 	{ "CSC3551", "104316F3", generic_dsd_config },
 	{ "CSC3551", "104317F3", generic_dsd_config },
Signature · 1 line
2.43.0
#4 lore raw

PATCH v3 1/1 ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

Add new model entry into configuration table.

---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/cs35l41_hda_property.c +2 -0
index 35277ce890a4..59504852adc6 100644
@@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+	{ "104316A3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431533", generic_dsd_config },
 	{ "CSC3551", "10431573", generic_dsd_config },
 	{ "CSC3551", "10431663", generic_dsd_config },
+	{ "CSC3551", "104316A3", generic_dsd_config },
 	{ "CSC3551", "104316D3", generic_dsd_config },
 	{ "CSC3551", "104316F3", generic_dsd_config },
 	{ "CSC3551", "104317F3", generic_dsd_config },
Signature · 1 line
2.43.0
#5 lore raw
Quoted 4 lines · Kenzo Gomez

Add new model entry into configuration table.

Cirrus people, could you take a look?
I'm inclined to take as is, unless you have any objections.

thanks,

Takashi

Quoted 27 lines
---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/cs35l41_hda_property.c +2 -0
index 35277ce890a4..59504852adc6 100644
@@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+	{ "104316A3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431533", generic_dsd_config },
 	{ "CSC3551", "10431573", generic_dsd_config },
 	{ "CSC3551", "10431663", generic_dsd_config },
+	{ "CSC3551", "104316A3", generic_dsd_config },
 	{ "CSC3551", "104316D3", generic_dsd_config },
 	{ "CSC3551", "104316F3", generic_dsd_config },
 	{ "CSC3551", "104317F3", generic_dsd_config },
Signature · 1 line
2.43.0
#6 lore raw

Hi,

Quoted 15 lines

-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Tuesday, January 30, 2024 11:05 AM
To: Kenzo Gomez <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v3] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

Quoted 1 line · Kenzo Gomez
Quoted 6 lines
Quoted 3 lines

Add new model entry into configuration table.

Cirrus people, could you take a look?
I'm inclined to take as is, unless you have any objections.

Looks good to me.

Thanks,
Stefan

Quoted 43 lines

thanks,

Takashi

Review

Quoted 5 lines
---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/sound/pci/hda/cs35l41_hda_property.c

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config

Quoted 4 lines

index 35277ce890a4..59504852adc6 100644

sound/pci/hda/cs35l41_hda_property.c +0 -0
@@ -76,6 +76,7 @@ static const struct cs35l41_config

cs35l41_config_table[] = {

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 76

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,

0 }, 0, 1, -1, 1000, 4500, 24 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 77

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,

0 }, 1, 2, 0, 1000, 4500, 24 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 78

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,

0 }, 1, -1, 0, 1000, 4500, 24 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 79

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +1 -0
+	{ "104316A3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,

0 }, 1, 2, 0, 0, 0, 0 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 80

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,

0 }, 1, 2, 0, 0, 0, 0 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 81

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,

0 }, 1, 2, 0, 0, 0, 0 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 82

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,

0 }, 0, 1, -1, 1000, 4500, 24 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_prop_model

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
@@ -410,6 +411,7 @@ static const struct cs35l41_prop_model

cs35l41_prop_model_table[] = {

Quoted 10 lines
sound/pci/hda/cs35l41_hda_property.c +1 -1
 	{ "CSC3551", "10431533", generic_dsd_config },
 	{ "CSC3551", "10431573", generic_dsd_config },
 	{ "CSC3551", "10431663", generic_dsd_config },
+	{ "CSC3551", "104316A3", generic_dsd_config },
 	{ "CSC3551", "104316D3", generic_dsd_config },
 	{ "CSC3551", "104316F3", generic_dsd_config },
 	{ "CSC3551", "104317F3", generic_dsd_config },
--

2.43.0