Skip to contentSkip to conversation

test: move lcores/pdump/pflock/ticketlock out of fast suite

PATCH In review [email protected] 2 participants 2 messages Jan 12, 2024 – Oct 4, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test: move lcores/pdump/pflock/ticketlock out of fast suite

From: Luca Boccassi <[email protected]>

These tests are failing with timeouts on build machines with large amount of cores, so move them out of the fast suite, which should complete in seconds.

33/77 DPDK:fast-tests / lcores_autotest TIMEOUT 50.01s
https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_11/aarch64

43/77 DPDK:fast-tests / pdump_autotest TIMEOUT 120.11s killed by signal 15 SIGTERM
https://ci.debian.net/packages/d/dpdk/unstable/ppc64el/41544027/#S10

45/77 DPDK:fast-tests / pflock_autotest             TIMEOUT        120.14s   killed by signal 15 SIGTERM
72/77 DPDK:fast-tests / ticketlock_autotest         TIMEOUT        120.12s   killed by signal 15 SIGTERM

https://ci.debian.net/packages/d/dpdk/unstable/amd64/41560884/#S10

---
 app/test/test_lcores.c     | 2 +-
 app/test/test_pdump.c      | 2 +-
 app/test/test_pflock.c     | 2 +-
 app/test/test_ticketlock.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
app/test/test_lcores.c +1 -1
index 22225a9fd3..bebd830399 100644
@@ -411,4 +411,4 @@ test_lcores(void)
 	return TEST_SUCCESS;
 }
 
-REGISTER_FAST_TEST(lcores_autotest, true, true, test_lcores);
+REGISTER_TEST_COMMAND(lcores_autotest, test_lcores);
app/test/test_pdump.c +1 -1
index 9f7769707e..adf49f0b54 100644
@@ -219,4 +219,4 @@ test_pdump(void)
 	return TEST_SUCCESS;
 }
 
-REGISTER_FAST_TEST(pdump_autotest, true, false, test_pdump);
+REGISTER_TEST_COMMAND(pdump_autotest, test_pdump);
app/test/test_pflock.c +1 -1
index 5f77b158c8..38da6bce27 100644
@@ -193,4 +193,4 @@ test_pflock(void)
 	return 0;
 }
 
-REGISTER_FAST_TEST(pflock_autotest, true, true, test_pflock);
+REGISTER_TEST_COMMAND(pflock_autotest, test_pflock);
app/test/test_ticketlock.c +1 -1
index 1fbbedb33b..242c136478 100644
@@ -314,4 +314,4 @@ test_ticketlock(void)
 	return ret;
 }
 
-REGISTER_FAST_TEST(ticketlock_autotest, true, true, test_ticketlock);
+REGISTER_TEST_COMMAND(ticketlock_autotest, test_ticketlock);
Signature · 1 line
2.39.2
#1 lore raw
Quoted 8 lines · On Fri, 12 Jan 2024 20:10:56 +0000 [email protected] wrote:

From: Luca Boccassi <[email protected]>

These tests are failing with timeouts on build machines with large amount of cores, so move them out of the fast suite, which should complete in seconds.

33/77 DPDK:fast-tests / lcores_autotest TIMEOUT 50.01s
https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_11/aarch64

Quoted 8 lines

43/77 DPDK:fast-tests / pdump_autotest TIMEOUT 120.11s killed by signal 15 SIGTERM
https://ci.debian.net/packages/d/dpdk/unstable/ppc64el/41544027/#S10

45/77 DPDK:fast-tests / pflock_autotest             TIMEOUT        120.14s   killed by signal 15 SIGTERM
72/77 DPDK:fast-tests / ticketlock_autotest         TIMEOUT        120.12s   killed by signal 15 SIGTERM

https://ci.debian.net/packages/d/dpdk/unstable/amd64/41560884/#S10

Moving the test makes sense but having it dangling causes new warnings.

app/test/suites/meson.build:35: WARNING: Test "pflock_autotest" is not defined in any test suite app/test/suites/meson.build:35: WARNING: Test "ticketlock_autotest" is not defined in any test suite

Maybe increase the timeout or add to perf test suite instead?