ASoC: SOF: ipc4: Kernel log noise reduction for 6.8
Subsystems (3)
Peter Ujfalusi
maintainercover ASoC: SOF: ipc4: Kernel log noise reduction for 6.8
Hi,
two patches to remove too intrusive prints:
no llp found, fall back to default HDA path
No CPC match in the firmware file's manifest (ibs/obs: 384/384)
The llp print is printed for all HDA endpoints which is not supported by llp.
The CPC info print turned out to be too noisy and it is not bringing any benefit to users and developers.
Regards,
Peter
---
Kai Vehmanen (1):
ASoC: SOF: ipc4-loader: remove the CPC check warnings
Rander Wang (1):
ASoC: SOF: ipc4-pcm: remove log message for LLP
sound/soc/sof/ipc4-loader.c | 11 ++++------- sound/soc/sof/ipc4-pcm.c | 4 +--- 2 files changed, 5 insertions(+), 10 deletions(-)
Signature · 1 line
2.43.0
Peter Ujfalusi
maintainerPATCH 1/2 ASoC: SOF: ipc4-pcm: remove log message for LLP
From: Rander Wang <[email protected]>
LLP is supported by I2S and SDW platforms but not supported by HDA platforms. This log is used to notify developer current LLP status for current device. Since above case is known to developers, the log is unnecessary and should be removed.
--- sound/soc/sof/ipc4-pcm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
sound/soc/sof/ipc4-pcm.c +1 -3
@@ -768,10 +768,8 @@ static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pc info->llp_offset = offsetof(struct sof_ipc4_fw_registers , llp_evad_reading_slot) + sdev->fw_info_box.offset;sof_mailbox_read (sdev, info->llp_offset, &llp_slot,sizeof (llp_slot)); -if (llp_slot.node_id != dai_copier->data.gtw_cfg.node_id) { -dev_info (sdev->dev,"no llp found, fall back to default HDA path" ); +if (llp_slot.node_id != dai_copier->data.gtw_cfg.node_id) info->llp_offset =0 ; - } } static int sof_ipc4_pcm_hw_params(struct snd_soc_component *component,
Signature · 1 line
2.43.0
Peter Ujfalusi
maintainerPATCH 2/2 ASoC: SOF: ipc4-loader: remove the CPC check warnings
In reply to Peter UjfalusiFrom: Kai Vehmanen <[email protected]>
Warnings related to missing data in firmware manifest have proven to be too verbose. This relates to description of DSP module cost expressed in cycles per chunk (CPC). If a matching value is not found in the manifest, kernel will pass a zero value and DSP firmware will use a conservative value in its place.
Downgrade the warnings to dev_dbg().
--- sound/soc/sof/ipc4-loader.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
sound/soc/sof/ipc4-loader.c +4 -7
@@ -482,13 +482,10 @@ void sof_ipc4_update_cpc_from_manifest(struct snd_sof_dev *sdev, msg ="No CPC match in the firmware file's manifest" ; no_cpc: -dev_warn (sdev->dev,"%s (UUID: %pUL): %s (ibs/obs: %u/%u)\n" , - fw_module->man4_module_entry.name, - &fw_module->man4_module_entry.uuid, msg, basecfg->ibs, - basecfg->obs); -dev_warn_once (sdev->dev,"Please try to update the firmware.\n" ); -dev_warn_once (sdev->dev,"If the issue persists, file a bug at\n" ); -dev_warn_once (sdev->dev,"https://github.com/thesofproject/sof/issues/\n" ); +dev_dbg (sdev->dev,"%s (UUID: %pUL): %s (ibs/obs: %u/%u)\n" , + fw_module->man4_module_entry.name, + &fw_module->man4_module_entry.uuid, msg, basecfg->ibs, + basecfg->obs); }const struct sof_ipc_fw_loader_ops ipc4_loader_ops = {
Signature · 1 line
2.43.0
Mark Brown
maintainerQuoted 10 lines · Peter Ujfalusi
two patches to remove too intrusive prints:
no llp found, fall back to default HDA path
No CPC match in the firmware file's manifest (ibs/obs: 384/384)The llp print is printed for all HDA endpoints which is not supported by llp.
The CPC info print turned out to be too noisy and it is not bringing any benefit to users and developers.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: SOF: ipc4-pcm: remove log message for LLP
commit: 848c8f563dadfdf01358b001ef7c9afe2a6ece8f
[2/2] ASoC: SOF: ipc4-loader: remove the CPC check warnings
commit: ab09fb9c629ed3aaea6a82467f08595dbc549726All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark