virtio-iommu: Use qemu_real_host_page_mask as default page_size_mask
PATCH v2 1/1 virtio-iommu: Use qemu_real_host_page_mask as default page_size_mask
We used to set default page_size_mask to qemu_target_page_mask() but with VFIO assignment it makes more sense to use the actual host page mask instead.
So from now on qemu_real_host_page_mask() will be used as a default. To be able to migrate older code, we increase the vmstat version_id to 3 and if an older incoming v2 stream is detected we set the previous default value.
The new default is well adapted to configs where host and guest have the same page size. This allows to fix hotplugging VFIO devices on a 64kB guest and a 64kB host. This test case has been failing before and even crashing qemu with hw_error("vfio: DMA mapping failed, unable to continue") in VFIO common). Indeed the hot-attached VFIO device would call memory_region_iommu_set_page_size_mask with 64kB mask whereas after the granule was frozen to 4kB on machine init done. Now this works. However the new default will prevent 4kB guest on 64kB host because the granule will be set to 64kB which would be larger than the guest page size. In that situation, the virtio-iommu driver fails on viommu_domain_finalise() with
"granule 0x10000 larger than system page size 0x1000".
The current limitation of global granule in the virtio-iommu should be removed and turned into per domain granule. But until we get this upgraded, this new default is probably better because I don't think anyone is currently interested in running a 4kB page size guest with virtio-iommu on a 64kB host. However supporting 64kB guest on 64kB host with virtio-iommu and VFIO looks a more important feature.
---
v1 -> v2:
- fixed 2 typos in the commit msg and added Jean's R-b and T-b
--- hw/virtio/virtio-iommu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
hw/virtio/virtio-iommu.c +5 -2
@@ -1313,7 +1313,7 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp)* in vfio realize */ s->config.bypass = s->boot_bypass; - s->config.page_size_mask =qemu_target_page_mask (); + s->config.page_size_mask =qemu_real_host_page_mask (); s->config.input_range.end =UINT64_MAX ; s->config.domain_range.end =UINT32_MAX ; s->config.probe_size =VIOMMU_PROBE_SIZE ;
@@ -1491,13 +1491,16 @@ static int iommu_post_load(void *opaque, int version_id)* still correct. */ virtio_iommu_switch_address_space_all (s); +if (version_id <=2 ) { + s->config.page_size_mask =qemu_target_page_mask (); + }return 0 ; }static const VMStateDescription vmstate_virtio_iommu_device = { .name ="virtio-iommu-device" , .minimum_version_id =2 , - .version_id =2 , + .version_id =3 , .post_load = iommu_post_load, .fields = (const VMStateField []) { VMSTATE_GTREE_DIRECT_KEY_V(domains, VirtIOIOMMU, 2,
Signature · 1 line
2.41.0
Quoted 30 lines · Eric Auger
We used to set default
page_size_masktoqemu_target_page_mask()but with VFIO assignment it makes more sense to use the actual host page mask instead.So from now on
qemu_real_host_page_mask()will be used as a default. To be able to migrate older code, we increase the vmstatversion_idto 3 and if an older incoming v2 stream is detected we set the previous default value.The new default is well adapted to configs where host and guest have the same page size. This allows to fix hotplugging VFIO devices on a 64kB guest and a 64kB host. This test case has been failing before and even crashing qemu with
hw_error("vfio: DMA mapping failed, unable to continue")in VFIO common). Indeed the hot-attached VFIO device would callmemory_region_iommu_set_page_size_maskwith 64kB mask whereas after the granule was frozen to 4kB on machine init done. Now this works. However the new default will prevent 4kB guest on 64kB host because the granule will be set to 64kB which would be larger than the guest page size. In that situation, the virtio-iommu driver fails onviommu_domain_finalise()with
"granule0x10000larger than system page size0x1000".The current limitation of global granule in the virtio-iommu should be removed and turned into per domain granule. But until we get this upgraded, this new default is probably better because I don't think anyone is currently interested in running a 4kB page size guest with virtio-iommu on a 64kB host. However supporting 64kB guest on 64kB host with virtio-iommu and VFIO looks a more important feature.
Quoted 3 lines
Signed-off-by Eric Auger <[email protected]>Reviewed-by Jean-Philippe Brucker <[email protected]>
What about migration compatibility? In particular, cross-version one? Don't we need compat machinery for this?
Quoted 41 lines
---
v1 -> v2:
- fixed 2 typos in the commit msg and added Jean's R-b and T-b--- hw/virtio/virtio-iommu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)hw/virtio/virtio-iommu.c +5
-2@@ -1313,7 +1313,7 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp)* in vfio realize */ s->config.bypass = s->boot_bypass; - s->config.page_size_mask =qemu_target_page_mask (); + s->config.page_size_mask =qemu_real_host_page_mask (); s->config.input_range.end =UINT64_MAX ; s->config.domain_range.end =UINT32_MAX ; s->config.probe_size =VIOMMU_PROBE_SIZE ;@@ -1491,13 +1491,16 @@ static int iommu_post_load(void *opaque, int version_id)* still correct. */ virtio_iommu_switch_address_space_all (s); +if (version_id <=2 ) { + s->config.page_size_mask =qemu_target_page_mask (); + }return 0 ; }static const VMStateDescription vmstate_virtio_iommu_device = { .name ="virtio-iommu-device" , .minimum_version_id =2 , - .version_id =2 , + .version_id =3 , .post_load = iommu_post_load, .fields = (const VMStateField []) { VMSTATE_GTREE_DIRECT_KEY_V(domains, VirtIOIOMMU, 2,Signature · 1 line
2.41.0
Hi Michael,
Quoted 31 lines · Michael S. Tsirkin
Quoted 30 lines · Eric Auger
We used to set default
page_size_masktoqemu_target_page_mask()but with VFIO assignment it makes more sense to use the actual host page mask instead.So from now on
qemu_real_host_page_mask()will be used as a default. To be able to migrate older code, we increase the vmstatversion_idto 3 and if an older incoming v2 stream is detected we set the previous default value.The new default is well adapted to configs where host and guest have the same page size. This allows to fix hotplugging VFIO devices on a 64kB guest and a 64kB host. This test case has been failing before and even crashing qemu with
hw_error("vfio: DMA mapping failed, unable to continue")in VFIO common). Indeed the hot-attached VFIO device would callmemory_region_iommu_set_page_size_maskwith 64kB mask whereas after the granule was frozen to 4kB on machine init done. Now this works. However the new default will prevent 4kB guest on 64kB host because the granule will be set to 64kB which would be larger than the guest page size. In that situation, the virtio-iommu driver fails onviommu_domain_finalise()with
"granule0x10000larger than system page size0x1000".The current limitation of global granule in the virtio-iommu should be removed and turned into per domain granule. But until we get this upgraded, this new default is probably better because I don't think anyone is currently interested in running a 4kB page size guest with virtio-iommu on a 64kB host. However supporting 64kB guest on 64kB host with virtio-iommu and VFIO looks a more important feature.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Eric Auger <[email protected]>Reviewed-by Jean-Philippe Brucker <[email protected]>What about migration compatibility? In particular, cross-version one? Don't we need compat machinery for this?
See below
Quoted 20 lines
Quoted 20 lines
---
v1 -> v2:
- fixed 2 typos in the commit msg and added Jean's R-b and T-b--- hw/virtio/virtio-iommu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)hw/virtio/virtio-iommu.c +1
-1@@ -1313,7 +1313,7 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp)* in vfio realize */ s->config.bypass = s->boot_bypass; - s->config.page_size_mask =qemu_target_page_mask (); + s->config.page_size_mask =qemu_real_host_page_mask (); s->config.input_range.end =UINT64_MAX ;
Quoted 8 lines
hw/virtio/virtio-iommu.c static int iommu_post_load(void *opaque, int version_id) · line 1495
Quoted 8 lines
hw/virtio/virtio-iommu.c +2
-0s->config.domain_range.end =UINT32_MAX ; s->config.probe_size =VIOMMU_PROBE_SIZE ;@@ -1491,13 +1491,16 @@ static int iommu_post_load(void *opaque, int version_id)* still correct. */ virtio_iommu_switch_address_space_all (s); +if (version_id <=2 ) { + s->config.page_size_mask =qemu_target_page_mask ();
I tested migration from v2 -> v3 and the above code is overriding the new default by the older one.
Do you have an other concern?
Thanks
Eric
Quoted 14 lines
Quoted 14 lines
hw/virtio/virtio-iommu.c +2
-1+ }return 0 ; }static const VMStateDescription vmstate_virtio_iommu_device = { .name ="virtio-iommu-device" , .minimum_version_id =2 , - .version_id =2 , + .version_id =3 , .post_load = iommu_post_load, .fields = (const VMStateField []) { VMSTATE_GTREE_DIRECT_KEY_V(domains, VirtIOIOMMU, 2,Signature · 1 line
2.41.0
Quoted 71 lines · Eric Auger
Hi Michael,
Quoted 31 lines · Michael S. Tsirkin
Quoted 30 lines · Eric Auger
We used to set default
page_size_masktoqemu_target_page_mask()but with VFIO assignment it makes more sense to use the actual host page mask instead.So from now on
qemu_real_host_page_mask()will be used as a default. To be able to migrate older code, we increase the vmstatversion_idto 3 and if an older incoming v2 stream is detected we set the previous default value.The new default is well adapted to configs where host and guest have the same page size. This allows to fix hotplugging VFIO devices on a 64kB guest and a 64kB host. This test case has been failing before and even crashing qemu with
hw_error("vfio: DMA mapping failed, unable to continue")in VFIO common). Indeed the hot-attached VFIO device would callmemory_region_iommu_set_page_size_maskwith 64kB mask whereas after the granule was frozen to 4kB on machine init done. Now this works. However the new default will prevent 4kB guest on 64kB host because the granule will be set to 64kB which would be larger than the guest page size. In that situation, the virtio-iommu driver fails onviommu_domain_finalise()with
"granule0x10000larger than system page size0x1000".The current limitation of global granule in the virtio-iommu should be removed and turned into per domain granule. But until we get this upgraded, this new default is probably better because I don't think anyone is currently interested in running a 4kB page size guest with virtio-iommu on a 64kB host. However supporting 64kB guest on 64kB host with virtio-iommu and VFIO looks a more important feature.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Eric Auger <[email protected]>Reviewed-by Jean-Philippe Brucker <[email protected]>What about migration compatibility? In particular, cross-version one? Don't we need compat machinery for this?
See below
Quoted 20 lines
Quoted 20 lines
---
v1 -> v2:
- fixed 2 typos in the commit msg and added Jean's R-b and T-b--- hw/virtio/virtio-iommu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)hw/virtio/virtio-iommu.c +1
-1@@ -1313,7 +1313,7 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp)* in vfio realize */ s->config.bypass = s->boot_bypass; - s->config.page_size_mask =qemu_target_page_mask (); + s->config.page_size_mask =qemu_real_host_page_mask (); s->config.input_range.end =UINT64_MAX ;Quoted 8 lines
hw/virtio/virtio-iommu.c static int iommu_post_load(void *opaque, int version_id) · line 1495
Quoted 8 lines
hw/virtio/virtio-iommu.c +2
-0s->config.domain_range.end =UINT32_MAX ; s->config.probe_size =VIOMMU_PROBE_SIZE ;@@ -1491,13 +1491,16 @@ static int iommu_post_load(void *opaque, int version_id)* still correct. */ virtio_iommu_switch_address_space_all (s); +if (version_id <=2 ) { + s->config.page_size_mask =qemu_target_page_mask ();I tested migration from v2 -> v3 and the above code is overriding the new default by the older one.
Quoted 20 lines
Do you have an other concern?
Thanks
Eric
Quoted 12 lines
Quoted 12 lines
hw/virtio/virtio-iommu.c +2
-1+ }return 0 ; }static const VMStateDescription vmstate_virtio_iommu_device = { .name ="virtio-iommu-device" , .minimum_version_id =2 , - .version_id =2 , + .version_id =3 , .post_load = iommu_post_load, .fields = (const VMStateField []) { VMSTATE_GTREE_DIRECT_KEY_V(domains, VirtIOIOMMU, 2,
Oh I missed the version change. But then migration to older version is completely broken isn't it? Old qemu can not handle version_id 3 at all.
Generally, compat machinery is nicer than the old version hacks.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Signature · 1 line
2.41.0
Quoted 90 lines · Michael S. Tsirkin
Quoted 70 lines · Eric Auger
Hi Michael,
Quoted 31 lines · Michael S. Tsirkin
Quoted 30 lines · Eric Auger
We used to set default
page_size_masktoqemu_target_page_mask()but with VFIO assignment it makes more sense to use the actual host page mask instead.So from now on
qemu_real_host_page_mask()will be used as a default. To be able to migrate older code, we increase the vmstatversion_idto 3 and if an older incoming v2 stream is detected we set the previous default value.The new default is well adapted to configs where host and guest have the same page size. This allows to fix hotplugging VFIO devices on a 64kB guest and a 64kB host. This test case has been failing before and even crashing qemu with
hw_error("vfio: DMA mapping failed, unable to continue")in VFIO common). Indeed the hot-attached VFIO device would callmemory_region_iommu_set_page_size_maskwith 64kB mask whereas after the granule was frozen to 4kB on machine init done. Now this works. However the new default will prevent 4kB guest on 64kB host because the granule will be set to 64kB which would be larger than the guest page size. In that situation, the virtio-iommu driver fails onviommu_domain_finalise()with
"granule0x10000larger than system page size0x1000".The current limitation of global granule in the virtio-iommu should be removed and turned into per domain granule. But until we get this upgraded, this new default is probably better because I don't think anyone is currently interested in running a 4kB page size guest with virtio-iommu on a 64kB host. However supporting 64kB guest on 64kB host with virtio-iommu and VFIO looks a more important feature.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Eric Auger <[email protected]>Reviewed-by Jean-Philippe Brucker <[email protected]>What about migration compatibility? In particular, cross-version one? Don't we need compat machinery for this?
See below
Quoted 19 lines
Quoted 19 lines
---
v1 -> v2:
- fixed 2 typos in the commit msg and added Jean's R-b and T-b--- hw/virtio/virtio-iommu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)hw/virtio/virtio-iommu.c +1
-1@@ -1313,7 +1313,7 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp)* in vfio realize */ s->config.bypass = s->boot_bypass; - s->config.page_size_mask =qemu_target_page_mask (); + s->config.page_size_mask =qemu_real_host_page_mask (); s->config.input_range.end =UINT64_MAX ;Quoted 8 lines
hw/virtio/virtio-iommu.c static int iommu_post_load(void *opaque, int version_id) · line 1495
Quoted 8 lines
hw/virtio/virtio-iommu.c +2
-0s->config.domain_range.end =UINT32_MAX ; s->config.probe_size =VIOMMU_PROBE_SIZE ;@@ -1491,13 +1491,16 @@ static int iommu_post_load(void *opaque, int version_id)* still correct. */ virtio_iommu_switch_address_space_all (s); +if (version_id <=2 ) { + s->config.page_size_mask =qemu_target_page_mask ();I tested migration from v2 -> v3 and the above code is overriding the new default by the older one.
Quoted 19 lines
Do you have an other concern?
Thanks
Eric
Quoted 12 lines
Quoted 12 lines
hw/virtio/virtio-iommu.c +2
-1+ }return 0 ; }static const VMStateDescription vmstate_virtio_iommu_device = { .name ="virtio-iommu-device" , .minimum_version_id =2 , - .version_id =2 , + .version_id =3 , .post_load = iommu_post_load, .fields = (const VMStateField []) { VMSTATE_GTREE_DIRECT_KEY_V(domains, VirtIOIOMMU, 2,
Quoted 3 lines
Oh I missed the version change. But then migration to older version is completely broken isn't it? Old qemu can not handle
version_id3 at all.
Indeed, I considered migrating backyard was not that much important. Do you consider this is mandated?
Eric
Quoted 7 lines
Generally, compat machinery is nicer than the old version hacks.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Signature · 1 line
2.41.0
Quoted 93 lines · Eric Auger
Quoted 90 lines · Michael S. Tsirkin
Quoted 89 lines · Eric Auger
Hi Michael,
Quoted 31 lines · Michael S. Tsirkin
Quoted 30 lines · Eric Auger
We used to set default
page_size_masktoqemu_target_page_mask()but with VFIO assignment it makes more sense to use the actual host page mask instead.So from now on
qemu_real_host_page_mask()will be used as a default. To be able to migrate older code, we increase the vmstatversion_idto 3 and if an older incoming v2 stream is detected we set the previous default value.The new default is well adapted to configs where host and guest have the same page size. This allows to fix hotplugging VFIO devices on a 64kB guest and a 64kB host. This test case has been failing before and even crashing qemu with
hw_error("vfio: DMA mapping failed, unable to continue")in VFIO common). Indeed the hot-attached VFIO device would callmemory_region_iommu_set_page_size_maskwith 64kB mask whereas after the granule was frozen to 4kB on machine init done. Now this works. However the new default will prevent 4kB guest on 64kB host because the granule will be set to 64kB which would be larger than the guest page size. In that situation, the virtio-iommu driver fails onviommu_domain_finalise()with
"granule0x10000larger than system page size0x1000".The current limitation of global granule in the virtio-iommu should be removed and turned into per domain granule. But until we get this upgraded, this new default is probably better because I don't think anyone is currently interested in running a 4kB page size guest with virtio-iommu on a 64kB host. However supporting 64kB guest on 64kB host with virtio-iommu and VFIO looks a more important feature.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Eric Auger <[email protected]>Reviewed-by Jean-Philippe Brucker <[email protected]>What about migration compatibility? In particular, cross-version one? Don't we need compat machinery for this?
See below
Quoted 19 lines
Quoted 19 lines
---
v1 -> v2:
- fixed 2 typos in the commit msg and added Jean's R-b and T-b--- hw/virtio/virtio-iommu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)hw/virtio/virtio-iommu.c +1
-1@@ -1313,7 +1313,7 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp)* in vfio realize */ s->config.bypass = s->boot_bypass; - s->config.page_size_mask =qemu_target_page_mask (); + s->config.page_size_mask =qemu_real_host_page_mask (); s->config.input_range.end =UINT64_MAX ;Quoted 8 lines
hw/virtio/virtio-iommu.c static int iommu_post_load(void *opaque, int version_id) · line 1495
Quoted 8 lines
hw/virtio/virtio-iommu.c +2
-0s->config.domain_range.end =UINT32_MAX ; s->config.probe_size =VIOMMU_PROBE_SIZE ;@@ -1491,13 +1491,16 @@ static int iommu_post_load(void *opaque, int version_id)* still correct. */ virtio_iommu_switch_address_space_all (s); +if (version_id <=2 ) { + s->config.page_size_mask =qemu_target_page_mask ();I tested migration from v2 -> v3 and the above code is overriding the new default by the older one.
Do you have an other concern?
Thanks
Eric
Quoted 12 lines
Quoted 12 lines
hw/virtio/virtio-iommu.c +2
-1+ }return 0 ; }static const VMStateDescription vmstate_virtio_iommu_device = { .name ="virtio-iommu-device" , .minimum_version_id =2 , - .version_id =2 , + .version_id =3 , .post_load = iommu_post_load, .fields = (const VMStateField []) { VMSTATE_GTREE_DIRECT_KEY_V(domains, VirtIOIOMMU, 2,
Quoted 7 lines
Quoted 3 lines
Oh I missed the version change. But then migration to older version is completely broken isn't it? Old qemu can not handle
version_id3 at all.Indeed, I considered migrating backyard was not that much important. Do you consider this is mandated?
Eric
Generally yes. We only ship downstream but e.g. any RHEL major version migrates to same major version in any direction as people have clusters mixing different versions. It's easier to maintain that guarantee upstream than break it upstream and try to fix it downstream.
Quoted 7 lines
Quoted 7 lines
Generally, compat machinery is nicer than the old version hacks.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Signature · 1 line
2.41.0
Quoted 95 lines · Michael S. Tsirkin
Quoted 94 lines · Eric Auger
Quoted 92 lines · Michael S. Tsirkin
Quoted 70 lines · Eric Auger
Hi Michael,
Quoted 31 lines · Michael S. Tsirkin
Quoted 30 lines · Eric Auger
We used to set default
page_size_masktoqemu_target_page_mask()but with VFIO assignment it makes more sense to use the actual host page mask instead.So from now on
qemu_real_host_page_mask()will be used as a default. To be able to migrate older code, we increase the vmstatversion_idto 3 and if an older incoming v2 stream is detected we set the previous default value.The new default is well adapted to configs where host and guest have the same page size. This allows to fix hotplugging VFIO devices on a 64kB guest and a 64kB host. This test case has been failing before and even crashing qemu with
hw_error("vfio: DMA mapping failed, unable to continue")in VFIO common). Indeed the hot-attached VFIO device would callmemory_region_iommu_set_page_size_maskwith 64kB mask whereas after the granule was frozen to 4kB on machine init done. Now this works. However the new default will prevent 4kB guest on 64kB host because the granule will be set to 64kB which would be larger than the guest page size. In that situation, the virtio-iommu driver fails onviommu_domain_finalise()with
"granule0x10000larger than system page size0x1000".The current limitation of global granule in the virtio-iommu should be removed and turned into per domain granule. But until we get this upgraded, this new default is probably better because I don't think anyone is currently interested in running a 4kB page size guest with virtio-iommu on a 64kB host. However supporting 64kB guest on 64kB host with virtio-iommu and VFIO looks a more important feature.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Eric Auger <[email protected]>Reviewed-by Jean-Philippe Brucker <[email protected]>What about migration compatibility? In particular, cross-version one? Don't we need compat machinery for this?
See below
Quoted 19 lines
Quoted 19 lines
---
v1 -> v2:
- fixed 2 typos in the commit msg and added Jean's R-b and T-b--- hw/virtio/virtio-iommu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)hw/virtio/virtio-iommu.c +1
-1@@ -1313,7 +1313,7 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp)* in vfio realize */ s->config.bypass = s->boot_bypass; - s->config.page_size_mask =qemu_target_page_mask (); + s->config.page_size_mask =qemu_real_host_page_mask (); s->config.input_range.end =UINT64_MAX ;Quoted 8 lines
hw/virtio/virtio-iommu.c static int iommu_post_load(void *opaque, int version_id) · line 1495
Quoted 8 lines
hw/virtio/virtio-iommu.c +2
-0s->config.domain_range.end =UINT32_MAX ; s->config.probe_size =VIOMMU_PROBE_SIZE ;@@ -1491,13 +1491,16 @@ static int iommu_post_load(void *opaque, int version_id)* still correct. */ virtio_iommu_switch_address_space_all (s); +if (version_id <=2 ) { + s->config.page_size_mask =qemu_target_page_mask ();I tested migration from v2 -> v3 and the above code is overriding the new default by the older one.
Quoted 18 lines
Do you have an other concern?
Thanks
Eric
Quoted 12 lines
Quoted 12 lines
hw/virtio/virtio-iommu.c +2
-1+ }return 0 ; }static const VMStateDescription vmstate_virtio_iommu_device = { .name ="virtio-iommu-device" , .minimum_version_id =2 , - .version_id =2 , + .version_id =3 , .post_load = iommu_post_load, .fields = (const VMStateField []) { VMSTATE_GTREE_DIRECT_KEY_V(domains, VirtIOIOMMU, 2,Oh I missed the version change. But then migration to older version is completely broken isn't it? Old qemu can not handle
version_id3 at all.
Quoted 8 lines
Quoted 4 lines
Indeed, I considered migrating backyard was not that much important. Do you consider this is mandated?
Eric
Generally yes. We only ship downstream but e.g. any RHEL major version migrates to same major version in any direction as people have clusters mixing different versions. It's easier to maintain that guarantee upstream than break it upstream and try to fix it downstream.
OK then I will revisit the implementation
thanks
Eric
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Generally, compat machinery is nicer than the old version hacks.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Signature · 1 line
2.41.0
Quoted 1 line · Eric Auger
Do you have an other concern?
I also worry a bit about migrating between hosts with different page sizes. Not with kvm I am guessing but with tcg it does work I think? Is this just for vfio and vdpa? Can we limit this to these setups maybe?
Signature · 1 line
MST
Hi Michael,
Quoted 4 lines · Michael S. Tsirkin
Quoted 1 line · Eric Auger
Do you have an other concern?
I also worry a bit about migrating between hosts with different page sizes. Not with kvm I am guessing but with tcg it does work I think?
I have never tried but is it a valid use case? Adding Peter in CC.
Quoted 2 lines
Is this just for vfio and vdpa? Can we limit this to these setups maybe?
I am afraid we know the actual use case too later. If the VFIO device is hotplugged we have started working with 4kB granule.
The other way is to introduce a min_granule option as done for aw-bits. But it is heavier.
Thanks
Eric
Quoted 1 line
Quoted 12 lines · Eric Auger
Hi Michael,
Quoted 4 lines · Michael S. Tsirkin
Quoted 1 line · Eric Auger
Do you have an other concern?
I also worry a bit about migrating between hosts with different page sizes. Not with kvm I am guessing but with tcg it does work I think?
I have never tried but is it a valid use case? Adding Peter in CC.
Quoted 2 lines
Is this just for vfio and vdpa? Can we limit this to these setups maybe?
I am afraid we know the actual use case too later. If the VFIO device is hotplugged we have started working with 4kB granule.
Quoted 7 lines
The other way is to introduce a
min_granuleoption as done for aw-bits. But it is heavier.Thanks
Eric
Quoted 1 line
Let's say, if you are changing the default then we definitely want a way to get the cmpatible behaviour for tcg.
So the compat machinery should be user-accessible too and documented.
Signature · 1 line
MST
Hi,
Quoted 16 lines · Michael S. Tsirkin
Quoted 15 lines · Eric Auger
Hi Michael,
Quoted 4 lines · Michael S. Tsirkin
Quoted 1 line · Eric Auger
Do you have an other concern?
I also worry a bit about migrating between hosts with different page sizes. Not with kvm I am guessing but with tcg it does work I think?
I have never tried but is it a valid use case? Adding Peter in CC.
Quoted 2 lines
Is this just for vfio and vdpa? Can we limit this to these setups maybe?
I am afraid we know the actual use case too later. If the VFIO device is hotplugged we have started working with 4kB granule.
The other way is to introduce a
min_granuleoption as done for aw-bits. But it is heavier.
Quoted 6 lines
Quoted 3 lines
Thanks
Eric
Let's say, if you are changing the default then we definitely want a way to get the cmpatible behaviour for tcg.
So the compat machinery should be user-accessible too and documented.
I guess I need to add a new option to guarantee the machine compat.
I was thinking about an enum GranuleMode property taking the following values, 4KB, 64KB, host
Jean, do you think there is a rationale offering something richer?
Obviously being able to set the exact page_size_mask + host mode would be better but this does not really fit into any std property type.
Thanks
Eric
Quoted 1 line
Quoted 26 lines · Eric Auger
Hi,
Quoted 16 lines · Michael S. Tsirkin
Quoted 15 lines · Eric Auger
Hi Michael,
Quoted 4 lines · Michael S. Tsirkin
Quoted 1 line · Eric Auger
Do you have an other concern?
I also worry a bit about migrating between hosts with different page sizes. Not with kvm I am guessing but with tcg it does work I think?
I have never tried but is it a valid use case? Adding Peter in CC.
Quoted 2 lines
Is this just for vfio and vdpa? Can we limit this to these setups maybe?
I am afraid we know the actual use case too later. If the VFIO device is hotplugged we have started working with 4kB granule.
The other way is to introduce a
min_granuleoption as done for aw-bits. But it is heavier.Quoted 6 lines
Quoted 3 lines
Thanks
Eric
Let's say, if you are changing the default then we definitely want a way to get the cmpatible behaviour for tcg.
So the compat machinery should be user-accessible too and documented.
Quoted 5 lines
I guess I need to add a new option to guarantee the machine compat.
I was thinking about an enum GranuleMode property taking the following values, 4KB, 64KB, host
Jean, do you think there is a rationale offering something richer?
16KB seems to be gaining popularity, we should include that (I think it's the only granule supported by Apple IOMMU?). Hopefully that will be enough.
Thanks,
Jean
Quoted 9 lines
Obviously being able to set the exact
page_size_mask+ host mode would be better but this does not really fit into any std property type.Thanks
Eric
Quoted 1 line
Quoted 26 lines · Jean-Philippe Brucker
Quoted 25 lines · Eric Auger
Hi,
Quoted 22 lines · Michael S. Tsirkin
Quoted 12 lines · Eric Auger
Hi Michael,
Quoted 4 lines · Michael S. Tsirkin
Quoted 1 line · Eric Auger
Do you have an other concern?
I also worry a bit about migrating between hosts with different page sizes. Not with kvm I am guessing but with tcg it does work I think?
I have never tried but is it a valid use case? Adding Peter in CC.
Quoted 2 lines
Is this just for vfio and vdpa? Can we limit this to these setups maybe?
I am afraid we know the actual use case too later. If the VFIO device is hotplugged we have started working with 4kB granule.
Quoted 6 lines
The other way is to introduce a
min_granuleoption as done for aw-bits. But it is heavier.Thanks
Eric
Let's say, if you are changing the default then we definitely want a way to get the cmpatible behaviour for tcg.
So the compat machinery should be user-accessible too and documented.
Quoted 8 lines
Quoted 5 lines
I guess I need to add a new option to guarantee the machine compat.
I was thinking about an enum GranuleMode property taking the following values, 4KB, 64KB, host
Jean, do you think there is a rationale offering something richer?16KB seems to be gaining popularity, we should include that (I think it's the only granule supported by Apple IOMMU?). Hopefully that will be enough.
thank you for your prompt reply. I do agree.
nevertheless I am going to prototype passing the whole page size mask I think. That could be useful to test some weird configs
Thanks
Eric
Quoted 10 lines
Thanks,
JeanQuoted 6 lines
Obviously being able to set the exact
page_size_mask+ host mode would be better but this does not really fit into any std property type.Thanks
Eric