Skip to contentSkip to conversation

comedi: ni_mio_common: remove redundant assignment to variable status1

PATCH New Colin Ian King 1 participant 1 message Jan 18, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 comedi: ni_mio_common: remove redundant assignment to variable status1

The variable status1 is being assigned a value that is never read, the assignment is redundant and can be removed.

Cleans up clang scan build warning:
warning: Although the value stored to 'status1' is used in the enclosing expression, the value is never actually read from 'status1' [deadcode.DeadStores]

---
 drivers/comedi/drivers/ni_mio_common.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/comedi/drivers/ni_mio_common.c +1 -2
index 980f309d6de7..824b026238b5 100644
@@ -3798,8 +3798,7 @@ static int ni_serial_hw_readwrite8(struct comedi_device *dev,
 	devpriv->dio_control &= ~NISTC_DIO_CTRL_HW_SER_START;
 
 	/* Wait until STC says we're done, but don't loop infinitely. */
-	while ((status1 = ni_stc_readw(dev, NISTC_STATUS1_REG)) &
-	       NISTC_STATUS1_SERIO_IN_PROG) {
+	while (ni_stc_readw(dev, NISTC_STATUS1_REG) & NISTC_STATUS1_SERIO_IN_PROG) {
 		/* Delay one bit per loop */
 		udelay((devpriv->serial_interval_ns + 999) / 1000);
 		if (--count < 0) {
Signature · 1 line
2.39.2