Skip to contentSkip to conversation

imx8m: Enable LTO by default

PATCH In review Fabio Estevam 2 participants 6 messages Jan 18, 2024 – Jan 22, 2024

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 imx8m: Enable LTO by default

From: Fabio Estevam <[email protected]>

In an attempt to select ARMV8_SPL_EXCEPTION_VECTORS, the SPL size could not fit into the internal SRAM of some imx8m targets:

aarch64: + imx8mm_phg
+aarch64-linux-ld.bfd: u-boot-spl section __u_boot_list' will not fit in region .sram' +aarch64-linux-ld.bfd: region `.sram' overflowed by 1824 bytes

Select LTO to prevent that.

---
 arch/arm/mach-imx/imx8m/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/imx8m/Kconfig +1 -0
index b1937198402f..328c3e388051 100644
@@ -5,6 +5,7 @@ config IMX8M
 	select BINMAN
 	select GICV3 if ARMV8_PSCI
 	select HAS_CAAM
+	select LTO
 	select ROM_UNIFIED_SECTIONS
 	select ARMV8_CRYPTO
 
Signature · 1 line
2.34.1
author reviewer
#1 lore raw

PATCH 2/2 arm: imx: imx8m: Enable the SError exception

From: Ye Li <[email protected]>

To work with commit 2f3c92060dcd ("imx8m: workaround ROM serror") we need to enable the SError exception and install vector in SPL.

---
 arch/arm/mach-imx/imx8m/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/imx8m/Kconfig +3 -0
index 328c3e388051..eb0488a9e8bf 100644
@@ -13,14 +13,17 @@ config IMX8MQ
 	bool
 	select IMX8M
 	select CLK_IMX8MQ
+	select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MM
 	bool
 	select IMX8M
+	select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MN
 	bool
 	select IMX8M
+	select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MP
 	bool
Signature · 1 line
2.34.1
Reviewed-by on v1 1/2
#4 lore raw
In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

In an attempt to select ARMV8_SPL_EXCEPTION_VECTORS, the SPL size could not fit into the internal SRAM of some imx8m targets:

aarch64: + imx8mm_phg

(quoted diff) +2 -0
+aarch64-linux-ld.bfd: u-boot-spl section `__u_boot_list' will not fit in region `.sram'
+aarch64-linux-ld.bfd: region `.sram' overflowed by 1824 bytes
Quoted 3 lines

Select LTO to prevent that.

I wouldn't mind seeing LTO enabled for all of ARM64 eventually, but that's for another patch.

#2 lore raw

Re: [PATCH 2/2] arm: imx: imx8m: Enable the SError exception

In reply to Fabio Estevam
Quoted 4 lines · Fabio Estevam

From: Ye Li <[email protected]>

To work with commit 2f3c92060dcd ("imx8m: workaround ROM serror") we need to enable the SError exception and install vector in SPL.

This really does need better commit message, sorry.

Details, please.

What does trigger the SError ?

author reviewer
#3 lore raw

Re: [PATCH 2/2] arm: imx: imx8m: Enable the SError exception

Quoted 4 lines · Marek Vasut
Quoted 2 lines · Fabio Estevam

From: Ye Li <[email protected]>

Quoted 8 lines
Quoted 2 lines

To work with commit 2f3c92060dcd ("imx8m: workaround ROM serror") we need to enable the SError exception and install vector in SPL.

This really does need better commit message, sorry.

Details, please.

What does trigger the SError ?

Ye Li, please improve the commit message and send a v2.

Thanks

author reviewer
#5 lore raw
In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

In an attempt to select ARMV8_SPL_EXCEPTION_VECTORS, the SPL size could not fit into the internal SRAM of some imx8m targets:

aarch64: + imx8mm_phg

(quoted diff) +2 -0
+aarch64-linux-ld.bfd: u-boot-spl section `__u_boot_list' will not fit in region `.sram'
+aarch64-linux-ld.bfd: region `.sram' overflowed by 1824 bytes
Quoted 3 lines

Select LTO to prevent that.

Applied only this one, thanks.