staging: rts5208: Add more details to Kconfig help
PATCH 1/1 staging: rts5208: Add more details to Kconfig help
The current help text is short and triggers a
warning from checkpatch.pl. This patch adds more details to the help text which should provide better information for whether or not to enable the driver.
--- drivers/staging/rts5208/Kconfig | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/staging/rts5208/Kconfig +7 -3
@@ -3,7 +3,11 @@ config RTS5208 tristate "Realtek PCI-E Card Reader RTS5208/5288 support" depends on PCI && SCSI help - Say Y here to include driver code to support the Realtek - PCI-E card reader rts5208/rts5288. + Choose Y here to enable support for the Realtek PCI-E card reader RTS5208/5288. + This driver facilitates communication between the Linux kernel and the Realtek + PCI-E card reader. - If this driver is compiled as a module, it will be named rts5208. + If you opt to compile this driver as a module, it will be named rts5208. Selecting + N will exclude this driver from the kernel build. Choose option Y if your system includes + the Realtek PCI-E card reader rts5208/rts5288. When in doubt, it is generally safe + to select N.
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 4 lines · Jacob Lott
The current help text is short and triggers a
warning from checkpatch.pl. This patch adds more details to the help text which should provide better information for whether or not to enable the driver.
Please wrap your lines at 72 columns.
Quoted 10 lines
Signed-off-by Jacob Lott <[email protected]>--- drivers/staging/rts5208/Kconfig | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)drivers/staging/rts5208/Kconfig +0
-0
drivers/staging/rts5208/Kconfig config RTS5208 · line 6
Quoted 6 lines
drivers/staging/rts5208/Kconfig +1
-2@@ -3,7 +3,11 @@ config RTS5208 tristate "Realtek PCI-E Card Reader RTS5208/5288 support" depends on PCI && SCSI help - Say Y here to include driver code to support the Realtek - PCI-E card reader rts5208/rts5288. + Choose Y here to enable support for the Realtek PCI-E card reader RTS5208/5288.
No tab? Didn't checkpatch complain about this when you ran it on this patch?
drivers/staging/rts5208/Kconfig config RTS5208 · line 13
Quoted 8 lines
drivers/staging/rts5208/Kconfig +6
-1+ This driver facilitates communication between the Linux kernel and the Realtek + PCI-E card reader. - If this driver is compiled as a module, it will be named rts5208. + If you opt to compile this driver as a module, it will be named rts5208. Selecting + N will exclude this driver from the kernel build. Choose option Y if your system includes + the Realtek PCI-E card reader rts5208/rts5288. When in doubt, it is generally safe + to select N.
Wrap your lines properly here at 80 columns.
thanks,
greg k-h
Quoted 36 lines · Greg KH
Quoted 4 lines · Jacob Lott
The current help text is short and triggers a
warning from checkpatch.pl. This patch adds more details to the help text which should provide better information for whether or not to enable the driver.Please wrap your lines at 72 columns.
Quoted 10 lines
Signed-off-by Jacob Lott <[email protected]>--- drivers/staging/rts5208/Kconfig | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)drivers/staging/rts5208/Kconfig +0
-0drivers/staging/rts5208/Kconfig config RTS5208 · line 6
Quoted 6 lines
drivers/staging/rts5208/Kconfig +1
-2@@ -3,7 +3,11 @@ config RTS5208 tristate "Realtek PCI-E Card Reader RTS5208/5288 support" depends on PCI && SCSI help - Say Y here to include driver code to support the Realtek - PCI-E card reader rts5208/rts5288. + Choose Y here to enable support for the Realtek PCI-E card reader RTS5208/5288.No tab? Didn't checkpatch complain about this when you ran it on this patch?
drivers/staging/rts5208/Kconfig config RTS5208 · line 13
Quoted 8 lines
drivers/staging/rts5208/Kconfig +6
-1+ This driver facilitates communication between the Linux kernel and the Realtek + PCI-E card reader. - If this driver is compiled as a module, it will be named rts5208. + If you opt to compile this driver as a module, it will be named rts5208. Selecting + N will exclude this driver from the kernel build. Choose option Y if your system includes + the Realtek PCI-E card reader rts5208/rts5288. When in doubt, it is generally safe + to select N.Wrap your lines properly here at 80 columns.
Quoted 3 lines
thanks,
greg k-h
Checkpatch is not pointing out any issues when I run it:
./scripts/checkpatch.pl /tmp/0001-staging-rts5208-Add-more-details-to-Kconfig-help.pat ch
total: 0 errors, 0 warnings, 0 checks, 14 lines checked
/tmp/0001-staging-rts5208-Add-more-details-to-Kconfig-help.patch has no obvious style problems and is ready for submission.
Does this indicate I need to set a configuration specifically for the checkpatch?
Greg KH
maintainerQuoted 34 lines · Jacob Lott
The current help text is short and triggers a
warning from checkpatch.pl. This patch adds more details to the help text which should provide better information for whether or not to enable the driver.Signed-off-by Jacob Lott <[email protected]>--- drivers/staging/rts5208/Kconfig | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)drivers/staging/rts5208/Kconfig +7
-3@@ -3,7 +3,11 @@ config RTS5208 tristate "Realtek PCI-E Card Reader RTS5208/5288 support" depends on PCI && SCSI help - Say Y here to include driver code to support the Realtek - PCI-E card reader rts5208/rts5288. + Choose Y here to enable support for the Realtek PCI-E card reader RTS5208/5288. + This driver facilitates communication between the Linux kernel and the Realtek + PCI-E card reader. - If this driver is compiled as a module, it will be named rts5208. + If you opt to compile this driver as a module, it will be named rts5208. Selecting + N will exclude this driver from the kernel build. Choose option Y if your system includes + the Realtek PCI-E card reader rts5208/rts5288. When in doubt, it is generally safe + to select N.Signature · 1 line
2.34.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot