Skip to contentSkip to conversation

smb: Fix some kernel-doc comments

PATCH Applied Yang Li 2 participants 2 messages Jan 19, 2024 – Jan 20, 2024

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 smb: Fix some kernel-doc comments

Fix some kernel-doc comments to silence the warnings:
fs/smb/server/transport_tcp.c:374: warning: Function parameter or struct member 'max_retries' not described in 'ksmbd_tcp_read' fs/smb/server/transport_tcp.c:423: warning: Function parameter or struct member 'iface' not described in 'create_socket'

---
 fs/smb/server/transport_tcp.c | 2 ++
 1 file changed, 2 insertions(+)
fs/smb/server/transport_tcp.c +2 -0
index 9d4222154dcc..002a3f0dc7c5 100644
@@ -365,6 +365,7 @@ static int ksmbd_tcp_readv(struct tcp_transport *t, struct kvec *iov_orig,
  * @t:		TCP transport instance
  * @buf:	buffer to store read data from socket
  * @to_read:	number of bytes to read from socket
+ * @max_retries: number of retries if reading from socket fails
  *
  * Return:	on success return number of bytes read from socket,
  *		otherwise return error number
@@ -416,6 +417,7 @@ static void tcp_destroy_socket(struct socket *ksmbd_socket)
 
 /**
  * create_socket - create socket for ksmbd/0
+ * @iface:      interface to bind the created socket to
  *
  * Return:	0 on success, error number otherwise
  */
Signature · 1 line
2.20.1.7.g153144c
maintainer Acked-by on v1 1/1 Applied
#1 lore raw

2024-01-19 18:57 GMT+09:00, Yang Li <[email protected]>:

Quoted 7 lines

Fix some kernel-doc comments to silence the warnings:
fs/smb/server/transport_tcp.c:374: warning: Function parameter or struct member 'max_retries' not described in 'ksmbd_tcp_read' fs/smb/server/transport_tcp.c:423: warning: Function parameter or struct member 'iface' not described in 'create_socket'

Applied it to #ksmbd-for-next-next. Thanks for your patch.