MIPS: Alchemy: Use kcalloc() instead of kzalloc()
PATCH 1/1 MIPS: Alchemy: Use kcalloc() instead of kzalloc()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function.
--- arch/mips/alchemy/common/clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/alchemy/common/clock.c +1 -1
@@ -771,7 +771,7 @@ static int __init alchemy_clk_init_fgens(int ctype) } id.flags =CLK_SET_RATE_PARENT |CLK_GET_RATE_NOCACHE ; - a =kzalloc ((sizeof (*a)) *6 ,GFP_KERNEL ); + a =kcalloc (6 ,sizeof (*a),GFP_KERNEL );if (!a)return -ENOMEM ;
--
2.25.1
Quoted 8 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
Quoted 6 lines
So, use the purpose specific
kcalloc()function instead of the argument size * count in thekzalloc()function.
Thanks!
Signature · 1 line
Gustavo
Quoted 21 lines
--- arch/mips/alchemy/common/clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/mips/alchemy/common/clock.c +1
-2@@ -771,7 +771,7 @@ static int __init alchemy_clk_init_fgens(int ctype) } id.flags =CLK_SET_RATE_PARENT |CLK_GET_RATE_NOCACHE ; - a =kzalloc ((sizeof (*a)) *6 ,GFP_KERNEL ); + a =kcalloc (6 ,sizeof (*a),GFP_KERNEL );if (!a)return -ENOMEM ; --2.25.1
Quoted 32 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific
kcalloc()function instead of the argument size * count in thekzalloc()function.Signed-off-by Erick Archer <[email protected]>--- arch/mips/alchemy/common/clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/mips/alchemy/common/clock.c +1
-2@@ -771,7 +771,7 @@ static int __init alchemy_clk_init_fgens(int ctype) } id.flags =CLK_SET_RATE_PARENT |CLK_GET_RATE_NOCACHE ; - a =kzalloc ((sizeof (*a)) *6 ,GFP_KERNEL ); + a =kcalloc (6 ,sizeof (*a),GFP_KERNEL );if (!a)return -ENOMEM ; --
Quoted 1 line
2.25.1
applied to mips-next.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]