Skip to contentSkip to conversation

osdep/hurd/getroot: Fix 64bit build

PATCH Superseded Samuel Thibault 4 participants 5 messages Jan 20, 2024 – Jan 23, 2024

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 osdep/hurd/getroot: Fix 64bit build

file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t (64bit on 64bit platforms).

---
 grub-core/osdep/hurd/getroot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/osdep/hurd/getroot.c +1 -1
index 0efefdab4..b849700e6 100644
@@ -58,7 +58,7 @@ grub_util_find_hurd_root_device (const char *path)
   file_t file;
   error_t err;
   char *argz = NULL, *name = NULL, *ret;
-  size_t argz_len = 0;
+  mach_msg_type_number_t argz_len = 0;
   int i;
 
   file = file_name_lookup (path, 0, 0);
Signature · 7 lines
2.43.0


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#1 lore raw

Samuel Thibault, le sam. 20 janv. 2024 19:35:13 +0100, a ecrit:

Quoted 2 lines

file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t (64bit on 64bit platforms).

Quoted 20 lines
---
 grub-core/osdep/hurd/getroot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/osdep/hurd/getroot.c +1 -1
index 0efefdab4..b849700e6 100644
@@ -58,7 +58,7 @@ grub_util_find_hurd_root_device (const char *path)
   file_t file;
   error_t err;
   char *argz = NULL, *name = NULL, *ret;
-  size_t argz_len = 0;
+  mach_msg_type_number_t argz_len = 0;
   int i;
 
   file = file_name_lookup (path, 0, 0);
Signature · 1 line
2.43.0

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

#2 lore raw
In reply to Samuel Thibault
Quoted 2 lines · Samuel Thibault

file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t (64bit on 64bit platforms).

Nitpick: I think it should be "32 bit", "64 bit" and "64-bit", the former two referring two a word size while the latter refers to the target type.

Adrian

Signature · 9 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
Reviewed-by on v1 1/1
#3 lore raw
In reply to Samuel Thibault

LGTM

Quoted 24 lines · Samuel Thibault

file_get_fs_options takes a mach_msg_type_number_t (32bit), not a size_t (64bit on 64bit platforms).

---
 grub-core/osdep/hurd/getroot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/osdep/hurd/getroot.c +1 -2
index 0efefdab4..b849700e6 100644
@@ -58,7 +58,7 @@ grub_util_find_hurd_root_device (const char *path)
   file_t file;
   error_t err;
   char *argz = NULL, *name = NULL, *ret;
-  size_t argz_len = 0;
+  mach_msg_type_number_t argz_len = 0;
   int i;
 
   file = file_name_lookup (path, 0, 0);
--

2.43.0

Quoted 5 lines

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel