Skip to contentSkip to conversation

Revert "lzop: remove recipe from oe-core"

PATCH New Marek Vasut 1 participant 1 message Jan 20, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Revert "lzop: remove recipe from oe-core"

This reverts commit dea5e8863792dc7bb3324b543e04da4c94a060aa.

The original commit claims that lzop is unused in OE-core.
That is not correct, the following places still use it and
became unbuildable now:
"
meta/classes-recipe/image_types.bbclass:CONVERSION_CMD:lzo = "lzop -9 ${IMAGE_NAME}.${type}" meta/classes-recipe/image_types.bbclass:CONVERSION_DEPENDS_lzo = "lzop-native"
meta/classes-recipe/kernel-uboot.bbclass: lzop -9 linux.bin
meta/classes-recipe/kernel.bbclass:DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lzo", "lzop-native", "", d)}"
meta/classes-recipe/kernel.bbclass: lzop -df ${B}/usr/${INITRAMFS_IMAGE_NAME}.$img
"

Furthermore, LZO is the best compromise between kernel decompression time and size on low end ARM systems, that is why it is often used with e.g.:
FIT_KERNEL_COMP_ALG = "lzo"
FIT_KERNEL_COMP_ALG_EXTENSION = ".lzo"

Reinstate the package to avoid breaking this use case.

---
Cc: Martin Jansa <[email protected]>
Cc: Ross Burton <[email protected]>
Cc: Richard Purdie <[email protected]>
---
V2: Replace Denys in maintainers.inc file for this recipe

---
 meta/conf/distro/include/maintainers.inc    |   1 +
 meta/recipes-support/lzop/lzop/acinclude.m4 | 390 ++++++++++++++++++++
 meta/recipes-support/lzop/lzop_1.04.bb      |  27 ++
 3 files changed, 418 insertions(+)
 create mode 100644 meta/recipes-support/lzop/lzop/acinclude.m4
 create mode 100644 meta/recipes-support/lzop/lzop_1.04.bb
meta/conf/distro/include/maintainers.inc +1 -0
index 31023021ac..735e1c2230 100644
@@ -485,6 +485,7 @@ RECIPE_MAINTAINER:pn-lua = "Alexander Kanavin <[email protected]>"
 RECIPE_MAINTAINER:pn-lz4 = "Denys Dmytriyenko <[email protected]>"
 RECIPE_MAINTAINER:pn-lzo = "Denys Dmytriyenko <[email protected]>"
 RECIPE_MAINTAINER:pn-lzip = "Denys Dmytriyenko <[email protected]>"
+RECIPE_MAINTAINER:pn-lzop = "Marek Vasut <[email protected]>"
 RECIPE_MAINTAINER:pn-m4 = "Robert Yang <[email protected]>"
 RECIPE_MAINTAINER:pn-m4-native = "Robert Yang <[email protected]>"
 RECIPE_MAINTAINER:pn-make = "Robert Yang <[email protected]>"
meta/recipes-support/lzop/lzop/acinclude.m4 new file +390 -0

390 lines not on this page · raw message

meta/recipes-support/lzop/lzop_1.04.bb new file +27 -0
new file mode 100644
index 0000000000..d9b3524b67
@@ -0,0 +1,27 @@
+SUMMARY = "Real-time file compressor"
+DESCRIPTION = "lzop is a compression utility which is designed to be a companion to gzip. \n\
+It is based on the LZO data compression library and its main advantages over \n\
+gzip are much higher compression and decompression speed at the cost of some \n\
+compression ratio. The lzop compression utility was designed with the goals \n\
+of reliability, speed, portability and with reasonable drop-in compatibility \n\
+to gzip."
+HOMEPAGE = "http://www.lzop.org/"
+DEPENDS += "lzo"
+
+LICENSE = "GPL-2.0-or-later"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+                    file://src/lzop.c;beginline=5;endline=21;md5=23d767de7754eb24b9e900b025cf7fc8"
+
+SRC_URI = "http://www.lzop.org/download/${BP}.tar.gz \
+           file://acinclude.m4 \
+          "
+SRC_URI[md5sum] = "271eb10fde77a0a96b9cbf745e719ddf"
+SRC_URI[sha256sum] = "7e72b62a8a60aff5200a047eea0773a8fb205caf7acbe1774d95147f305a2f41"
+
+inherit autotools
+
+do_configure:prepend () {
+    install -Dm 0644 ${WORKDIR}/acinclude.m4 ${S}/acinclude.m4
+}
+
+BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.43.0