Skip to contentSkip to conversation

sunxi: R528: add UART1 support

PATCH In review Maksim Kiselev 2 participants 3 messages Jan 21, 2024 – Jan 27, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: R528: add UART1 support

Add PG6-PG7 pins configuration for the SPL to allow use UART1 on boards with the Allwinner R528/T113 family.

---

I tested this patch on LC-PI-T113 board.
This board can be found on eBay or Aliexpress, and looks like that it is widespread enough to send this patch to the upstream :)

 arch/arm/mach-sunxi/board.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/mach-sunxi/board.c +4 -0
index 11a4941822..9dedcd45f5 100644
@@ -159,6 +159,10 @@ static int gpio_init(void)
 	sunxi_gpio_set_cfgpin(SUNXI_GPG(3), SUN5I_GPG_UART1);
 	sunxi_gpio_set_cfgpin(SUNXI_GPG(4), SUN5I_GPG_UART1);
 	sunxi_gpio_set_pull(SUNXI_GPG(4), SUNXI_GPIO_PULL_UP);
+#elif CONFIG_CONS_INDEX == 2 && defined(CONFIG_MACH_SUN8I_R528)
+	sunxi_gpio_set_cfgpin(SUNXI_GPG(6), 2);
+	sunxi_gpio_set_cfgpin(SUNXI_GPG(7), 2);
+	sunxi_gpio_set_pull(SUNXI_GPG(7), SUNXI_GPIO_PULL_UP);
 #elif CONFIG_CONS_INDEX == 3 && defined(CONFIG_MACH_SUN8I_H3)
 	sunxi_gpio_set_cfgpin(SUNXI_GPA(0), SUN8I_H3_GPA_UART2);
 	sunxi_gpio_set_cfgpin(SUNXI_GPA(1), SUN8I_H3_GPA_UART2);
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · On Sun, 21 Jan 2024 14:49:08 +0300 Maksim Kiselev <[email protected]> wrote:

Add PG6-PG7 pins configuration for the SPL to allow use UART1 on boards with the Allwinner R528/T113 family.

That looks alright. Not super happy to take yet another combination, but well. Also see below.

Quoted 1 line
Quoted 5 lines

---

I tested this patch on LC-PI-T113 board.
This board can be found on eBay or Aliexpress, and looks like that it is widespread enough to send this patch to the upstream :)

... it would be even better to have a DT and defconfig then, right? Then we would have a user for this code part then. Any chance you could send something to that effect?

Are there any BSP code drops, or a schematic or some other documentation? I couldn't find something on a quick search.

Cheers,
Andre

Quoted 18 lines
 arch/arm/mach-sunxi/board.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/mach-sunxi/board.c +4 -0
index 11a4941822..9dedcd45f5 100644
@@ -159,6 +159,10 @@ static int gpio_init(void)
 	sunxi_gpio_set_cfgpin(SUNXI_GPG(3), SUN5I_GPG_UART1);
 	sunxi_gpio_set_cfgpin(SUNXI_GPG(4), SUN5I_GPG_UART1);
 	sunxi_gpio_set_pull(SUNXI_GPG(4), SUNXI_GPIO_PULL_UP);
+#elif CONFIG_CONS_INDEX == 2 && defined(CONFIG_MACH_SUN8I_R528)
+	sunxi_gpio_set_cfgpin(SUNXI_GPG(6), 2);
+	sunxi_gpio_set_cfgpin(SUNXI_GPG(7), 2);
+	sunxi_gpio_set_pull(SUNXI_GPG(7), SUNXI_GPIO_PULL_UP);
 #elif CONFIG_CONS_INDEX == 3 && defined(CONFIG_MACH_SUN8I_H3)
 	sunxi_gpio_set_cfgpin(SUNXI_GPA(0), SUN8I_H3_GPA_UART2);
 	sunxi_gpio_set_cfgpin(SUNXI_GPA(1), SUN8I_H3_GPA_UART2);
#2 lore raw

пт, 26 янв. 2024 г. в 20:11, Andre Przywara <[email protected]>:

Quoted 16 lines
Quoted 2 lines · On Sun, 21 Jan 2024 14:49:08 +0300 Maksim Kiselev <[email protected]> wrote:

Add PG6-PG7 pins configuration for the SPL to allow use UART1 on boards with the Allwinner R528/T113 family.

That looks alright. Not super happy to take yet another combination, but well. Also see below.

Quoted 1 line
Quoted 2 lines

---

Quoted 7 lines
Quoted 3 lines

I tested this patch on LC-PI-T113 board.
This board can be found on eBay or Aliexpress, and looks like that it is widespread enough to send this patch to the upstream :)

... it would be even better to have a DT and defconfig then, right? Then we would have a user for this code part then. Any chance you could send something to that effect?

Well, I can try to do this.

Quoted 2 lines

Are there any BSP code drops, or a schematic or some other documentation? I couldn't find something on a quick search.

The google drive link
https://drive.google.com/drive/folders/1lrqDsxtGl8WvU7o547lT9IkHwGyAHXFU
is the only “official” documentation that I found.
It contains a board scheme, some datasheets and a useless fw image :)

Quoted 7 lines

Cheers,
Andre

Quoted 3 lines
 arch/arm/mach-sunxi/board.c | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 16 lines
Quoted 5 lines
arch/arm/mach-sunxi/board.c +0 -0
index 11a4941822..9dedcd45f5 100644

arch/arm/mach-sunxi/board.c static int gpio_init(void) · line 168

Quoted 10 lines
arch/arm/mach-sunxi/board.c +4 -0
@@ -159,6 +159,10 @@ static int gpio_init(void)
      sunxi_gpio_set_cfgpin(SUNXI_GPG(3), SUN5I_GPG_UART1);
      sunxi_gpio_set_cfgpin(SUNXI_GPG(4), SUN5I_GPG_UART1);
      sunxi_gpio_set_pull(SUNXI_GPG(4), SUNXI_GPIO_PULL_UP);
+#elif CONFIG_CONS_INDEX == 2 && defined(CONFIG_MACH_SUN8I_R528)
+     sunxi_gpio_set_cfgpin(SUNXI_GPG(6), 2);
+     sunxi_gpio_set_cfgpin(SUNXI_GPG(7), 2);
+     sunxi_gpio_set_pull(SUNXI_GPG(7), SUNXI_GPIO_PULL_UP);
 #elif CONFIG_CONS_INDEX == 3 && defined(CONFIG_MACH_SUN8I_H3)
      sunxi_gpio_set_cfgpin(SUNXI_GPA(0), SUN8I_H3_GPA_UART2);
      sunxi_gpio_set_cfgpin(SUNXI_GPA(1), SUN8I_H3_GPA_UART2);

Best wishes,
Maksim