Skip to contentSkip to conversation

maple_tree: avoid duplicate variable init in mast_spanning_rebalance()

PATCH Applied Lukas Bulwahn 2 participants 2 messages Jan 22, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 maple_tree: avoid duplicate variable init in mast_spanning_rebalance()

The local variables r_tmp and l_tmp in mast_spanning_rebalance() are already initialized at its declaration; there is no need to assign the value again.

Remove the duplicate initialization of {r,l}_tmp. No functional change. Due to common compiler optimizations, also no change to object code.

This issue was identified with clang-analyzer's dead stores analysis.

---
 lib/maple_tree.c | 2 --
 1 file changed, 2 deletions(-)
lib/maple_tree.c +0 -2
index 7b161802860b..82fb5195c235 100644
@@ -2271,8 +2271,6 @@ bool mast_spanning_rebalance(struct maple_subtree_state *mast)
 	struct ma_state l_tmp = *mast->orig_l;
 	unsigned char depth = 0;
 
-	r_tmp = *mast->orig_r;
-	l_tmp = *mast->orig_l;
 	do {
 		mas_ascend(mast->orig_r);
 		mas_ascend(mast->orig_l);
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Lukas Bulwahn

The local variables r_tmp and l_tmp in mast_spanning_rebalance() are already initialized at its declaration; there is no need to assign the value again.

Remove the duplicate initialization of {r,l}_tmp. No functional change. Due to common compiler optimizations, also no change to object code.

Hello!

Thanks for this patch and well stated change log.

Quoted 4 lines

This issue was identified with clang-analyzer's dead stores analysis.

Quoted 20 lines
---
 lib/maple_tree.c | 2 --
 1 file changed, 2 deletions(-)
lib/maple_tree.c +0 -2
index 7b161802860b..82fb5195c235 100644
@@ -2271,8 +2271,6 @@ bool mast_spanning_rebalance(struct maple_subtree_state *mast)
 	struct ma_state l_tmp = *mast->orig_l;
 	unsigned char depth = 0;
 
-	r_tmp = *mast->orig_r;
-	l_tmp = *mast->orig_l;
 	do {
 		mas_ascend(mast->orig_r);
 		mas_ascend(mast->orig_l);
Signature · 1 line
2.17.1