lib/xe: Boost prefetch size to 4KB
PATCH 1/1 lib/xe: Boost prefetch size to 4KB
From: Lucas De Marchi <[email protected]>
For Xe2, the prefetch for RCS is 4KB, so boost it.
BSpec: 60223
--- lib/xe/xe_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/xe/xe_ioctl.c +1 -1
@@ -48,7 +48,7 @@uint32_t xe_cs_prefetch_size (int fd) { -return 2048 ; +return 4096 ; }uint32_t xe_vm_create (int fd,uint32_t flags,uint64_t ext)
Signature · 1 line
2.43.0
Quoted 8 lines · Matthew Auld
From: Lucas De Marchi <[email protected]>
For Xe2, the prefetch for RCS is 4KB, so boost it.
BSpec: 60223
Signed-off-by Lucas De Marchi <[email protected]>Signed-off-by Matthew Auld <[email protected]>Cc Zbigniew Kempczyński <[email protected]>
humn... looks like I forgot to merge this?
pushed now. Thanks for the reminder.
Lucas De Marchi
Quoted 20 lines
---
lib/xe/xe_ioctl.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)lib/xe/xe_ioctl.c +1
-1@@ -48,7 +48,7 @@uint32_t xe_cs_prefetch_size (int fd) { -return 2048 ; +return 4096 ; }uint32_t xe_vm_create (int fd,uint32_t flags,uint64_t ext)Signature · 1 line
2.43.0
Quoted 11 lines · Lucas De Marchi
Quoted 8 lines · Matthew Auld
From: Lucas De Marchi <[email protected]>
For Xe2, the prefetch for RCS is 4KB, so boost it.
BSpec: 60223
Signed-off-by Lucas De Marchi <[email protected]>Signed-off-by Matthew Auld <[email protected]>Cc Zbigniew Kempczyński <[email protected]>
Quoted 3 lines
humn... looks like I forgot to merge this?
pushed now. Thanks for the reminder.
Nice, but where's r-b?
--
Zbigniew
Quoted 23 lines
Lucas De Marchi
Quoted 20 lines
---
lib/xe/xe_ioctl.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)lib/xe/xe_ioctl.c +1
-1@@ -48,7 +48,7 @@uint32_t xe_cs_prefetch_size (int fd) { -return 2048 ; +return 4096 ; }uint32_t xe_vm_create (int fd,uint32_t flags,uint64_t ext)Signature · 1 line
2.43.0
Quoted 12 lines · Zbigniew Kempczyński
Quoted 11 lines · Lucas De Marchi
Quoted 8 lines · Matthew Auld
From: Lucas De Marchi <[email protected]>
For Xe2, the prefetch for RCS is 4KB, so boost it.
BSpec: 60223
Signed-off-by Lucas De Marchi <[email protected]>Signed-off-by Matthew Auld <[email protected]>Cc Zbigniew Kempczyński <[email protected]>
Quoted 5 lines
Quoted 3 lines
humn... looks like I forgot to merge this?
pushed now. Thanks for the reminder.
Nice, but where's r-b?
Note the 2 s-o-b, with me being the author of the patch. It wouldn't make sense for me to add a r-b on my own patch.
Would it make sense if Matthew added his? Maybe, but I don't think there's a real need in this oneliner where 2 devs agreed on the implementation.
Lucas De Marchi
Quoted 23 lines · Lucas De Marchi
Quoted 12 lines · Zbigniew Kempczyński
Quoted 11 lines · Lucas De Marchi
Quoted 8 lines · Matthew Auld
From: Lucas De Marchi <[email protected]>
For Xe2, the prefetch for RCS is 4KB, so boost it.
BSpec: 60223
Signed-off-by Lucas De Marchi <[email protected]>Signed-off-by Matthew Auld <[email protected]>Cc Zbigniew Kempczyński <[email protected]>Quoted 5 lines
Quoted 3 lines
humn... looks like I forgot to merge this?
pushed now. Thanks for the reminder.
Nice, but where's r-b?
Note the 2 s-o-b, with me being the author of the patch. It wouldn't make sense for me to add a r-b on my own patch.
Quoted 5 lines
Would it make sense if Matthew added his? Maybe, but I don't think there's a real need in this oneliner where 2 devs agreed on the implementation.
Lucas De Marchi
In this case change is safe but I would like to avoid merging code without r-b. Multiple s-o-b's don't replace review - otherwise we could upstream most of the code without r-b, couldn't we?
Anyway - we can close this thread.
--
Zbigniew
Patchwork
CI✗ Fi.CI.BAT: failure for lib/xe: Boost prefetch size to 4KB
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: lib/xe: Boost prefetch size to 4KB
URL : https://patchwork.freedesktop.org/series/129035/
State : failure
== Summary ==
Series 129035 revision 1 was fully merged or fully failed: no git log