Skip to contentSkip to conversation

ARM: fault: Add "cut here" line for prefetch aborts

PATCH In review Kees Cook 2 participants 2 messages Jan 23, 2024 Arm (32-bit)

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 ARM: fault: Add "cut here" line for prefetch aborts

The common pattern in arm is to emit a "8<--- cut here ---" line for faults, but it was missing for do_PrefetchAbort(). Add it.

Cc "Russell King (Oracle)" <[email protected]>
Cc Ard Biesheuvel <[email protected]>
Cc Wang Kefeng <[email protected]>
Cc Ben Hutchings <[email protected]>
Cc [email protected]
Signed-off-by Kees Cook <[email protected]>
---
 arch/arm/mm/fault.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mm/fault.c +1 -0
index e96fb40b9cc3..e804432e905e 100644
@@ -586,6 +586,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs)
 	if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs))
 		return;
 
+	pr_alert("8<--- cut here ---\n");
 	pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n",
 		inf->name, ifsr, addr);
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Kees Cook

The common pattern in arm is to emit a "8<--- cut here ---" line for faults, but it was missing for do_PrefetchAbort(). Add it.

Cc "Russell King (Oracle)" <[email protected]>
Cc Ard Biesheuvel <[email protected]>
Cc Wang Kefeng <[email protected]>
Cc Ben Hutchings <[email protected]>
Cc [email protected]
Signed-off-by Kees Cook <[email protected]>
Acked-by Ard Biesheuvel <[email protected]>
Quoted 19 lines
---
 arch/arm/mm/fault.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mm/fault.c +1 -1
index e96fb40b9cc3..e804432e905e 100644
@@ -586,6 +586,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs)
        if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs))
                return;
 
+       pr_alert("8<--- cut here ---\n");
        pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n",
                inf->name, ifsr, addr);
 
--

2.34.1