drm/qxl: pass a device into ttm init.
Subsystems (3)
Dave Airlie
maintainerPATCH 1/1 drm/qxl: pass a device into ttm init.
From: Dave Airlie <[email protected]>
ttm init was changed to look at numa node, but that needed a device.
Only qxl appears to not hand in a device, so just fix that.
Fixes b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer")
Reported-by Steven Rostedt <[email protected]>
Cc Rajneesh Bhardwaj <[email protected]>
Signed-off-by Dave Airlie <[email protected]>
--- drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/qxl/qxl_ttm.c +1 -1
@@ -195,7 +195,7 @@ int qxl_ttm_init(struct qxl_device *qdev)int num_io_pages;/* != rom->num_io_pages, we include surface0 */ /* No others user of address space so set it to 0 */ - r =ttm_device_init (&qdev->mman.bdev, &qxl_bo_driver,NULL , + r =ttm_device_init (&qdev->mman.bdev, &qxl_bo_driver, qdev->ddev.dev, qdev->ddev.anon_inode->i_mapping, qdev->ddev.vma_offset_manager, false, false);
Signature · 1 line
2.43.0
Quoted 8 lines · On Tue, 23 Jan 2024 12:20:15 +1000 Dave Airlie <[email protected]> wrote:
From: Dave Airlie <[email protected]>
ttm init was changed to look at numa node, but that needed a device.
Only qxl appears to not hand in a device, so just fix that.
Fixes b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer")Reported-by Steven Rostedt <[email protected]>
My tests seem to get past the crash with this patch and not my "fix".
-- Steve
Quoted 19 lines
Cc Rajneesh Bhardwaj <[email protected]>Signed-off-by Dave Airlie <[email protected]>--- drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/qxl/qxl_ttm.c +1
-1@@ -195,7 +195,7 @@ int qxl_ttm_init(struct qxl_device *qdev)int num_io_pages;/* != rom->num_io_pages, we include surface0 */ /* No others user of address space so set it to 0 */ - r =ttm_device_init (&qdev->mman.bdev, &qxl_bo_driver,NULL , + r =ttm_device_init (&qdev->mman.bdev, &qxl_bo_driver, qdev->ddev.dev, qdev->ddev.anon_inode->i_mapping, qdev->ddev.vma_offset_manager, false, false);