Skip to contentSkip to conversation

Add a quirk for Yamaha YIT-W12TX transmitter

PATCH In review Julian Sikorski 3 participants 4 messages Jan 23, 2024

Subsystems (2)
Stable branch Sound
lore
Share & tools
lore

Julian Sikorski

author
#0 lore raw

PATCH 1/1 Add a quirk for Yamaha YIT-W12TX transmitter

The device fails to initialize otherwise, giving the following error:

[ 3676.671641] usb 2-1.1: 1:1: cannot get freq at ep 0x1
Signed-off-by Julian Sikorski <[email protected]>
---
 sound/usb/quirks.c | 2 ++
 1 file changed, 2 insertions(+)
sound/usb/quirks.c +2 -0
index ab2b938502eb..bf0a7cca90d0 100644
@@ -2031,6 +2031,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_CTL_MSG_DELAY_1M | QUIRK_FLAG_IGNORE_CTL_ERROR),
 	DEVICE_FLG(0x0499, 0x1509, /* Steinberg UR22 */
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
+	DEVICE_FLG(0x0499, 0x3108, /* Yamaha YIT-W12TX */
+		   QUIRK_FLAG_GET_SAMPLE_RATE),
 	DEVICE_FLG(0x04d8, 0xfeea, /* Benchmark DAC1 Pre */
 		   QUIRK_FLAG_GET_SAMPLE_RATE),
 	DEVICE_FLG(0x04e8, 0xa051, /* Samsung USBC Headset (AKG) */
Signature · 1 line
2.43.0
build bot
#1 lore raw
FYI: kernel test robot notices the stable kernel rule is not satisfied.

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: [email protected]" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH] Add a quirk for Yamaha YIT-W12TX transmitter

Link https://lore.kernel.org/stable/20240123084935.2745-1-belegdol%2Bgithub%40gmail.com open here
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#2 lore raw
In reply to Julian Sikorski
Quoted 5 lines · Julian Sikorski

The device fails to initialize otherwise, giving the following error:

[ 3676.671641] usb 2-1.1: 1:1: cannot get freq at ep 0x1
Signed-off-by Julian Sikorski <[email protected]>

Thanks, I applied now.

But at the next time, try to check the following:

- Use a proper subject prefix; each subsystem has an own one, and this case would be "ALSA: usb-audio: Add a quirk..."

- Use the same mail address for both author and sign-off

- Put Cc-to-stable in the patch description instead of actually sending to it now

Takashi

author
#3 lore raw

Am 23.01.24 um 10:10 schrieb Takashi Iwai:

Quoted 15 lines
Quoted 5 lines · Julian Sikorski

The device fails to initialize otherwise, giving the following error:

[ 3676.671641] usb 2-1.1: 1:1: cannot get freq at ep 0x1
Signed-off-by Julian Sikorski <[email protected]>

Thanks, I applied now.

But at the next time, try to check the following:

- Use a proper subject prefix; each subsystem has an own one, and this case would be "ALSA: usb-audio: Add a quirk..."

Quoted 7 lines

- Use the same mail address for both author and sign-off

- Put Cc-to-stable in the patch description instead of actually sending to it now

Takashi

Thank you and apologies for the mistakes. I will try to do better next time.

Best regards,
Julian