iptables: Add missing error codes
PATCH 1/1 iptables: Add missing error codes
Without these, commands like iptables -n -L CHAIN sometimes print "Incompatible with this kernel" instead of "No chain/target/match by that name".
--- iptables/nft.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
iptables/nft.c +9 -3
@@ -2812,8 +2812,10 @@ int nft_rule_list(struct nft_handle *h, const char *chain, const char *table,if (chain) { c =nft_chain_find (h, table, chain); -if (!c) +if (!c) { + errno =ENOENT ;return 0 ; + }if (rulenum) d.save_fmt = true;/* skip header printing */
@@ -2920,8 +2922,10 @@ int nft_rule_list_save(struct nft_handle *h, const char *chain,if (chain) { c =nft_chain_find (h, table, chain); -if (!c) +if (!c) { + errno =ENOENT ;return 0 ; + }if (!rulenum)nft_rule_list_chain_save (c, &counters);
@@ -2953,8 +2957,10 @@ int nft_rule_zero_counters(struct nft_handle *h, const char *chain, nft_fn = nft_rule_delete; c =nft_chain_find (h, table, chain); -if (!c) +if (!c) { + errno =ENOENT ;return 0 ; + } r =nft_rule_find (h, c,NULL , rulenum);if (r ==NULL ) {
Signature · 1 line
2.35.3
Phil Sutter
reviewerHi,
Quoted 3 lines · Jacek Tomasiak
Without these, commands like
iptables -n -L CHAINsometimes print "Incompatible with this kernel" instead of "No chain/target/match by that name".
Thanks for the fix! I see errno value is tainted by unrelated code-paths if not explicitly set, but I failed to find a working reproducer. Do you have one at hand? Would be good to add a test and maybe add a Fixes: tag unless this is a day-1 bug.
Cheers, Phil
Hi,
Quoted 3 lines
(...) I failed to find a working reproducer. Do you
have one at hand? Would be good to add a test and maybe add a Fixes: tag unless this is a day-1 bug.
Unfortunately I see this behavior only inside our products. I couldn't reproduce it in any other environment. I suspect that this is related to some kernel configuration
or modules which are present there but I didn't investigate it further.
Regards,
Jacek
Signature · 4 lines
| PZDR Jacek aka SkaZi \\ | mail: [email protected] "Oset nie ma zadnego /O `----. | XMPP/Jabber: [email protected] pozytku z tego, ze * (_.-. )\ | sie na nim siedzi..." *|* rs //--// X
Phil Sutter
reviewerQuoted 8 lines · Jacek Tomasiak
Quoted 3 lines
(...) I failed to find a working reproducer. Do you
have one at hand? Would be good to add a test and maybe add a Fixes: tag unless this is a day-1 bug.Unfortunately I see this behavior only inside our products. I couldn't reproduce it in any other environment. I suspect that this is related to some kernel configuration
or modules which are present there but I didn't investigate it further.
Thanks for your feedback, I applied the patch as-is.
Thanks, Phil