Skip to contentSkip to conversation

gpio: cdev: remove leftover function pointer typedefs

PATCH In review Bartosz Golaszewski 3 participants 3 messages Jan 24, 2024 – Jan 31, 2024

Subsystems (2)
GPIO GPIO uapi
lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH 1/1 gpio: cdev: remove leftover function pointer typedefs

From: Bartosz Golaszewski <[email protected]>

The locking wrappers were replaces with lock guards. These typedefs are no longer needed.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/gpio/gpiolib-cdev.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpio/gpiolib-cdev.c +0 -5
index 2a88736629ef..34d6712fa07c 100644
@@ -61,11 +61,6 @@ static_assert(IS_ALIGNED(sizeof(struct gpio_v2_line_values), 8));
  * interface to gpiolib GPIOs via ioctl()s.
  */
 
-typedef __poll_t (*poll_fn)(struct file *, struct poll_table_struct *);
-typedef long (*ioctl_fn)(struct file *, unsigned int, unsigned long);
-typedef ssize_t (*read_fn)(struct file *, char __user *,
-			   size_t count, loff_t *);
-
 /*
  * GPIO line handle management
  */
Signature · 1 line
2.40.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

The locking wrappers were replaces with lock guards. These typedefs are no longer needed.

replaced

Given that,

Reviewed-by Kent Gibson <[email protected]>
Quoted 24 lines
Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/gpio/gpiolib-cdev.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpio/gpiolib-cdev.c +0 -6
index 2a88736629ef..34d6712fa07c 100644
@@ -61,11 +61,6 @@ static_assert(IS_ALIGNED(sizeof(struct gpio_v2_line_values), 8));
  * interface to gpiolib GPIOs via ioctl()s.
  */
 
-typedef __poll_t (*poll_fn)(struct file *, struct poll_table_struct *);
-typedef long (*ioctl_fn)(struct file *, unsigned int, unsigned long);
-typedef ssize_t (*read_fn)(struct file *, char __user *,
-			   size_t count, loff_t *);
-
 /*
  * GPIO line handle management
  */
--

2.40.1