Skip to contentSkip to conversation

spi: cs42l43: Handle error from devm_pm_runtime_enable

PATCH Superseded Charles Keepax 3 participants 3 messages Jan 24, 2024 – Jan 25, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: cs42l43: Handle error from devm_pm_runtime_enable

As it devm_pm_runtime_enable can fail due to memory allocations, it is best to handle the error.

---
 drivers/spi/spi-cs42l43.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/spi/spi-cs42l43.c +4 -1
index f13073e125936..b24190526ce96 100644
@@ -244,7 +244,10 @@ static int cs42l43_spi_probe(struct platform_device *pdev)
 	priv->ctlr->use_gpio_descriptors = true;
 	priv->ctlr->auto_runtime_pm = true;
 
-	devm_pm_runtime_enable(priv->dev);
+	ret = devm_pm_runtime_enable(priv->dev);
+	if (ret)
+		return ret;
+
 	pm_runtime_idle(priv->dev);
 
 	regmap_write(priv->regmap, CS42L43_TRAN_CONFIG6, CS42L43_FIFO_SIZE - 1);
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Charles Keepax

As it devm_pm_runtime_enable can fail due to memory allocations, it is best to handle the error.

devm_pm_runtime_enable()

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
In reply to Charles Keepax
Quoted 4 lines · Charles Keepax

As it devm_pm_runtime_enable can fail due to memory allocations, it is best to handle the error.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: cs42l43: Handle error from devm_pm_runtime_enable

      commit: f9f4b0c6425eb9ffd9bf62b8b8143e786b6ba695

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark