Skip to contentSkip to conversation

dt-bindings: i2c: mux: i2c-demux-pinctrl: Drop i2c-mux.yaml reference

PATCH In review Rob Herring 3 participants 8 messages Jan 24, 2024 – Mar 6, 2024

Subsystems (3)
Device tree bindings I2C subsystem host drivers Generic pinctrl I2C demultiplexer driver
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: i2c: mux: i2c-demux-pinctrl: Drop i2c-mux.yaml reference

The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not relevant and shouldn't be referenced.

Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml +0 -1
index 2c08f2a7cf1e..dd3d24212551 100644
@@ -32,7 +32,6 @@ description: |
       +-------------------------------+
 
 allOf:
-  - $ref: i2c-mux.yaml
   - $ref: /schemas/i2c/i2c-controller.yaml#
 
 properties:
Signature · 1 line
2.43.0
author maintainer
#1 lore raw

PATCH 2/2 dt-bindings: i2c: mux: i2c-demux-pinctrl: Define "i2c-parent" constraints

The 'phandle-array' type is a bit ambiguous. It can be either just an array of phandles or an array of phandles plus args. "i2c-parent" is the former and needs to constrain each entry to a single phandle value.

Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.yaml +2 -0
index dd3d24212551..b813f6d4810c 100644
@@ -40,6 +40,8 @@ properties:
 
   i2c-parent:
     $ref: /schemas/types.yaml#/definitions/phandle-array
+    items:
+      maxItems: 1
     description:
       List of phandles of I2C masters available for selection.  The first one
       will be used as default.
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] dt-bindings: i2c: mux: i2c-demux-pinctrl: Define "i2c-parent" constraints

In reply to Rob Herring
Quoted 5 lines · Rob Herring

The 'phandle-array' type is a bit ambiguous. It can be either just an array of phandles or an array of phandles plus args. "i2c-parent" is the former and needs to constrain each entry to a single phandle value.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Wolfram Sang <[email protected]>
maintainer
#4 lore raw
In reply to Wolfram Sang
Quoted 7 lines · Wolfram Sang
Quoted 4 lines · Rob Herring

The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not relevant and shouldn't be referenced.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Wolfram Sang <[email protected]>

Andi, can you pick these up?

Or you negotiate with Rob how you want to handle I2C DT patches. I agreed with him that I usually take them. Except for generic cleanups or so.

author maintainer
#5 lore raw
Quoted 11 lines · Wolfram Sang
Quoted 7 lines · Wolfram Sang
Quoted 4 lines · Rob Herring

The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not relevant and shouldn't be referenced.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Wolfram Sang <[email protected]>

Andi, can you pick these up?

I already did since you gave your reviewed-by and they hadn't otherwise been picked up.

Quoted 3 lines

Or you negotiate with Rob how you want to handle I2C DT patches. I agreed with him that I usually take them. Except for generic cleanups or so.

Yes, that is my preference. And how most subsystems work for bindings.

Rob

maintainer
#6 lore raw

Hi Rob,

Quoted 6 lines · Rob Herring

On Mon, Feb 26, 2024 at 4:48 AM Wolfram Sang

Quoted 5 lines · Wolfram Sang
Quoted 4 lines · Rob Herring
Quoted 3 lines

The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not relevant and shouldn't be referenced.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Rob Herring <[email protected]>
Reviewed-by Wolfram Sang <[email protected]>

Andi, can you pick these up?

I already did since you gave your reviewed-by and they hadn't otherwise been picked up.

Oh... I had them in my test branch and was waiting for some more tests before sending the notification.

Shall I remove them from my list?

Andi

maintainer
#7 lore raw

Hi Rob,

Quoted 13 lines · Andi Shyti
Quoted 12 lines · Rob Herring

On Mon, Feb 26, 2024 at 4:48 AM Wolfram Sang

Quoted 10 lines · Wolfram Sang
Quoted 7 lines · Rob Herring
Quoted 4 lines

The I2C de-mux is different than an I2C mux, so i2c-mux.yaml is not relevant and shouldn't be referenced.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Wolfram Sang <[email protected]>

Andi, can you pick these up?

Quoted 7 lines
Quoted 2 lines

I already did since you gave your reviewed-by and they hadn't otherwise been picked up.

Oh... I had them in my test branch and was waiting for some more tests before sending the notification.

Shall I remove them from my list?

Because I need to update my branches, I am going to take these two patches out. Please, let me know if you want me to take them back in.

Thanks,
Andi