Skip to contentSkip to conversation

dt-bindings: ufs: samsung,exynos-ufs: Add size constraints on "samsung,sysreg"

PATCH Applied Rob Herring 2 participants 3 messages Jan 24, 2024 – Feb 13, 2024

Subsystems (4)
Device tree bindings SCSI Arm Samsung Exynos UFS host controller
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: ufs: samsung,exynos-ufs: Add size constraints on "samsung,sysreg"

The 'phandle-array' type is a bit ambiguous. It can be either just an array of phandles or an array of phandles plus args. "samsung,sysreg" is the latter and needs to be constrained to a single entry with a phandle and offset.

Signed-off-by Rob Herring <[email protected]>
---
 .../devicetree/bindings/ufs/samsung,exynos-ufs.yaml      | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml +6 -3
index 88cc1e3a0c88..b2b509b3944d 100644
@@ -55,9 +55,12 @@ properties:
 
   samsung,sysreg:
     $ref: /schemas/types.yaml#/definitions/phandle-array
-    description: Should be phandle/offset pair. The phandle to the syscon node
-                 which indicates the FSYSx sysreg interface and the offset of
-                 the control register for UFS io coherency setting.
+    items:
+      - items:
+          - description: phandle to FSYSx sysreg node
+          - description: offset of the control register for UFS io coherency setting
+    description:
+      Phandle and offset to the FSYSx sysreg for UFS io coherency setting.
 
   dma-coherent: true
Signature · 1 line
2.43.0
author maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 10 lines · Rob Herring

The 'phandle-array' type is a bit ambiguous. It can be either just an array of phandles or an array of phandles plus args. "samsung,sysreg" is the latter and needs to be constrained to a single entry with a phandle and offset.

Signed-off-by Rob Herring <[email protected]>
---
 .../devicetree/bindings/ufs/samsung,exynos-ufs.yaml      | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Applied, thanks!