fs_fill: Increase test loop device size to 1GB
PATCH 1/1 fs_fill: Increase test loop device size to 1GB
On PPC64 the page size is 64K and this causes trouble on btrfs filesystems of small size(LTP currently use 300M), the threads could compete for a very small number of pages/blocks to actually write the data. So Increase minimal device size to 1G avoid the corner case.
--- testcases/kernel/fs/fs_fill/fs_fill.c | 1 + 1 file changed, 1 insertion(+)
testcases/kernel/fs/fs_fill/fs_fill.c +1 -0
@@ -123,6 +123,7 @@ static void cleanup(void)static struct tst_test test = { .max_runtime =60 , .needs_root =1 , + .dev_min_size =1024 , .mount_device =1 , .mntpoint =MNTPOINT , .all_filesystems =1 ,
Signature · 5 lines
2.35.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Wei,
Quoted 1 line
On PPC64 the page size is 64K and this causes trouble on btrfs
nit: s/PPC64/ppc64le/ (the other one is 32 bit)
nit: s/64K/4K/
Quoted 4 lines
filesystems of small size(LTP currently use 300M), the threads could compete for a very small number of pages/blocks to actually write the data. So Increase minimal device size to 1G avoid the corner case.
I wonder if would work with less (512 MB), but probably better to be safe with 1024 MB.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 4 lines · Petr Vorel
Hi Wei,
Quoted 1 line
On PPC64 the page size is 64K and this causes trouble on btrfs
nit: s/PPC64/ppc64le/ (the other one is 32 bit)
The other one is 64bit but big-endian. And yes, the big-endian mode will have the same issue, so "PPC64" is good enough catch-all term.
Quoted 1 line
nit: s/64K/4K/
No.
Quoted 13 lines
Quoted 4 lines
filesystems of small size(LTP currently use 300M), the threads could compete for a very small number of pages/blocks to actually write the data. So Increase minimal device size to 1G avoid the corner case.
Reviewed-by Petr Vorel <[email protected]>I wonder if would work with less (512 MB), but probably better to be safe with 1024 MB.
Kind regards,
Petr
Signature · 11 lines
Martin Doucha [email protected] SW Quality Engineer SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 8 lines · Petr Vorel
Quoted 4 lines
Hi Wei,
Quoted 1 line
On PPC64 the page size is 64K and this causes trouble on btrfs
nit: s/PPC64/ppc64le/ (the other one is 32 bit)
The other one is 64bit but big-endian. And yes, the big-endian mode will have the same issue, so "PPC64" is good enough catch-all term.
Wei, I'm sorry, of course Martin, you're right.
Quoted 3 lines
Quoted 1 line
nit: s/64K/4K/
No.
Also here.
Martin, thanks for correcting me.
Kind regards,
Petr
Quoted 12 lines
Quoted 12 lines
Quoted 4 lines
filesystems of small size(LTP currently use 300M), the threads could compete for a very small number of pages/blocks to actually write the data. So Increase minimal device size to 1G avoid the corner case.
Reviewed-by Petr Vorel <[email protected]>I wonder if would work with less (512 MB), but probably better to be safe with 1024 MB.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi,
Quoted 23 lines · Wei Gao via ltp
On PPC64 the page size is 64K and this causes trouble on btrfs filesystems of small size(LTP currently use 300M), the threads could compete for a very small number of pages/blocks to actually write the data. So Increase minimal device size to 1G avoid the corner case.
Signed-off-by Wei Gao <[email protected]>--- testcases/kernel/fs/fs_fill/fs_fill.c | 1 + 1 file changed, 1 insertion(+)testcases/kernel/fs/fs_fill/fs_fill.c +1
-0@@ -123,6 +123,7 @@ static void cleanup(void)static struct tst_test test = { .max_runtime =60 , .needs_root =1 , + .dev_min_size =1024 , .mount_device =1 , .mntpoint =MNTPOINT , .all_filesystems =1 ,
Signature · 11 lines
Martin Doucha [email protected] SW Quality Engineer SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp