Skip to contentSkip to conversation

perf test: Fix test case perf script tests on s390

PATCH Applied Thomas Richter 2 participants 2 messages Jan 25, 2024 perf events

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 perf test: Fix test case perf script tests on s390

In linux next repo, test case 'perf script tests' fails on s390. The root case is a command line invocation of perf record with call-graph information. On s390 only dwarf formatted call-graphs are supported and only on software events.

Change the command line parameters fors s390.

Output before:

 # perf test 89
 89: perf script tests              : FAILED!
 #

Output after:

 # perf test 89
 89: perf script tests              : Ok
 #
Fixes 0dd5041c9a0e ("perf addr_location: Add init/exit/copy functions")
---
 tools/perf/tests/shell/script.sh | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
tools/perf/tests/shell/script.sh +8 -1
index 5ae7bd0031a8..2973adab445d 100755
@@ -54,7 +54,14 @@ def sample_table(*args):
 def call_path_table(*args):
     print(f'call_path_table({args}')
 _end_of_file_
-	perf record -g -o "${perfdatafile}" true
+	case $(uname -m)
+	in s390x)
+		cmd_flags="--call-graph dwarf -e cpu-clock";;
+	*)
+		cmd_flags="-g";;
+	esac
+
+	perf record $cmd_flags -o "${perfdatafile}" true
 	perf script -i "${perfdatafile}" -s "${db_test}"
 	echo "DB test [Success]"
 }
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw

Em Thu, Jan 25, 2024 at 11:03:51AM +0100, Thomas Richter escreveu:

Quoted 6 lines

In linux next repo, test case 'perf script tests' fails on s390. The root case is a command line invocation of perf record with call-graph information. On s390 only dwarf formatted call-graphs are supported and only on software events.

Change the command line parameters fors s390.

Thanks, applied to perf-tools.

- Arnaldo