Skip to contentSkip to conversation

examples: cmdprio_bssplit: s,IO,I/O,

PATCH Applied Niklas Cassel 2 participants 3 messages Jan 26, 2024 – Jan 27, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 examples: cmdprio_bssplit: s,IO,I/O,

Replace IO with I/O.

---
 examples/cmdprio-bssplit.fio | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
examples/cmdprio-bssplit.fio +6 -6
index f3b2fac0..05f0d0b2 100644
@@ -12,9 +12,9 @@ iodepth=16
 ; use the same prio class and prio level defined by the cmdprio_class
 ; and cmdprio options.
 [cmdprio]
-; 40% of read IOs are 64kB and 60% are 1MB. 100% of writes are 1MB.
+; 40% of read I/Os are 64kB and 60% are 1MB. 100% of writes are 1MB.
 ; 100% of the 64kB reads are executed with prio class 1 and prio level 0.
-; All other IOs are executed without a priority set.
+; All other I/Os are executed without a priority set.
 bssplit=64k/40:1024k/60,1024k/100
 cmdprio_bssplit=64k/100:1024k/0,1024k/0
 cmdprio_class=1
@@ -23,20 +23,20 @@ cmdprio=0
 ; Advanced cmdprio_bssplit format. Each non-zero percentage entry can
 ; use a different prio class and prio level (appended to each entry).
 [cmdprio-adv]
-; 40% of read IOs are 64kB and 60% are 1MB. 100% of writes are 1MB.
+; 40% of read I/Os are 64kB and 60% are 1MB. 100% of writes are 1MB.
 ; 25% of the 64kB reads are executed with prio class 1 and prio level 1,
 ; 75% of the 64kB reads are executed with prio class 3 and prio level 2.
-; All other IOs are executed without a priority set.
+; All other I/Os are executed without a priority set.
 stonewall
 bssplit=64k/40:1024k/60,1024k/100
 cmdprio_bssplit=64k/25/1/1:64k/75/3/2:1024k/0,1024k/0
 
 ; Identical to the previous example, but with a default priority defined.
 [cmdprio-adv-def]
-; 40% of read IOs are 64kB and 60% are 1MB. 100% of writes are 1MB.
+; 40% of read I/Os are 64kB and 60% are 1MB. 100% of writes are 1MB.
 ; 25% of the 64kB reads are executed with prio class 1 and prio level 1,
 ; 75% of the 64kB reads are executed with prio class 3 and prio level 2.
-; All other IOs are executed with prio class 2 and prio level 7.
+; All other I/Os are executed with prio class 2 and prio level 7.
 stonewall
 prioclass=2
 prio=7
Signature · 1 line
2.43.0
#1 lore raw

PATCH 2/2 examples: cmdprio_bssplit: add CDL example

Add an example of how to use cmdprio_bssplit with Command Duration Limits.

---
 examples/cmdprio-bssplit.fio | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
examples/cmdprio-bssplit.fio +35 -0
index 05f0d0b2..ee202d74 100644
@@ -42,3 +42,38 @@ prioclass=2
 prio=7
 bssplit=64k/40:1024k/60,1024k/100
 cmdprio_bssplit=64k/25/1/1:64k/75/3/2:1024k/0,1024k/0
+
+; Example of how to use cmdprio_bssplit with Command Duration Limits (CDL)
+; using I/O priority hints. The drive has to support CDL, and CDL has to be
+; enabled in sysfs, otherwise the hints will not be sent down to the drive.
+[cmdprio-hints]
+; 40% of the I/Os are 1MB reads and 60% of the I/Os are 2MB reads.
+;
+; 10% of the 1MB reads are executed with prio class 2 (Best Effort),
+; prio level 0, and prio hint 1. Prio hint 1 means CDL descriptor 1.
+; Since 40% of read I/Os are 1MB, and 10% of the 1MB I/Os use CDL desc 1,
+; this means that 4% of all the issued I/O will use this configuration.
+;
+; 30% of the 1MB reads are executed with prio class 2 (Best Effort),
+; prio level 0, and prio hint 2. Prio hint 2 means CDL descriptor 2.
+; Since 40% of read I/Os are 1MB, and 30% of the 1MB I/Os use CDL desc 2,
+; this means that 12% of all the issued I/O will use this configuration.
+;
+; 60% of the 1MB reads are executed with prio class 2 (Best Effort),
+; prio level 0, and prio hint 0. Prio hint 0 means no hint.
+; Since 40% of read I/Os are 1MB, and 60% of the 1MB I/Os use no hint,
+; this means that 24% of all the issued I/O will use this configuration.
+;
+; 10% of the 2MB reads are executed with prio class 2 (Best Effort),
+; prio level 0, and prio hint 3. Prio hint 3 means CDL descriptor 3.
+; Since 60% of read I/Os are 2MB, and 10% of the 2MB I/Os use CDL desc 3,
+; this means that 6% of all the issued I/O will use this configuration.
+;
+; 90% of the 2MB reads are executed with prio class 2 (Best Effort),
+; prio level 0, and prio hint 0. Prio hint 0 means no hint.
+; Since 60% of read I/Os are 2MB, and 90% of the 2MB I/Os use no hint,
+; this means that 54% of all the issued I/O will use this configuration.
+stonewall
+rw=randread
+bssplit=1M/40:2M/60
+cmdprio_bssplit=1M/10/2/0/1:1M/30/2/0/2:1M/60/2/0/0:2M/10/2/0/3:2M/90/2/0/0
Signature · 1 line
2.43.0
Applied
#2 lore raw
In reply to Niklas Cassel
Quoted 38 lines · Niklas Cassel

Replace IO with I/O.

---
  examples/cmdprio-bssplit.fio | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
examples/cmdprio-bssplit.fio +4 -4
index f3b2fac0..05f0d0b2 100644
@@ -12,9 +12,9 @@ iodepth=16
  ; use the same prio class and prio level defined by the cmdprio_class
  ; and cmdprio options.
  [cmdprio]
-; 40% of read IOs are 64kB and 60% are 1MB. 100% of writes are 1MB.
+; 40% of read I/Os are 64kB and 60% are 1MB. 100% of writes are 1MB.
  ; 100% of the 64kB reads are executed with prio class 1 and prio level 0.
-; All other IOs are executed without a priority set.
+; All other I/Os are executed without a priority set.
  bssplit=64k/40:1024k/60,1024k/100
  cmdprio_bssplit=64k/100:1024k/0,1024k/0
  cmdprio_class=1
@@ -23,20 +23,20 @@ cmdprio=0
  ; Advanced cmdprio_bssplit format. Each non-zero percentage entry can
  ; use a different prio class and prio level (appended to each entry).
  [cmdprio-adv]
-; 40% of read IOs are 64kB and 60% are 1MB. 100% of writes are 1MB.
+; 40% of read I/Os are 64kB and 60% are 1MB. 100% of writes are 1MB.
  ; 25% of the 64kB reads are executed with prio class 1 and prio level 1,
  ; 75% of the 64kB reads are executed with prio class 3 and prio level 2.
-; All other IOs are executed without a priority set.
+; All other I/Os are executed without a priority set.
  stonewall
  bssplit=64k/40:1024k/60,1024k/100
  cmdprio_bssplit=64k/25/1/1:64k/75/3/2:1024k/0,1024k/0
 
  ; Identical to the previous example, but with a default priority defined.

examples/cmdprio-bssplit.fio cmdprio=0 · line 42

Quoted 10 lines
examples/cmdprio-bssplit.fio +2 -2
  [cmdprio-adv-def]
-; 40% of read IOs are 64kB and 60% are 1MB. 100% of writes are 1MB.
+; 40% of read I/Os are 64kB and 60% are 1MB. 100% of writes are 1MB.
  ; 25% of the 64kB reads are executed with prio class 1 and prio level 1,
  ; 75% of the 64kB reads are executed with prio class 3 and prio level 2.
-; All other IOs are executed with prio class 2 and prio level 7.
+; All other I/Os are executed with prio class 2 and prio level 7.
  stonewall
  prioclass=2
  prio=7

Applied. Thanks.

Vincent