irqchip/gic-v3-its: Restore quirk probing for ACPI-based systems
Marc Zyngier
maintainerPATCH 1/1 irqchip/gic-v3-its: Restore quirk probing for ACPI-based systems
While refactoring the way the ITSs are probed, the handling of quirks applicable to ACPI-based platforms was lost. As a result, systems such as HIP07 lose their GICv4 functionnality, and some other may even fail to boot, unless they are configured to boot with DT.
Move the enabling of quirks into its_probe_one(), making it common to all firmware implementations.
--- drivers/irqchip/irq-gic-v3-its.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/irqchip/irq-gic-v3-its.c +2 -1
@@ -5091,6 +5091,8 @@ static int __init its_probe_one(struct its_node *its)u32 ctlr;int err; +its_enable_quirks (its); +if (is_v4 (its)) {if (!(its->typer &GITS_TYPER_VMOVP )) { err =its_compute_its_list_map (its);
@@ -5442,7 +5444,6 @@ static int __init its_of_probe(struct device_node *node)if (!its)return -ENOMEM ; -its_enable_quirks (its); err =its_probe_one (its);if (err) {its_node_destroy (its);
Signature · 1 line
2.39.2
Quoted 3 lines · Marc Zyngier
While refactoring the way the ITSs are probed, the handling of quirks applicable to ACPI-based platforms was lost. As a result, systems such as HIP07 lose their GICv4 functionnality, and some
Just noticed: s/functionnality/functionality
Quoted 6 lines
other may even fail to boot, unless they are configured to boot with DT.
Move the enabling of quirks into
its_probe_one(), making it common to all firmware implementations.
Quoted 6 lines
Fixes 9585a495ac93 ("irqchip/gic-v3-its: Split allocation from initialisation of its_node")Signed-off-by Marc Zyngier <[email protected]>--- drivers/irqchip/irq-gic-v3-its.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
I obviously tested it with ACPI with platforms not neededing its quirks, apologies.
Quoted 24 lines
drivers/irqchip/irq-gic-v3-its.c +2
-1@@ -5091,6 +5091,8 @@ static int __init its_probe_one(struct its_node *its)u32 ctlr;int err; +its_enable_quirks (its); +if (is_v4 (its)) {if (!(its->typer &GITS_TYPER_VMOVP )) { err =its_compute_its_list_map (its);@@ -5442,7 +5444,6 @@ static int __init its_of_probe(struct device_node *node)if (!its)return -ENOMEM ; -its_enable_quirks (its); err =its_probe_one (its);if (err) {its_node_destroy (its);Signature · 1 line
2.39.2
Quoted 6 lines · Marc Zyngier
While refactoring the way the ITSs are probed, the handling of quirks applicable to ACPI-based platforms was lost. As a result, systems such as HIP07 lose their GICv4 functionnality, and some other may even fail to boot, unless they are configured to boot with DT.
Quoted 6 lines
Move the enabling of quirks into
its_probe_one(), making it common to all firmware implementations.Fixes 9585a495ac93 ("irqchip/gic-v3-its: Split allocation from initialisation of its_node")Signed-off-by Marc Zyngier <[email protected]>
Looks good,