pidfd: don't do_notify_pidfd() if !thread_group_empty()
cover pidfd: don't do_notify_pidfd() if !thread_group_empty()
To me this patch makes sense regardless, but also this is another preparation for PIDFD_THREAD change we discuss.
Oleg.
do_notify_pidfd() makes no sense until the whole thread group exits, change do_notify_parent() to check thread_group_empty().
This avoids the unnecessary do_notify_pidfd() when tsk is not a leader, or it exits before other threads, or it has a ptraced EXIT_ZOMBIE sub-thread.
--- kernel/signal.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
kernel/signal.c +5 -3
@@ -2050,9 +2050,11 @@ bool do_notify_parent(struct task_struct *tsk, int sig)WARN_ON_ONCE (!tsk->ptrace && (tsk->group_leader != tsk || !thread_group_empty (tsk))); - -/* Wake up all pidfd waiters */ -do_notify_pidfd (tsk); +/* +* tsk is a group leader and has no threads, wake up the pidfd waiters. +*/ +if (thread_group_empty (tsk)) +do_notify_pidfd (tsk);if (sig !=SIGCHLD ) {/*
Signature · 1 line
2.25.1.362.g51ebf55
PATCH 1/1 pidfd: don't do_notify_pidfd() if !thread_group_empty()
In reply to Oleg Nesterovdo_notify_pidfd() makes no sense until the whole thread group exits, change do_notify_parent() to check thread_group_empty().
This avoids the unnecessary do_notify_pidfd() when tsk is not a leader, or it exits before other threads, or it has a ptraced EXIT_ZOMBIE sub-thread.
--- kernel/signal.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
kernel/signal.c +5 -3
@@ -2050,9 +2050,11 @@ bool do_notify_parent(struct task_struct *tsk, int sig)WARN_ON_ONCE (!tsk->ptrace && (tsk->group_leader != tsk || !thread_group_empty (tsk))); - -/* Wake up all pidfd waiters */ -do_notify_pidfd (tsk); +/* +* tsk is a group leader and has no threads, wake up the pidfd waiters. +*/ +if (thread_group_empty (tsk)) +do_notify_pidfd (tsk);if (sig !=SIGCHLD ) {/*
Signature · 1 line
2.25.1.362.g51ebf55
Tycho Andersen
Reviewed-byQuoted 7 lines · Oleg Nesterov
do_notify_pidfd()makes no sense until the whole thread group exits, changedo_notify_parent()to checkthread_group_empty().This avoids the unnecessary
do_notify_pidfd()when tsk is not a leader, or it exits before other threads, or it has a ptracedEXIT_ZOMBIEsub-thread.Signed-off-by Oleg Nesterov <[email protected]>
Looks good to me, thanks.
Tycho
Quoted 5 lines · Tycho Andersen
Quoted 3 lines · Oleg Nesterov
do_notify_pidfd()makes no sense until the whole thread group exits, changedo_notify_parent()to checkthread_group_empty().
Quoted 8 lines
Quoted 4 lines
This avoids the unnecessary
do_notify_pidfd()when tsk is not a leader, or it exits before other threads, or it has a ptracedEXIT_ZOMBIEsub-thread.Signed-off-by Oleg Nesterov <[email protected]>Looks good to me, thanks.
Reviewed-by Tycho Andersen <[email protected]>
Thanks Tycho,
Oleg.
Christian Brauner
AppliedQuoted 5 lines · Oleg Nesterov
To me this patch makes sense regardless, but also this is another preparation for
PIDFD_THREADchange we discuss.Oleg.
Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc
[1/1] pidfd: don't do_notify_pidfd() if !thread_group_empty()
https://git.kernel.org/vfs/vfs/c/e191619dcdca