Skip to contentSkip to conversation

dt-bindings: net: dsa: Add KSZ8567 switch support

PATCH Applied Philippe Schenker 4 participants 7 messages Jan 30, 2024 – Feb 1, 2024

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 dt-bindings: net: dsa: Add KSZ8567 switch support

From: Philippe Schenker <[email protected]>

This commit adds the dt-binding for KSZ8567, a robust 7-port Ethernet switch. The KSZ8567 features two RGMII/MII/RMII interfaces, each capable of gigabit speeds, complemented by five 10/100 Mbps MAC/PHYs.

This binding is necessary to set specific capabilities for this switch chip that are necessary due to the ksz dsa driver only accepting specific chip ids.
The KSZ8567 is very similar to KSZ9567 however only containing 100 Mbps phys on its downstream ports.

---

(no changes since v2)

Changes in v2:
- Describe in commit message why this is necessary
- Add Conor's Acked-by. Thanks!

 Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml +1 -0
index c963dc09e8e1..52acc15ebcbf 100644
@@ -31,6 +31,7 @@ properties:
       - microchip,ksz9893
       - microchip,ksz9563
       - microchip,ksz8563
+      - microchip,ksz8567
 
   reset-gpios:
     description:
Signature · 1 line
2.34.1
#1 lore raw

PATCH v3 2/2 net: dsa: Add KSZ8567 switch support

From: Philippe Schenker <[email protected]>

This commit introduces support for the KSZ8567, a robust 7-port Ethernet switch. The KSZ8567 features two RGMII/MII/RMII interfaces, each capable of gigabit speeds, complemented by five 10/100 Mbps MAC/PHYs.

---

Changes in v3:
- Move KSZ8567_CHIP_ID also next to KSZ9567 in microchip-ksz.h
- Fix 80 chars warning.
- Add Arun's Acked-by. Thanks!

Changes in v2:
- Move the definition of KSZ8567 next to similar KSZ9567

 drivers/net/dsa/microchip/ksz9477_i2c.c     |  4 ++
 drivers/net/dsa/microchip/ksz_common.c      | 43 ++++++++++++++++++++-
 drivers/net/dsa/microchip/ksz_common.h      |  1 +
 drivers/net/dsa/microchip/ksz_spi.c         |  5 +++
 include/linux/platform_data/microchip-ksz.h |  1 +
 5 files changed, 53 insertions(+), 1 deletion(-)
drivers/net/dsa/microchip/ksz9477_i2c.c +4 -0
index cac4a607e54a..82bebee4615c 100644
@@ -103,6 +103,10 @@ static const struct of_device_id ksz9477_dt_ids[] = {
 		.compatible = "microchip,ksz8563",
 		.data = &ksz_switch_chips[KSZ8563]
 	},
+	{
+		.compatible = "microchip,ksz8567",
+		.data = &ksz_switch_chips[KSZ8567]
+	},
 	{
 		.compatible = "microchip,ksz9567",
 		.data = &ksz_switch_chips[KSZ9567]
drivers/net/dsa/microchip/ksz_common.c +42 -1

97 lines not on this page · raw message

drivers/net/dsa/microchip/ksz_common.h +1 -0
index 15612101a155..060c5de9aa05 100644
@@ -187,6 +187,7 @@ struct ksz_device {
 /* List of supported models */
 enum ksz_model {
 	KSZ8563,
+	KSZ8567,
 	KSZ8795,
 	KSZ8794,
 	KSZ8765,
drivers/net/dsa/microchip/ksz_spi.c +5 -0
index 6f6d878e742c..c8166fb440ab 100644
@@ -164,6 +164,10 @@ static const struct of_device_id ksz_dt_ids[] = {
 		.compatible = "microchip,ksz8563",
 		.data = &ksz_switch_chips[KSZ8563]
 	},
+	{
+		.compatible = "microchip,ksz8567",
+		.data = &ksz_switch_chips[KSZ8567]
+	},
 	{
 		.compatible = "microchip,ksz9567",
 		.data = &ksz_switch_chips[KSZ9567]
@@ -204,6 +208,7 @@ static const struct spi_device_id ksz_spi_ids[] = {
 	{ "ksz9893" },
 	{ "ksz9563" },
 	{ "ksz8563" },
+	{ "ksz8567" },
 	{ "ksz9567" },
 	{ "lan9370" },
 	{ "lan9371" },
include/linux/platform_data/microchip-ksz.h +1 -0
index f177416635a2..8c659db4da6b 100644
@@ -33,6 +33,7 @@ enum ksz_chip_id {
 	KSZ9897_CHIP_ID = 0x00989700,
 	KSZ9893_CHIP_ID = 0x00989300,
 	KSZ9563_CHIP_ID = 0x00956300,
+	KSZ8567_CHIP_ID = 0x00856700,
 	KSZ9567_CHIP_ID = 0x00956700,
 	LAN9370_CHIP_ID = 0x00937000,
 	LAN9371_CHIP_ID = 0x00937100,
Signature · 1 line
2.34.1
maintainer Reviewed-by on v3 1/2
#4 lore raw
In reply to Philippe Schenker
Quoted 7 lines · Philippe Schenker

From: Philippe Schenker <[email protected]>

This commit adds the dt-binding for KSZ8567, a robust 7-port Ethernet switch. The KSZ8567 features two RGMII/MII/RMII interfaces, each capable of gigabit speeds, complemented by five 10/100 Mbps MAC/PHYs.

Quoted 8 lines

This binding is necessary to set specific capabilities for this switch chip that are necessary due to the ksz dsa driver only accepting specific chip ids.
The KSZ8567 is very similar to KSZ9567 however only containing 100 Mbps phys on its downstream ports.

Andrew

maintainer Reviewed-by on v3 2/2
#2 lore raw

Re: [PATCH net-next v3 2/2] net: dsa: Add KSZ8567 switch support

In reply to Philippe Schenker
Quoted 9 lines · Philippe Schenker

From: Philippe Schenker <[email protected]>

This commit introduces support for the KSZ8567, a robust 7-port Ethernet switch. The KSZ8567 features two RGMII/MII/RMII interfaces, each capable of gigabit speeds, complemented by five 10/100 Mbps MAC/PHYs.

Andrew

Reviewed-by on v3 1/2
#5 lore raw
In reply to Philippe Schenker
Quoted 7 lines · Philippe Schenker

From: Philippe Schenker <[email protected]>

This commit adds the dt-binding for KSZ8567, a robust 7-port Ethernet switch. The KSZ8567 features two RGMII/MII/RMII interfaces, each capable of gigabit speeds, complemented by five 10/100 Mbps MAC/PHYs.

Quoted 8 lines

This binding is necessary to set specific capabilities for this switch chip that are necessary due to the ksz dsa driver only accepting specific chip ids.
The KSZ8567 is very similar to KSZ9567 however only containing 100 Mbps phys on its downstream ports.

Signature · 1 line
Florian
Reviewed-by on v3 2/2
#3 lore raw

Re: [PATCH net-next v3 2/2] net: dsa: Add KSZ8567 switch support

In reply to Philippe Schenker
Quoted 9 lines · Philippe Schenker

From: Philippe Schenker <[email protected]>

This commit introduces support for the KSZ8567, a robust 7-port Ethernet switch. The KSZ8567 features two RGMII/MII/RMII interfaces, each capable of gigabit speeds, complemented by five 10/100 Mbps MAC/PHYs.

Signature · 1 line
Florian
#6 lore raw
In reply to Philippe Schenker
This series was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Hello:

This series was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Tue, 30 Jan 2024 09:34:18 +0100 you wrote:

From: Philippe Schenker <[email protected]>

This commit adds the dt-binding for KSZ8567, a robust 7-port Ethernet switch. The KSZ8567 features two RGMII/MII/RMII interfaces, each capable of gigabit speeds, complemented by five 10/100 Mbps MAC/PHYs.

[...]

Here is the summary with links:
- [net-next,v3,1/2] dt-bindings: net: dsa: Add KSZ8567 switch support

    https://git.kernel.org/netdev/net-next/c/5f8066d45782
  - [net-next,v3,2/2] net: dsa: Add KSZ8567 switch support
    https://git.kernel.org/netdev/net-next/c/3723b56d6f73

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html