Skip to contentSkip to conversation

hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK

PATCH In review Naresh Solanki 2 participants 3 messages Jan 30, 2024 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK

From: Patrick Rudolph <[email protected]>

Use _pmbus_write_word_data to allow intercepting writes to PMBUS_SMBALERT_MASK in the custom chip specific code.

This is required for MP2971/MP2973 which doesn't follow the PMBUS specification for PMBUS_SMBALERT_MASK.

---
 drivers/hwmon/pmbus/pmbus_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/pmbus/pmbus_core.c +1 -1
index 1363d9f89181..cb4c65a7f288 100644
@@ -3188,7 +3188,7 @@ static int pmbus_regulator_notify(struct pmbus_data *data, int page, int event)
 
 static int pmbus_write_smbalert_mask(struct i2c_client *client, u8 page, u8 reg, u8 val)
 {
-	return pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8));
+	return _pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8));
 }
 
 static irqreturn_t pmbus_fault_handler(int irq, void *pdata)

base-commit: 861c0981648f5b64c86fd028ee622096eb7af05a

Signature · 1 line
2.42.0
maintainer
#1 lore raw
Quoted 7 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Use _pmbus_write_word_data to allow intercepting writes to PMBUS_SMBALERT_MASK in the custom chip specific code.

This is required for MP2971/MP2973 which doesn't follow the PMBUS specification for PMBUS_SMBALERT_MASK.

Applied, but is there going to be a follow-up patch for those chips ?

Thanks,
Guenter

#2 lore raw

Hi Guenter,

Quoted 11 lines · Guenter Roeck
Quoted 7 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Use _pmbus_write_word_data to allow intercepting writes to PMBUS_SMBALERT_MASK in the custom chip specific code.

This is required for MP2971/MP2973 which doesn't follow the PMBUS specification for PMBUS_SMBALERT_MASK.

Applied, but is there going to be a follow-up patch for those chips ?

Yes.

Regards,
Naresh

Quoted 3 lines

Thanks,
Guenter