Skip to contentSkip to conversation

sound: remove duplicated CONFIG_SND_PXA2XX_AC97 entry

PATCH In review Masahiro Yamada 2 participants 4 messages Feb 4, 2024

Subsystems (3)
Sound ASoC PXA2xx/PXA3xx support
lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 sound: remove duplicated CONFIG_SND_PXA2XX_AC97 entry

'config SND_PXA2XX_AC97' is already present in sound/arm/Kconfig with a prompt.

Commit 734c2d4bb7cf ("[ALSA] ASoC pxa2xx build support") redundantly added the second one to sound/soc/pxa/Kconfig.

Remove it.

Signed-off-by Masahiro Yamada <[email protected]>

---

 sound/soc/pxa/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
sound/soc/pxa/Kconfig +0 -3
index f03c74809324..e05d6ce4c8fa 100644
@@ -8,9 +8,6 @@ config SND_PXA2XX_SOC
 	  the PXA2xx AC97, I2S or SSP interface. You will also need
 	  to select the audio interfaces to support below.
 
-config SND_PXA2XX_AC97
-	tristate
-
 config SND_PXA2XX_SOC_AC97
 	tristate "SoC AC97 support for PXA2xx"
 	depends on SND_PXA2XX_SOC
Signature · 1 line
2.40.1
author
#1 lore raw

Maybe, the patch subject "ASoC: pxa:" might be better than "sound:" so it matches the change history in this directory.

Quoted 32 lines · Masahiro Yamada

'config SND_PXA2XX_AC97' is already present in sound/arm/Kconfig with a prompt.

Commit 734c2d4bb7cf ("[ALSA] ASoC pxa2xx build support") redundantly added the second one to sound/soc/pxa/Kconfig.

Remove it.

Signed-off-by Masahiro Yamada <[email protected]>

---

 sound/soc/pxa/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
sound/soc/pxa/Kconfig +0 -4
index f03c74809324..e05d6ce4c8fa 100644
@@ -8,9 +8,6 @@ config SND_PXA2XX_SOC
          the PXA2xx AC97, I2S or SSP interface. You will also need
          to select the audio interfaces to support below.
 
-config SND_PXA2XX_AC97
-       tristate
-
 config SND_PXA2XX_SOC_AC97
        tristate "SoC AC97 support for PXA2xx"
        depends on SND_PXA2XX_SOC
--

2.40.1

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw
Quoted 3 lines · Masahiro Yamada

Maybe, the patch subject "ASoC: pxa:" might be better than "sound:" so it matches the change history in this directory.

Yes, care to resubmit with that prefix?

thanks,

Takashi

author
#3 lore raw
Quoted 9 lines · Takashi Iwai
Quoted 3 lines · Masahiro Yamada

Maybe, the patch subject "ASoC: pxa:" might be better than "sound:" so it matches the change history in this directory.

Yes, care to resubmit with that prefix?

Sure.

Signature · 2 lines
Best Regards
Masahiro Yamada