nvmem: rmem: Fix return value of rmem_read()
PATCH 1/1 nvmem: rmem: Fix return value of rmem_read()
reg_read() callback registered with nvmem core expects an integer error as a return value but rmem_read() returns the number of bytes read, as a result error checks in nvmem core fail even when they shouldn't.
Return 0 on success where number of bytes read match the number of bytes requested and a negative error -EINVAL on all other cases.
--- drivers/nvmem/rmem.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/nvmem/rmem.c +6 -1
@@ -46,7 +46,12 @@ static int rmem_read(void *context, unsigned int offset,memunmap (addr); -return count; +if (count != bytes) { +dev_err (priv->dev,"Failed read memory (%d)\n" , count); +return -EINVAL ; + } + +return 0 ; }static int rmem_probe (struct platform_device *pdev)
Signature · 1 line
2.43.0.594.gd9cf4e227d-goog
Quoted 4 lines · Joy Chakraborty
reg_read()callback registered with nvmem core expects an integer error as a return value butrmem_read()returns the number of bytes read, as a result error checks in nvmem core fail even when they shouldn't.
Quoted 8 lines
Return 0 on success where number of bytes read match the number of bytes requested and a negative error
-EINVALon all other cases.Fixes 5a3fa75a4d9c ("nvmem: Add driver to expose reserved memory as nvmem")Signed-off-by Joy Chakraborty <[email protected]>--- drivers/nvmem/rmem.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot