Skip to contentSkip to conversation

linux-next: build warnings after merge of the pci tree

DISCUSSION Stephen Rothwell 2 participants 2 messages Feb 5, 2024 – Feb 6, 2024 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the pci tree, today's linux-next build (htmldocs) produced these warnings:

Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:function:: void __iomem *pci_iomap_range(struct pci_dev *dev, int bar, unsigned long offset, unsigned long maxlen)'. Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:None:: struct pci_dev *dev'.
Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:None:: int bar'.
Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:None:: unsigned long offset'.
Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:None:: unsigned long maxlen'.
Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:function:: void __iomem *pci_iomap_wc_range(struct pci_dev *dev, int bar, unsigned long offset, unsigned long maxlen)'. Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:None:: struct pci_dev *dev'.
Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:None:: int bar'.
Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:None:: unsigned long offset'.
Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:None:: unsigned long maxlen'.
Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110. Declaration is '.. c:function:: void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long maxlen)'. Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110. Declaration is '.. c:None:: struct pci_dev *dev'.
Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110. Declaration is '.. c:None:: int bar'.
Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110. Declaration is '.. c:None:: unsigned long maxlen'.
Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131. Declaration is '.. c:function:: void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long maxlen)'. Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131. Declaration is '.. c:None:: struct pci_dev *dev'.
Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131. Declaration is '.. c:None:: int bar'.
Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131. Declaration is '.. c:None:: unsigned long maxlen'.

Introduced by commit

fbcc7d7f7948 ("PCI: Move pci_iomap.c to drivers/pci/")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

Hi,

Quoted 66 lines · Stephen Rothwell

Hi all,

After merging the pci tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:function:: void __iomem *pci_iomap_range(struct pci_dev *dev, int bar, unsigned long offset, unsigned long maxlen)'. Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:None:: struct pci_dev *dev'. Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:None:: int bar'. Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:None:: unsigned long offset'. Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27. Declaration is '.. c:None:: unsigned long maxlen'. Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:function:: void __iomem *pci_iomap_wc_range(struct pci_dev *dev, int bar, unsigned long offset, unsigned long maxlen)'. Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:None:: struct pci_dev *dev'. Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:None:: int bar'. Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:None:: unsigned long offset'. Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67. Declaration is '.. c:None:: unsigned long maxlen'. Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110. Declaration is '.. c:function:: void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long maxlen)'. Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110. Declaration is '.. c:None:: struct pci_dev *dev'. Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110. Declaration is '.. c:None:: int bar'. Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110. Declaration is '.. c:None:: unsigned long maxlen'. Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131. Declaration is '.. c:function:: void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long maxlen)'. Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131. Declaration is '.. c:None:: struct pci_dev *dev'. Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131. Declaration is '.. c:None:: int bar'. Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131. Declaration is '.. c:None:: unsigned long maxlen'.

Quoted 3 lines

Introduced by commit

  fbcc7d7f7948 ("PCI: Move pci_iomap.c to drivers/pci/")

Oh oh – Mea culpa. Will fix this.

I'd just ask for some direction how to fix it. My instinct would be to just remove it from device-io.rst, since it's very PCI-specific; What do you think?

P.

Quoted 1 line