comedi: remove redundant assignment to variable range
Subsystems (2)
PATCH 1/1 comedi: remove redundant assignment to variable range
The variable range is being initialized with a value that is never read, it is being re-assigned later on. The initialization is redundant and can be removed.
Cleans up clang scan build warning:drivers/comedi/drivers/das08.c:180:2: warning: Value stored to 'range' is never read [deadcode.DeadStores]
--- drivers/comedi/drivers/das08.c | 1 - 1 file changed, 1 deletion(-)
drivers/comedi/drivers/das08.c +0 -1
@@ -177,7 +177,6 @@ static int das08_ai_insn_read(struct comedi_device *dev,int ret; chan =CR_CHAN (insn->chanspec); - range =CR_RANGE (insn->chanspec);/* clear crap */ inb (dev->iobase +DAS08_AI_LSB_REG );
Signature · 1 line
2.39.2
Quoted 18 lines · Colin Ian King
The variable range is being initialized with a value that is never read, it is being re-assigned later on. The initialization is redundant and can be removed.
Cleans up clang scan build warning:
drivers/comedi/drivers/das08.c:180:2: warning: Value stored to 'range' is never read [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>--- drivers/comedi/drivers/das08.c | 1 - 1 file changed, 1 deletion(-)drivers/comedi/drivers/das08.c +0
-0
drivers/comedi/drivers/das08.c static int das08_ai_insn_read(struct comedi_device *dev, · line 182
Quoted 7 lines
drivers/comedi/drivers/das08.c +0
-1@@ -177,7 +177,6 @@ static int das08_ai_insn_read(struct comedi_device *dev,int ret; chan =CR_CHAN (insn->chanspec); - range =CR_RANGE (insn->chanspec);/* clear crap */ inb (dev->iobase +DAS08_AI_LSB_REG );
Thanks. It looks like it gets reassigned to the same value further down, closer to the point where the value is used (within an if block), and so it doesn't matter which of the assignments is removed.
Signature · 4 lines
-=( Ian Abbott <[email protected]> || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-