ethdev: add IPv6 field identifiers
cover ethdev: add IPv6 field identifiers
Add new field identifiers for IPv6 traffic class and flow label.
Depends-on: series-31008 ("ethdev: add modify IPv4 next protocol field")
Michael Baum (1):
ethdev: add IPv6 FL and TC field identifiers
app/test-pmd/cmdline_flow.c | 1 + doc/guides/rel_notes/release_24_03.rst | 2 ++ lib/ethdev/rte_flow.h | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1
PATCH 1/1 ethdev: add IPv6 FL and TC field identifiers
Add new "rte_flow_field_id" enumeration values to describe both IPv6 traffic class and IPv6 flow label fields.
The TC value is "RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and "ipv6_traffic_class" in testpmd command.
The FL value is "RTE_FLOW_FIELD_IPV6_FLOW_LABEL" in flow API and "ipv6_flow_label" in testpmd command.
--- app/test-pmd/cmdline_flow.c | 1 + doc/guides/rel_notes/release_24_03.rst | 2 ++ lib/ethdev/rte_flow.h | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-)
app/test-pmd/cmdline_flow.c +1 -0
@@ -964,6 +964,7 @@ static const char *const modify_field_ids[] = {"random" ,"ipv4_proto" ,"esp_spi" ,"esp_seq_num" ,"esp_proto" , +"ipv6_flow_label" ,"ipv6_traffic_class" , NULL };
doc/guides/rel_notes/release_24_03.rst +2 -0
@@ -68,6 +68,8 @@ New Features * Added ``RTE_FLOW_FIELD_ESP_SPI`` to represent it in field ID struct. * Added ``RTE_FLOW_FIELD_ESP_SEQ_NUM`` to represent it in field ID struct. * Added ``RTE_FLOW_FIELD_ESP_PROTO`` to represent it in field ID struct. + * Added ``RTE_FLOW_FIELD_IPV6_FLOW_LABEL`` to represent it in field ID struct. + * Added ``RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS`` to represent it in field ID struct. * ** Support for getting the number of used descriptors of a Tx queue. **
lib/ethdev/rte_flow.h +3 -1
@@ -3937,7 +3937,9 @@ enum rte_flow_field_id {RTE_FLOW_FIELD_IPV4_PROTO ,/**< IPv4 next protocol. */ RTE_FLOW_FIELD_ESP_SPI ,/**< ESP SPI. */ RTE_FLOW_FIELD_ESP_SEQ_NUM ,/**< ESP Sequence Number. */ - RTE_FLOW_FIELD_ESP_PROTO /**< ESP next protocol value. */ +RTE_FLOW_FIELD_ESP_PROTO ,/**< ESP next protocol value. */ +RTE_FLOW_FIELD_IPV6_FLOW_LABEL ,/**< IPv6 flow label. */ + RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS/**< IPv6 traffic class. */ };/**
Signature · 1 line
2.25.1
RE: [PATCH 1/1] ethdev: add IPv6 FL and TC field identifiers
Quoted 12 lines
-----Original Message-----
From: Michael Baum <[email protected]>
Sent: Tuesday, February 6, 2024 15:27
To: [email protected]
Cc: Ori Kam <[email protected]>; Dariusz Sosnowski <[email protected]>; Ferruh Yigit <[email protected]>; NBU- Contact-Thomas Monjalon (EXTERNAL) <[email protected]>
Subject: [PATCH 1/1] ethdev: add IPv6 FL and TC field identifiersAdd new "
rte_flow_field_id" enumeration values to describe both IPv6 traffic class and IPv6 flow label fields.
Quoted 6 lines
The TC value is "
RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and "ipv6_traffic_class" in testpmd command.
The FL value is "RTE_FLOW_FIELD_IPV6_FLOW_LABEL" in flow API and "ipv6_flow_label" in testpmd command.Signed-off-by Michael Baum <[email protected]>
Best regards,
Dariusz Sosnowski
v2 cover ethdev: add IPv6 field identifiers
In reply to Michael BaumAdd new field identifiers for IPv6 traffic class and flow label.
Depends-on: series-31008 ("ethdev: add modify IPv4 next protocol field")
v2:
- Rebase.
- Add "Acked-by" label from v1.
Michael Baum (1):
ethdev: add IPv6 FL and TC field identifiers
app/test-pmd/cmdline_flow.c | 1 + doc/guides/rel_notes/release_24_03.rst | 2 ++ lib/ethdev/rte_flow.h | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1
PATCH v2 1/1 ethdev: add IPv6 FL and TC field identifiers
Add new "rte_flow_field_id" enumeration values to describe both IPv6 traffic class and IPv6 flow label fields.
The TC value is "RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and "ipv6_traffic_class" in testpmd command.
The FL value is "RTE_FLOW_FIELD_IPV6_FLOW_LABEL" in flow API and "ipv6_flow_label" in testpmd command.
--- app/test-pmd/cmdline_flow.c | 1 + doc/guides/rel_notes/release_24_03.rst | 2 ++ lib/ethdev/rte_flow.h | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-)
app/test-pmd/cmdline_flow.c +1 -0
@@ -992,6 +992,7 @@ static const char *const flow_field_ids[] = {"random" ,"ipv4_proto" ,"esp_spi" ,"esp_seq_num" ,"esp_proto" , +"ipv6_flow_label" ,"ipv6_traffic_class" , NULL };
doc/guides/rel_notes/release_24_03.rst +2 -0
@@ -68,6 +68,8 @@ New Features * Added ``RTE_FLOW_FIELD_ESP_SPI`` to represent it in field ID struct. * Added ``RTE_FLOW_FIELD_ESP_SEQ_NUM`` to represent it in field ID struct. * Added ``RTE_FLOW_FIELD_ESP_PROTO`` to represent it in field ID struct. + * Added ``RTE_FLOW_FIELD_IPV6_FLOW_LABEL`` to represent it in field ID struct. + * Added ``RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS`` to represent it in field ID struct. * ** Support for getting the number of used descriptors of a Tx queue. **
lib/ethdev/rte_flow.h +3 -1
@@ -2425,7 +2425,9 @@ enum rte_flow_field_id {RTE_FLOW_FIELD_IPV4_PROTO ,/**< IPv4 next protocol. */ RTE_FLOW_FIELD_ESP_SPI ,/**< ESP SPI. */ RTE_FLOW_FIELD_ESP_SEQ_NUM ,/**< ESP Sequence Number. */ - RTE_FLOW_FIELD_ESP_PROTO /**< ESP next protocol value. */ +RTE_FLOW_FIELD_ESP_PROTO ,/**< ESP next protocol value. */ +RTE_FLOW_FIELD_IPV6_FLOW_LABEL ,/**< IPv6 flow label. */ + RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS/**< IPv6 traffic class. */ };/**
Signature · 1 line
2.25.1
Re: [PATCH v2 1/1] ethdev: add IPv6 FL and TC field identifiers
Quoted 33 lines · Michael Baum
Add new "
rte_flow_field_id" enumeration values to describe both IPv6 traffic class and IPv6 flow label fields.The TC value is "
RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and "ipv6_traffic_class" in testpmd command.
The FL value is "RTE_FLOW_FIELD_IPV6_FLOW_LABEL" in flow API and "ipv6_flow_label" in testpmd command.Signed-off-by Michael Baum <[email protected]>--- app/test-pmd/cmdline_flow.c | 1 + doc/guides/rel_notes/release_24_03.rst | 2 ++ lib/ethdev/rte_flow.h | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-)app/test-pmd/cmdline_flow.c +1
-0@@ -992,6 +992,7 @@ static const char *const flow_field_ids[] = {"random" ,"ipv4_proto" ,"esp_spi" ,"esp_seq_num" ,"esp_proto" , +"ipv6_flow_label" ,"ipv6_traffic_class" , NULL };doc/guides/rel_notes/release_24_03.rst +0
-0
doc/guides/rel_notes/release_24_03.rst New Features · line 73
Quoted 6 lines
doc/guides/rel_notes/release_24_03.rst +2
-0@@ -68,6 +68,8 @@ New Features * Added ``RTE_FLOW_FIELD_ESP_SPI`` to represent it in field ID struct. * Added ``RTE_FLOW_FIELD_ESP_SEQ_NUM`` to represent it in field ID struct. * Added ``RTE_FLOW_FIELD_ESP_PROTO`` to represent it in field ID struct. + * Added ``RTE_FLOW_FIELD_IPV6_FLOW_LABEL`` to represent it in field ID struct. + * Added ``RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS`` to represent it in field ID struct.
On which tree is this patch based on, I don't see above notes. Can you please rebase on latest next-net?
Quoted 17 lines
doc/guides/rel_notes/release_24_03.rst +0
-0* ** Support for getting the number of used descriptors of a Tx queue. **lib/ethdev/rte_flow.h +3
-1@@ -2425,7 +2425,9 @@ enum rte_flow_field_id {RTE_FLOW_FIELD_IPV4_PROTO ,/**< IPv4 next protocol. */ RTE_FLOW_FIELD_ESP_SPI ,/**< ESP SPI. */ RTE_FLOW_FIELD_ESP_SEQ_NUM ,/**< ESP Sequence Number. */ - RTE_FLOW_FIELD_ESP_PROTO /**< ESP next protocol value. */ +RTE_FLOW_FIELD_ESP_PROTO ,/**< ESP next protocol value. */ +RTE_FLOW_FIELD_IPV6_FLOW_LABEL ,/**< IPv6 flow label. */ + RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS/**< IPv6 traffic class. */ };/**
RE: [PATCH v2 1/1] ethdev: add IPv6 FL and TC field identifiers
Quoted 39 lines · Ferruh Yigit
Quoted 34 lines · Michael Baum
Add new "
rte_flow_field_id" enumeration values to describe both IPv6 traffic class and IPv6 flow label fields.The TC value is "
RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and "ipv6_traffic_class" in testpmd command.
The FL value is "RTE_FLOW_FIELD_IPV6_FLOW_LABEL" in flow API and "ipv6_flow_label" in testpmd command.Signed-off-by Michael Baum <[email protected]>--- app/test-pmd/cmdline_flow.c | 1 + doc/guides/rel_notes/release_24_03.rst | 2 ++ lib/ethdev/rte_flow.h | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-)app/test-pmd/cmdline_flow.c +1
-0@@ -992,6 +992,7 @@ static const char *const flow_field_ids[] = {"random" ,"ipv4_proto" ,"esp_spi" ,"esp_seq_num" ,"esp_proto" , +"ipv6_flow_label" ,"ipv6_traffic_class" , NULL };doc/guides/rel_notes/release_24_03.rst +0
-0doc/guides/rel_notes/release_24_03.rst New Features · line 69
Quoted 2 lines
doc/guides/rel_notes/release_24_03.rst +0
-0@@ -68,6 +68,8 @@ New Features * Added ``RTE_FLOW_FIELD_ESP_SPI`` to represent it in field ID struct. * Added ``RTE_FLOW_FIELD_ESP_SEQ_NUM`` to represent it in field IDstruct.
Quoted 8 lines
doc/guides/rel_notes/release_24_03.rst New Features · line 71
Quoted 2 lines
doc/guides/rel_notes/release_24_03.rst +1
-0* Added ``RTE_FLOW_FIELD_ESP_PROTO`` to represent it in field ID struct. + * Added ``RTE_FLOW_FIELD_IPV6_FLOW_LABEL`` to represent it in field IDstruct.
doc/guides/rel_notes/release_24_03.rst New Features · line 72
Quoted 1 line
doc/guides/rel_notes/release_24_03.rst +1
-0+ * Added ``RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS`` to represent it in fieldID struct.
Quoted 1 line
On which tree is this patch based on, I don't see above notes.
I added in the cover letter this dependency:
Depends-on: series-31008 ("ethdev: add modify IPv4 next protocol field") But it has new version now:
https://patchwork.dpdk.org/project/dpdk/list/?series=31037
Quoted 1 line
Can you please rebase on latest next-net?
Do you prefer me to send a new version without dependency?
Quoted 19 lines
Quoted 19 lines
* ** Support for getting the number of used descriptors of a Tx
queue. **lib/ethdev/rte_flow.h index renamed from lib/ethdev/rte_flow.h +0
-0
b8fc16b819..8b32a69d8d100644lib/ethdev/rte_flow.h +3
-1@@ -2425,7 +2425,9 @@ enum rte_flow_field_id {RTE_FLOW_FIELD_IPV4_PROTO ,/**< IPv4 next protocol. */ RTE_FLOW_FIELD_ESP_SPI ,/**< ESP SPI. */ RTE_FLOW_FIELD_ESP_SEQ_NUM ,/**< ESP Sequence Number. */ - RTE_FLOW_FIELD_ESP_PROTO /**< ESP next protocol value. */ +RTE_FLOW_FIELD_ESP_PROTO ,/**< ESP next protocol value. */ +RTE_FLOW_FIELD_IPV6_FLOW_LABEL ,/**< IPv6 flow label. */ + RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS/**< IPv6 traffic class. */ };/**
Re: [PATCH v2 1/1] ethdev: add IPv6 FL and TC field identifiers
Quoted 49 lines · Michael Baum
Quoted 39 lines · Ferruh Yigit
Quoted 34 lines · Michael Baum
Add new "
rte_flow_field_id" enumeration values to describe both IPv6 traffic class and IPv6 flow label fields.The TC value is "
RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and "ipv6_traffic_class" in testpmd command.
The FL value is "RTE_FLOW_FIELD_IPV6_FLOW_LABEL" in flow API and "ipv6_flow_label" in testpmd command.Signed-off-by Michael Baum <[email protected]>--- app/test-pmd/cmdline_flow.c | 1 + doc/guides/rel_notes/release_24_03.rst | 2 ++ lib/ethdev/rte_flow.h | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-)app/test-pmd/cmdline_flow.c +1
-0@@ -992,6 +992,7 @@ static const char *const flow_field_ids[] = {"random" ,"ipv4_proto" ,"esp_spi" ,"esp_seq_num" ,"esp_proto" , +"ipv6_flow_label" ,"ipv6_traffic_class" , NULL };doc/guides/rel_notes/release_24_03.rst +0
-0doc/guides/rel_notes/release_24_03.rst New Features · line 69
Quoted 2 lines
doc/guides/rel_notes/release_24_03.rst +0
-0@@ -68,6 +68,8 @@ New Features * Added ``RTE_FLOW_FIELD_ESP_SPI`` to represent it in field ID struct. * Added ``RTE_FLOW_FIELD_ESP_SEQ_NUM`` to represent it in field IDstruct.
Quoted 8 lines
doc/guides/rel_notes/release_24_03.rst New Features · line 71
Quoted 2 lines
doc/guides/rel_notes/release_24_03.rst +1
-0* Added ``RTE_FLOW_FIELD_ESP_PROTO`` to represent it in field ID struct. + * Added ``RTE_FLOW_FIELD_IPV6_FLOW_LABEL`` to represent it in field IDstruct.
doc/guides/rel_notes/release_24_03.rst New Features · line 72
Quoted 1 line
doc/guides/rel_notes/release_24_03.rst +1
-0+ * Added ``RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS`` to represent it in fieldID struct.
Quoted 1 line
On which tree is this patch based on, I don't see above notes.
Quoted 9 lines
I added in the cover letter this dependency:
Depends-on: series-31008 ("ethdev: add modify IPv4 next protocol field") But it has new version now:
https://patchwork.dpdk.org/project/dpdk/list/?series=31037Quoted 1 line
Can you please rebase on latest next-net?
Do you prefer me to send a new version without dependency?
Right, I missed the depends-on tag.
Dependent patch is delegated to Raslan, and this patch is straightforward.
Let me ack the patch and assign it to Raslan, assuming he is OK, he can get this one after he merged the dependent patch.
@Raslan, please let me know if I am missing something.
Re: [PATCH v2 1/1] ethdev: add IPv6 FL and TC field identifiers
In reply to Michael BaumQuoted 11 lines · Michael Baum
Add new "
rte_flow_field_id" enumeration values to describe both IPv6 traffic class and IPv6 flow label fields.The TC value is "
RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and "ipv6_traffic_class" in testpmd command.
The FL value is "RTE_FLOW_FIELD_IPV6_FLOW_LABEL" in flow API and "ipv6_flow_label" in testpmd command.Signed-off-by Michael Baum <[email protected]>
Re: [PATCH v2 1/1] ethdev: add IPv6 FL and TC field identifiers
In reply to Michael BaumHI,
Quoted 10 lines
Add new "
rte_flow_field_id" enumeration values to describe both IPv6 traffic class and IPv6 flow label fields.The TC value is "
RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and "ipv6_traffic_class" in testpmd command.
The FL value is "RTE_FLOW_FIELD_IPV6_FLOW_LABEL" in flow API and "ipv6_flow_label" in testpmd command.Signed-off-by Michael Baum <[email protected]>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh