selftests/mqueue: Set timeout to 100 seconds
Subsystems (2)
PATCH 1/1 selftests/mqueue: Set timeout to 100 seconds
While mq_perf_tests runs with the default kselftest timeout limit, which is 45 seconds, the test takes about 60 seconds to complete on i3.metal AWS instances. Hence, the test always times out. Increase the timeout to 100 seconds.
--- tools/testing/selftests/mqueue/setting | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/mqueue/setting
tools/testing/selftests/mqueue/setting new file +1 -0
@@ -0,0 +1 @@ +timeout=100
Signature · 1 line
2.39.2
Quoted 25 lines · SeongJae Park
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
While
mq_perf_testsruns with the default kselftest timeout limit, which is 45 seconds, the test takes about 60 seconds to complete on i3.metal AWS instances. Hence, the test always times out. Increase the timeout to 100 seconds.Fixes 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")Cc <[email protected]> # 5.4.xSigned-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/mqueue/setting | 1 + 1 file changed, 1 insertion(+)create mode 100644
tools/testing/selftests/mqueue/settingtools/testing/selftests/mqueue/setting new file +1
-1@@ -0,0 +1 @@ +timeout=100 --
Quoted 3 lines
2.39.2
Added Vijai Kumar to CC
This looks similar to [PATCH] kselftest: mqueue: increase timeout https://lore.kernel.org/lkml/[email protected]/T/#r12820aede6bba015b70ae33323e29ae27d5b69c7 which was increasing the timeout to 180 however it's not clear why this hasn't been merged yet. I have seen the same issue on v5.15.y so it's very likely that we will need to apply this on all LTS branches not just 5.4 as mentioned in Cc: <[email protected]> # 5.4.x
Hazem
Quoted 32 lines · Hazem
Quoted 25 lines · SeongJae Park
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
While
mq_perf_testsruns with the default kselftest timeout limit, which is 45 seconds, the test takes about 60 seconds to complete on i3.metal AWS instances. Hence, the test always times out. Increase the timeout to 100 seconds.Fixes 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")Cc <[email protected]> # 5.4.xSigned-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/mqueue/setting | 1 + 1 file changed, 1 insertion(+)create mode 100644
tools/testing/selftests/mqueue/settingtools/testing/selftests/mqueue/setting new file +1
-1@@ -0,0 +1 @@ +timeout=100 --Quoted 3 lines
2.39.2
Added Vijai Kumar to CC
Quoted 4 lines
This looks similar to [PATCH] kselftest: mqueue: increase timeout
https://lore.kernel.org/lkml/[email protected]/T/#r12820aede6bba015b70ae33323e29ae27d5b69c7
which was increasing the timeout to 180 however it's not clear why this hasn't been merged yet.
Thank you. I don't care who's patch would be picked, but hope any of those be merged. For more eyes, I'm Cc-ing contacts from ./scripts/get_maintainer.pl ipc/mqueue.c output.
Quoted 3 lines
I have seen the same issue on v5.15.y so it's
very likely that we will need to apply this on all LTS branches not just 5.4 as mentioned in Cc: <[email protected]> # 5.4.x
Yes, that's the intent of the Fixes: and Cc: <[email protected]> lines. I hope the lines to be added to Vijai's patch if it is picked instead of this.
Thanks,
SJ
Quoted 3 lines
Hazem
A gentle reminder.
Thanks,
SJ
Quoted 57 lines · On Fri, 9 Feb 2024 09:42:43 -0800 SeongJae Park <[email protected]> wrote:
Quoted 32 lines · Hazem
Quoted 25 lines · SeongJae Park
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
While
mq_perf_testsruns with the default kselftest timeout limit, which is 45 seconds, the test takes about 60 seconds to complete on i3.metal AWS instances. Hence, the test always times out. Increase the timeout to 100 seconds.Fixes 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")Cc <[email protected]> # 5.4.xSigned-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/mqueue/setting | 1 + 1 file changed, 1 insertion(+)create mode 100644
tools/testing/selftests/mqueue/settingtools/testing/selftests/mqueue/setting new file +1
-1@@ -0,0 +1 @@ +timeout=100 --Quoted 3 lines
2.39.2
Added Vijai Kumar to CC
Quoted 4 lines
This looks similar to [PATCH] kselftest: mqueue: increase timeout
https://lore.kernel.org/lkml/[email protected]/T/#r12820aede6bba015b70ae33323e29ae27d5b69c7
which was increasing the timeout to 180 however it's not clear why this hasn't been merged yet.Thank you. I don't care who's patch would be picked, but hope any of those be merged. For more eyes, I'm Cc-ing contacts from
./scripts/get_maintainer.pl ipc/mqueue.coutput.Quoted 3 lines
I have seen the same issue on v5.15.y so it's
very likely that we will need to apply this on all LTS branches not just 5.4 as mentioned in Cc: <[email protected]> # 5.4.xYes, that's the intent of the Fixes: and Cc: <[email protected]> lines. I hope the lines to be added to Vijai's patch if it is picked instead of this.
Thanks,
SJQuoted 3 lines
Hazem
Kees Cook
Reviewed-byQuoted 46 lines · SeongJae Park
A gentle reminder.
Thanks,
SJQuoted 38 lines · On Fri, 9 Feb 2024 09:42:43 -0800 SeongJae Park <[email protected]> wrote:
Quoted 36 lines · Hazem
Quoted 25 lines · SeongJae Park
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
While
mq_perf_testsruns with the default kselftest timeout limit, which is 45 seconds, the test takes about 60 seconds to complete on i3.metal AWS instances. Hence, the test always times out. Increase the timeout to 100 seconds.Fixes 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")Cc <[email protected]> # 5.4.xSigned-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/mqueue/setting | 1 + 1 file changed, 1 insertion(+)create mode 100644
tools/testing/selftests/mqueue/settingtools/testing/selftests/mqueue/setting new file +1
-1@@ -0,0 +1 @@ +timeout=100 --Quoted 3 lines
2.39.2
Added Vijai Kumar to CC
This looks similar to [PATCH] kselftest: mqueue: increase timeout
https://lore.kernel.org/lkml/[email protected]/T/#r12820aede6bba015b70ae33323e29ae27d5b69c7
which was increasing the timeout to 180 however it's not clear why this hasn't been merged yet.
Should it be 100 or 180? Either way:
Signature · 1 line
Kees Cook
Quoted 43 lines · On Fri, 16 Feb 2024 16:01:20 -0800 Kees Cook <[email protected]> wrote:
Quoted 42 lines · SeongJae Park
A gentle reminder.
Thanks,
SJQuoted 34 lines · On Fri, 9 Feb 2024 09:42:43 -0800 SeongJae Park <[email protected]> wrote:
Quoted 32 lines · Hazem
Quoted 25 lines · SeongJae Park
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
While
mq_perf_testsruns with the default kselftest timeout limit, which is 45 seconds, the test takes about 60 seconds to complete on i3.metal AWS instances. Hence, the test always times out. Increase the timeout to 100 seconds.Fixes 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")Cc <[email protected]> # 5.4.xSigned-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/mqueue/setting | 1 + 1 file changed, 1 insertion(+)create mode 100644
tools/testing/selftests/mqueue/settingtools/testing/selftests/mqueue/setting new file +1
-1@@ -0,0 +1 @@ +timeout=100 --Quoted 3 lines
2.39.2
Added Vijai Kumar to CC
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
This looks similar to [PATCH] kselftest: mqueue: increase timeout
https://lore.kernel.org/lkml/[email protected]/T/#r12820aede6bba015b70ae33323e29ae27d5b69c7
which was increasing the timeout to 180 however it's not clear why this hasn't been merged yet.Should it be 100 or 180?
As mentioned on the previous mail[1], either values are good to me :)
[1] https://lore.kernel.org/r/[email protected]
Quoted 3 lines
Either way:
Reviewed-by Kees Cook <[email protected]>
Thank you!
Thanks,
SJ
Quoted 4 lines
Signature · 2 lines
-- Kees Cook
Quoted 4 lines · SeongJae Park
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
Quoted 51 lines
Quoted 49 lines · On Fri, 16 Feb 2024 16:01:20 -0800 Kees Cook <[email protected]> wrote:
Quoted 46 lines · SeongJae Park
A gentle reminder.
Thanks,
SJQuoted 38 lines · On Fri, 9 Feb 2024 09:42:43 -0800 SeongJae Park <[email protected]> wrote:
Quoted 36 lines · Hazem
Quoted 25 lines · SeongJae Park
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
While
mq_perf_testsruns with the default kselftest timeout limit, which is 45 seconds, the test takes about 60 seconds to complete on i3.metal AWS instances. Hence, the test always times out. Increase the timeout to 100 seconds.Fixes 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")Cc <[email protected]> # 5.4.xSigned-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/mqueue/setting | 1 + 1 file changed, 1 insertion(+)create mode 100644
tools/testing/selftests/mqueue/settingtools/testing/selftests/mqueue/setting new file +1
-1@@ -0,0 +1 @@ +timeout=100 --Quoted 3 lines
2.39.2
Added Vijai Kumar to CC
This looks similar to [PATCH] kselftest: mqueue: increase timeout
https://lore.kernel.org/lkml/[email protected]/T/#r12820aede6bba015b70ae33323e29ae27d5b69c7
which was increasing the timeout to 180 however it's not clear why this hasn't been merged yet.Should it be 100 or 180?
Both options may work, I am more inclined to have this as 180 seconds by giving more time for the test to finish, this can be reduced later to 100 or something else if we start hearing complains about the new timeout.
Hazem
Quoted 19 lines
As mentioned on the previous mail[1], either values are good to me :)
[1] https://lore.kernel.org/r/[email protected]
Quoted 3 lines
Either way:
Reviewed-by Kees Cook <[email protected]>Thank you!
Thanks,
SJQuoted 4 lines
--
Kees Cook
Quoted 7 lines · Kees Cook
Should it be 100 or 180? Either way:
Reviewed-by Kees Cook <[email protected]>--
Kees Cook
Both options may work, I am more inclined to have this as 180 seconds by giving more time for the test to finish, this can be reduced later to 100 or something else if we start hearing complains about the new timeout.
Hazem
Quoted 55 lines · Hazem
Quoted 54 lines · SeongJae Park
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
Quoted 48 lines · On Fri, 16 Feb 2024 16:01:20 -0800 Kees Cook <[email protected]> wrote:
Quoted 46 lines · SeongJae Park
A gentle reminder.
Thanks,
SJQuoted 38 lines · On Fri, 9 Feb 2024 09:42:43 -0800 SeongJae Park <[email protected]> wrote:
Quoted 36 lines · Hazem
Quoted 25 lines · SeongJae Park
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
While
mq_perf_testsruns with the default kselftest timeout limit, which is 45 seconds, the test takes about 60 seconds to complete on i3.metal AWS instances. Hence, the test always times out. Increase the timeout to 100 seconds.Fixes 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")Cc <[email protected]> # 5.4.xSigned-off-by SeongJae Park <[email protected]>--- tools/testing/selftests/mqueue/setting | 1 + 1 file changed, 1 insertion(+)create mode 100644
tools/testing/selftests/mqueue/settingtools/testing/selftests/mqueue/setting new file +1
-1@@ -0,0 +1 @@ +timeout=100 --Quoted 3 lines
2.39.2
Added Vijai Kumar to CC
This looks similar to [PATCH] kselftest: mqueue: increase timeout
https://lore.kernel.org/lkml/[email protected]/T/#r12820aede6bba015b70ae33323e29ae27d5b69c7
which was increasing the timeout to 180 however it's not clear why this hasn't been merged yet.
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Should it be 100 or 180?
Both options may work, I am more inclined to have this as 180 seconds by giving more time for the test to finish, this can be reduced later to 100 or something else if we start hearing complains about the new timeout.
Thank you for the opinion. I will send v2 with 180 seconds timeout.
Thanks,
SJ
Quoted 23 lines
Hazem
Quoted 19 lines
As mentioned on the previous mail[1], either values are good to me :)
[1] https://lore.kernel.org/r/[email protected]
Quoted 3 lines
Either way:
Reviewed-by Kees Cook <[email protected]>Thank you!
Thanks,
SJQuoted 4 lines
--
Kees Cook