LPSS PWM cleanups
Subsystems (2)
cover LPSS PWM cleanups
This series implements minor cleanups for LPSS PWM driver.
Raag Jadav (2):
pwm: lpss: use devm_pm_runtime_enable() helper
pwm: lpss: drop redundant runtime PM handles
drivers/pwm/pwm-lpss-pci.c | 22 ---------------------- drivers/pwm/pwm-lpss-platform.c | 10 +--------- 2 files changed, 1 insertion(+), 31 deletions(-)
Signature · 1 line
2.35.3
PATCH 1/2 pwm: lpss: use devm_pm_runtime_enable() helper
Use devm_pm_runtime_enable() helper to enable runtime PM and drop redundant platform ->remove() callback.
--- drivers/pwm/pwm-lpss-platform.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/pwm/pwm-lpss-platform.c +1 -9
@@ -57,14 +57,7 @@ static int pwm_lpss_probe_platform(struct platform_device *pdev) DPM_FLAG_SMART_SUSPEND);pm_runtime_set_active (&pdev->dev); -pm_runtime_enable (&pdev->dev); - -return 0 ; -} - -static void pwm_lpss_remove_platform (struct platform_device *pdev) -{ -pm_runtime_disable (&pdev->dev); +return devm_pm_runtime_enable (&pdev->dev); }static const struct acpi_device_id pwm_lpss_acpi_match[] = {
@@ -82,7 +75,6 @@ static struct platform_driver pwm_lpss_driver_platform = { .acpi_match_table = pwm_lpss_acpi_match, }, .probe = pwm_lpss_probe_platform, - .remove_new = pwm_lpss_remove_platform, };module_platform_driver (pwm_lpss_driver_platform);
Signature · 1 line
2.35.3
PATCH 2/2 pwm: lpss: drop redundant runtime PM handles
In reply to Raag JadavWe no longer need empty runtime PM handles for PCI devices after commit c5eb1190074c ("PCI / PM: Allow runtime PM without callback functions"). Drop them and let PCI core take care of power state transitions.
--- drivers/pwm/pwm-lpss-pci.c | 22 ---------------------- 1 file changed, 22 deletions(-)
drivers/pwm/pwm-lpss-pci.c +0 -22
@@ -48,25 +48,6 @@ static void pwm_lpss_remove_pci(struct pci_dev *pdev)pm_runtime_get_sync (&pdev->dev); } -static int pwm_lpss_runtime_suspend_pci (struct device *dev) -{ -/* -* The PCI core will handle transition to D3 automatically. We only -* need to provide runtime PM hooks for that to happen. -*/ -return 0 ; -} - -static int pwm_lpss_runtime_resume_pci (struct device *dev) -{ -return 0 ; -} - -static DEFINE_RUNTIME_DEV_PM_OPS(pwm_lpss_pci_pm, - pwm_lpss_runtime_suspend_pci, - pwm_lpss_runtime_resume_pci, - NULL); -static const struct pci_device_id pwm_lpss_pci_ids[] = { {PCI_VDEVICE (INTEL ,0x0ac8 ), (unsigned long )&pwm_lpss_bxt_info}, {PCI_VDEVICE (INTEL ,0x0f08 ), (unsigned long )&pwm_lpss_byt_info},
@@ -86,9 +67,6 @@ static struct pci_driver pwm_lpss_driver_pci = { .id_table = pwm_lpss_pci_ids, .probe = pwm_lpss_probe_pci, .remove = pwm_lpss_remove_pci, - .driver = { - .pm = pm_ptr(&pwm_lpss_pci_pm), - }, };module_pci_driver (pwm_lpss_driver_pci);
Signature · 1 line
2.35.3
Re: [PATCH v1 2/2] pwm: lpss: drop redundant runtime PM handles
Quoted 10 lines · Raag Jadav
We no longer need empty runtime PM handles for PCI devices after commit
c5eb1190074c("PCI / PM: Allow runtime PM without callback functions"). Drop them and let PCI core take care of power state transitions.Signed-off-by Raag Jadav <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>--- drivers/pwm/pwm-lpss-pci.c | 22 ---------------------- 1 file changed, 22 deletions(-)
Will this patch cause a regression if applied without your another patch to the drivers/pci/pci-driver.c?
Re: [PATCH v1 2/2] pwm: lpss: drop redundant runtime PM handles
Quoted 11 lines · Jarkko Nikula
Quoted 10 lines · Raag Jadav
We no longer need empty runtime PM handles for PCI devices after commit
c5eb1190074c("PCI / PM: Allow runtime PM without callback functions"). Drop them and let PCI core take care of power state transitions.Signed-off-by Raag Jadav <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>--- drivers/pwm/pwm-lpss-pci.c | 22 ---------------------- 1 file changed, 22 deletions(-)
Quoted 4 lines
Will this patch cause a regression if applied without your another patch to the
drivers/pci/pci-driver.c?
Yes, I'll send out a v2 with updated commit message after the PCI one is accepted.
Raag
Hello,
Quoted 9 lines · Raag Jadav
This series implements minor cleanups for LPSS PWM driver.
Raag Jadav (2):
pwm: lpss: usedevm_pm_runtime_enable()helper
pwm: lpss: drop redundant runtime PM handlesdrivers/pwm/pwm-lpss-pci.c | 22 ---------------------- drivers/pwm/pwm-lpss-platform.c | 10 +--------- 2 files changed, 1 insertion(+), 31 deletions(-)
the series looks fine to me. Will give others some more time to comment and apply later.
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |