efi/capsule-loader: fix incorrect allocation size
PATCH 1/1 efi/capsule-loader: fix incorrect allocation size
From: Arnd Bergmann <[email protected]>
gcc-14 notices that the allocation with sizeof(void) on 32-bit architectures is not enough for a 64-bit phys_addr_t:
drivers/firmware/efi/capsule-loader.c: In function 'efi_capsule_open':drivers/firmware/efi/capsule-loader.c:295:24: error: allocation of insufficient size '4' for type 'phys_addr_t' {aka 'long long unsigned int'} with size '8' [-Werror=alloc-size]
295 | cap_info->phys = kzalloc(sizeof(void *), GFP_KERNEL);
| ^
Use the correct type instead here.
--- drivers/firmware/efi/capsule-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/efi/capsule-loader.c +1 -1
@@ -292,7 +292,7 @@ static int efi_capsule_open(struct inode *inode, struct file *file)return -ENOMEM ; } - cap_info->phys =kzalloc (sizeof (void *),GFP_KERNEL ); + cap_info->phys =kzalloc (sizeof (phys_addr_t),GFP_KERNEL );if (!cap_info->phys) {kfree (cap_info->pages);kfree (cap_info);
Signature · 1 line
2.39.2
Ard Biesheuvel
maintainerQuoted 24 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
gcc-14 notices that the allocation with sizeof(void) on 32-bit architectures is not enough for a 64-bit
phys_addr_t:
drivers/firmware/efi/capsule-loader.c: In function 'efi_capsule_open':drivers/firmware/efi/capsule-loader.c:295:24: error: allocation of insufficient size '4' for type 'phys_addr_t' {aka 'long long unsigned int'} with size '8' [-Werror=alloc-size]
295 |cap_info->phys=kzalloc(sizeof(void *), GFP_KERNEL);
| ^Use the correct type instead here.
Fixes f24c4d478013 ("efi/capsule-loader: Reinstate virtual capsule mapping")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/firmware/efi/capsule-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firmware/efi/capsule-loader.c +0
-0
drivers/firmware/efi/capsule-loader.c static int efi_capsule_open(struct inode *inode, struct file *file) · line 298
Quoted 8 lines
drivers/firmware/efi/capsule-loader.c +1
-1@@ -292,7 +292,7 @@ static int efi_capsule_open(struct inode *inode, struct file *file)return -ENOMEM ; } - cap_info->phys =kzalloc (sizeof (void *),GFP_KERNEL ); + cap_info->phys =kzalloc (sizeof (phys_addr_t),GFP_KERNEL );if (!cap_info->phys) {kfree (cap_info->pages);kfree (cap_info);
Thanks, queued as a fix.