Skip to contentSkip to conversation

ext4: Don't report EOPNOTSUPP errors from discard

PATCH Applied Jan Kara 4 participants 7 messages Feb 13, 2024 – Feb 23, 2024 ext4 file system

lore
Share & tools
lore

Jan Kara

author reviewer
#0 lore raw

PATCH 1/1 ext4: Don't report EOPNOTSUPP errors from discard

When ext4 is mounted without journal, with discard mount option, and on a device not supporting trim, we print error for each and every freed extent. This is not only useless but actively harmful. Instead ignore the EOPNOTSUPP error. Trim is only advisory anyway and when the filesystem has journal we silently ignore trim error as well.

---
 fs/ext4/mballoc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
fs/ext4/mballoc.c +7 -1
index e4f7cf9d89c4..aed620cf4d40 100644
@@ -6488,7 +6488,13 @@ static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode,
 		if (test_opt(sb, DISCARD)) {
 			err = ext4_issue_discard(sb, block_group, bit,
 						 count_clusters, NULL);
-			if (err && err != -EOPNOTSUPP)
+			/*
+			 * Ignore EOPNOTSUPP error. This is consistent with
+			 * what happens when using journal.
+			 */
+			if (err == -EOPNOTSUPP)
+				err = 0;
+			if (err)
 				ext4_msg(sb, KERN_WARNING, "discard request in"
 					 " group:%u block:%d count:%lu failed"
 					 " with %d", block_group, bit, count,
Signature · 1 line
2.35.3
#1 lore raw
Quoted 19 lines · Jan Kara

When ext4 is mounted without journal, with discard mount option, and on a device not supporting trim, we print error for each and every freed extent. This is not only useless but actively harmful. Instead ignore the EOPNOTSUPP error. Trim is only advisory anyway and when the filesystem has journal we silently ignore trim error as well.

---
fs/ext4/mballoc.c | 8 +++++++-

1 file changed, 7 insertions(+), 1 deletion(-)
fs/ext4/mballoc.c +0 -0
index e4f7cf9d89c4..aed620cf4d40 100644
@@ -6488,7 +6488,13 @@ static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode,
 		if (test_opt(sb, DISCARD)) {

fs/ext4/mballoc.c static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode, · line 6497

Quoted 10 lines
fs/ext4/mballoc.c +7 -1
 			err = ext4_issue_discard(sb, block_group, bit,
 						 count_clusters, NULL);
-			if (err && err != -EOPNOTSUPP)
+			/*
+			 * Ignore EOPNOTSUPP error. This is consistent with
+			 * what happens when using journal.
+			 */
+			if (err == -EOPNOTSUPP)
+				err = 0;
+			if (err)

I don't see how this patch is actually changing whether the error message is printed? Previously, if "err" was set and err was -EOPNOTSUPP the message was skipped. Now it is doing the same thing in a different way?

The "err" value is overwritten 50 lines later on without being used:

        err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh);

so the setting "err = 0" doesn't really affect the later code either. What am I missing?

Cheers, Andreas

author reviewer
#2 lore raw
Quoted 35 lines · Andreas Dilger
Quoted 19 lines · Jan Kara

When ext4 is mounted without journal, with discard mount option, and on a device not supporting trim, we print error for each and every freed extent. This is not only useless but actively harmful. Instead ignore the EOPNOTSUPP error. Trim is only advisory anyway and when the filesystem has journal we silently ignore trim error as well.

---
fs/ext4/mballoc.c | 8 +++++++-

1 file changed, 7 insertions(+), 1 deletion(-)
fs/ext4/mballoc.c +0 -0
index e4f7cf9d89c4..aed620cf4d40 100644
@@ -6488,7 +6488,13 @@ static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode,
 		if (test_opt(sb, DISCARD)) {

fs/ext4/mballoc.c static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode, · line 6497

Quoted 10 lines
fs/ext4/mballoc.c +7 -1
 			err = ext4_issue_discard(sb, block_group, bit,
 						 count_clusters, NULL);
-			if (err && err != -EOPNOTSUPP)
+			/*
+			 * Ignore EOPNOTSUPP error. This is consistent with
+			 * what happens when using journal.
+			 */
+			if (err == -EOPNOTSUPP)
+				err = 0;
+			if (err)

I don't see how this patch is actually changing whether the error message is printed? Previously, if "err" was set and err was -EOPNOTSUPP the message was skipped. Now it is doing the same thing in a different way?

Quoted 6 lines

The "err" value is overwritten 50 lines later on without being used:

        err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh);

so the setting "err = 0" doesn't really affect the later code either. What am I missing?

Yeah, the code flow is a bit contrived. The error message gets printed by ext4_std_error() at the end of ext4_mb_clear_bb(). I don't think there's any ext4_handle_dirty_metadata() call in the current version of ext4_mb_clear_bb()...

Honza

Quoted 4 lines

Cheers, Andreas

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#3 lore raw
Quoted 41 lines · Jan Kara
Quoted 39 lines · Andreas Dilger
Quoted 19 lines · Jan Kara

When ext4 is mounted without journal, with discard mount option, and on a device not supporting trim, we print error for each and every freed extent. This is not only useless but actively harmful. Instead ignore the EOPNOTSUPP error. Trim is only advisory anyway and when the filesystem has journal we silently ignore trim error as well.

---
fs/ext4/mballoc.c | 8 +++++++-

1 file changed, 7 insertions(+), 1 deletion(-)
fs/ext4/mballoc.c +0 -0
index e4f7cf9d89c4..aed620cf4d40 100644
@@ -6488,7 +6488,13 @@ static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode,
 		if (test_opt(sb, DISCARD)) {

fs/ext4/mballoc.c static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode, · line 6497

Quoted 10 lines
fs/ext4/mballoc.c +7 -1
 			err = ext4_issue_discard(sb, block_group, bit,
 						 count_clusters, NULL);
-			if (err && err != -EOPNOTSUPP)
+			/*
+			 * Ignore EOPNOTSUPP error. This is consistent with
+			 * what happens when using journal.
+			 */
+			if (err == -EOPNOTSUPP)
+				err = 0;
+			if (err)

I don't see how this patch is actually changing whether the error message is printed? Previously, if "err" was set and err was -EOPNOTSUPP the message was skipped. Now it is doing the same thing in a different way?

The "err" value is overwritten 50 lines later on without being used:

       err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh);
Quoted 7 lines
Quoted 2 lines

so the setting "err = 0" doesn't really affect the later code either. What am I missing?

Yeah, the code flow is a bit contrived. The error message gets printed by ext4_std_error() at the end of ext4_mb_clear_bb(). I don't think there's any ext4_handle_dirty_metadata() call in the current version of ext4_mb_clear_bb()...

I had meant to reply on this thread sooner...

Does this mean that no error will be returned at all from FSTRIM? That means userspace will just keep pounding this ioctl indefinitely and never get a notification that it is the wrong thing to do.

I'd think it would instead be better to also skip the ext4_std_error() in case of -EOPNOTSUPP but still return the error code to the caller so that they can make a better decision next time.

A patch recently landed to lib/ext2fs/unix_io.c to do exactly that[1] - skip calling ioctl(BLKDISCARD) a million times if formatting a filesystem where the underlying storage doesn't support it, but I could imagine the same is true for other applications that want the error to be returned.

[1] https://patchwork.ozlabs.org/project/linux-ext4/patch/[email protected]/

Cheers, Andreas

author reviewer
#4 lore raw
Quoted 45 lines · Andreas Dilger
Quoted 44 lines · Jan Kara
Quoted 41 lines · Andreas Dilger
Quoted 19 lines · Jan Kara

When ext4 is mounted without journal, with discard mount option, and on a device not supporting trim, we print error for each and every freed extent. This is not only useless but actively harmful. Instead ignore the EOPNOTSUPP error. Trim is only advisory anyway and when the filesystem has journal we silently ignore trim error as well.

---
fs/ext4/mballoc.c | 8 +++++++-

1 file changed, 7 insertions(+), 1 deletion(-)
fs/ext4/mballoc.c +0 -0
index e4f7cf9d89c4..aed620cf4d40 100644
@@ -6488,7 +6488,13 @@ static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode,
 		if (test_opt(sb, DISCARD)) {

fs/ext4/mballoc.c static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode, · line 6497

Quoted 10 lines
fs/ext4/mballoc.c +7 -1
 			err = ext4_issue_discard(sb, block_group, bit,
 						 count_clusters, NULL);
-			if (err && err != -EOPNOTSUPP)
+			/*
+			 * Ignore EOPNOTSUPP error. This is consistent with
+			 * what happens when using journal.
+			 */
+			if (err == -EOPNOTSUPP)
+				err = 0;
+			if (err)

I don't see how this patch is actually changing whether the error message is printed? Previously, if "err" was set and err was -EOPNOTSUPP the message was skipped. Now it is doing the same thing in a different way?

The "err" value is overwritten 50 lines later on without being used:

       err = ext4_handle_dirty_metadata(handle, NULL, bitmap_bh);

so the setting "err = 0" doesn't really affect the later code either. What am I missing?

Quoted 8 lines
Quoted 4 lines

Yeah, the code flow is a bit contrived. The error message gets printed by ext4_std_error() at the end of ext4_mb_clear_bb(). I don't think there's any ext4_handle_dirty_metadata() call in the current version of ext4_mb_clear_bb()...

I had meant to reply on this thread sooner...

Does this mean that no error will be returned at all from FSTRIM?

This path is not about FITRIM ioctl but about 'discard' mount option. So in this case there's nobody to return error to.

Quoted 6 lines

That means userspace will just keep pounding this ioctl indefinitely and never get a notification that it is the wrong thing to do.

I'd think it would instead be better to also skip the ext4_std_error() in case of -EOPNOTSUPP but still return the error code to the caller so that they can make a better decision next time.

I agree this might make sense.

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
reviewer Reviewed-by on v1 1/1
#5 lore raw
In reply to Jan Kara
Quoted 6 lines · Jan Kara

When ext4 is mounted without journal, with discard mount option, and on a device not supporting trim, we print error for each and every freed extent. This is not only useless but actively harmful. Instead ignore the EOPNOTSUPP error. Trim is only advisory anyway and when the filesystem has journal we silently ignore trim error as well.

Make sense, call ext4_std_error() since EOPNOTSUPP is really harmful.

Quoted 25 lines
---
 fs/ext4/mballoc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
fs/ext4/mballoc.c +7 -1
index e4f7cf9d89c4..aed620cf4d40 100644
@@ -6488,7 +6488,13 @@ static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode,
 		if (test_opt(sb, DISCARD)) {
 			err = ext4_issue_discard(sb, block_group, bit,
 						 count_clusters, NULL);
-			if (err && err != -EOPNOTSUPP)
+			/*
+			 * Ignore EOPNOTSUPP error. This is consistent with
+			 * what happens when using journal.
+			 */
+			if (err == -EOPNOTSUPP)
+				err = 0;
+			if (err)
 				ext4_msg(sb, KERN_WARNING, "discard request in"
 					 " group:%u block:%d count:%lu failed"
 					 " with %d", block_group, bit, count,
maintainer Applied
#6 lore raw
In reply to Jan Kara
Quoted 8 lines · Jan Kara

When ext4 is mounted without journal, with discard mount option, and on a device not supporting trim, we print error for each and every freed extent. This is not only useless but actively harmful. Instead ignore the EOPNOTSUPP error. Trim is only advisory anyway and when the filesystem has journal we silently ignore trim error as well.

[...]

Applied, thanks!

[1/1] ext4: Don't report EOPNOTSUPP errors from discard

      commit: f3edd83e2e71dd393c0f485be103a4b35f9ef41a

Best regards,

Signature · 1 line
Theodore Ts'o <[email protected]>