Skip to contentSkip to conversation

leds: ktd2692: add gpiolib dependency

PATCH Applied Arnd Bergmann 3 participants 3 messages Feb 13, 2024 – Feb 23, 2024 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: ktd2692: add gpiolib dependency

From: Arnd Bergmann <[email protected]>

The expresswire module requires gpiolib, so anything selecting it also needs this dependency:

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
Selected by [y]:
- LEDS_KTD2692 [=y] && NEW_LEDS [=y] && LEDS_CLASS_FLASH [=y] && OF [=y]

Fixes e59a15af7aa6 ("leds: ktd2692: Convert to use ExpressWire library")
---
 drivers/leds/flash/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/leds/flash/Kconfig +1 -0
index 01998d71a6a2..809b6d98bb3e 100644
@@ -23,6 +23,7 @@ config LEDS_AS3645A
 config LEDS_KTD2692
 	tristate "LED support for Kinetic KTD2692 flash LED controller"
 	depends on OF
+	depends on GPIOLIB
 	select LEDS_EXPRESSWIRE
 	help
 	  This option enables support for Kinetic KTD2692 LED flash connected
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The expresswire module requires gpiolib, so anything selecting it also needs this dependency:

Quoted 7 lines

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
Selected by [y]:
- LEDS_KTD2692 [=y] && NEW_LEDS [=y] && LEDS_CLASS_FLASH [=y] && OF [=y]

Fixes e59a15af7aa6 ("leds: ktd2692: Convert to use ExpressWire library")

Daniel.

maintainer Applied
#2 lore raw

Re: (subset) [PATCH] leds: ktd2692: add gpiolib dependency

In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

The expresswire module requires gpiolib, so anything selecting it also needs this dependency:

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
Selected by [y]:
- LEDS_KTD2692 [=y] && NEW_LEDS [=y] && LEDS_CLASS_FLASH [=y] && OF [=y]

[...]

Applied, thanks!

[1/1] leds: ktd2692: add gpiolib dependency

      commit: 52380f87d190e1e3f376f6a01d70bca753e81251

--
Lee Jones [李琼斯]