tests/kms_universal_plane: Re-work expectations for non-intel hw
PATCH v2 1/1 tests/kms_universal_plane: Re-work expectations for non-intel hw
From: Rob Clark <[email protected]>
The expectation assumptions do not fit for non-intel hw. So re-work the expectations and add msm support.
--- tests/kms_universal_plane.c | 58 +++++++++++++++++++++++-------------- 1 file changed, 36 insertions(+), 22 deletions(-)
tests/kms_universal_plane.c +36 -22
@@ -402,7 +402,7 @@ sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)sanity_test_t test = { .data = data };igt_plane_t *primary;drmModeModeInfo *mode; -int i; +int i, ret;int expect =0 ;igt_output_set_pipe (output, pipe);
@@ -432,29 +432,43 @@ sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)igt_plane_set_position (primary,0 ,0 ); -/* Try to use universal plane API to scale down (should fail on pre-gen9) */ +/* Try to use universal plane API to scale down */ if (is_intel_device (data->drm_fd)) expect = (data->display_ver <9 ) ? -ERANGE :0 ; -igt_assert (drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, - output->config.crtc->crtc_id, - test.oversized_fb.fb_id,0 , -0 ,0 , - mode->hdisplay +100 , - mode->vdisplay +100 , -IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), -IGT_FIXED (mode->hdisplay,0 ), -IGT_FIXED (mode->vdisplay,0 )) == expect); - -/* Try to use universal plane API to scale up (should fail on pre-gen9) */ -igt_assert (drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, - output->config.crtc->crtc_id, - test.oversized_fb.fb_id,0 , -0 ,0 , - mode->hdisplay, - mode->vdisplay, -IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), -IGT_FIXED (mode->hdisplay -100 ,0 ), -IGT_FIXED (mode->vdisplay -100 ,0 )) == expect); + ret =drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, + output->config.crtc->crtc_id, + test.oversized_fb.fb_id,0 , +0 ,0 , + mode->hdisplay +100 , + mode->vdisplay +100 , +IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), +IGT_FIXED (mode->hdisplay,0 ), +IGT_FIXED (mode->vdisplay,0 )); +if (is_intel_device (data->drm_fd)) { +/* should fail on pre-gen9 */ +igt_assert_eq (ret, (data->display_ver <9 ) ? -ERANGE :0 ); + }else { +/* Could succeed or fail with -ERANGE depending on hw limits: */ +igt_assert ((ret ==0 ) || (ret == -ERANGE )); + } + +/* Try to use universal plane API to scale up */ + ret =drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, + output->config.crtc->crtc_id, + test.oversized_fb.fb_id,0 , +0 ,0 , + mode->hdisplay, + mode->vdisplay, +IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), +IGT_FIXED (mode->hdisplay -100 ,0 ), +IGT_FIXED (mode->vdisplay -100 ,0 )); +if (is_intel_device (data->drm_fd)) { +/* should fail on pre-gen9 */ +igt_assert_eq (ret, (data->display_ver <9 ) ? -ERANGE :0 ); + }else { +/* Could succeed or fail with -ERANGE depending on hw limits: */ +igt_assert ((ret ==0 ) || (ret == -ERANGE )); + }/* Find other crtcs and try to program our primary plane on them */ for (i =0 ; i < test.moderes->count_crtcs; i++)
Signature · 1 line
2.43.0
Patchwork
CI✓ CI.xeBAT: success for tests/kms_universal_plane: Re-work expectations for non-intel hw (rev2)
== Series Details ==
== Series Details ==
Series: tests/kms_universal_plane: Re-work expectations for non-intel hw (rev2)
URL : https://patchwork.freedesktop.org/series/128450/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7715_BAT -> XEIGTPW_10683_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in XEIGTPW_10683_BAT that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@xe_exec_threads@threads-mixed-fd-basic:
- bat-dg2-oem2: [TIMEOUT][1] ([Intel XE#1167]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7715/bat-dg2-oem2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10683/bat-dg2-oem2/igt@[email protected]
[Intel XE#1167]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1167
Build changes
-------------
* IGT: IGT_7715 -> IGTPW_10683
* Linux: xe-787-6d3abf8f7f55420cf53e9ed344872c459ecfd0ed -> xe-788-f9855a4be31b723fe67e9b6f6cfb0df7760cd6d8
IGTPW_10683: 10683
IGT_7715: 7715
xe-787-6d3abf8f7f55420cf53e9ed344872c459ecfd0ed: 6d3abf8f7f55420cf53e9ed344872c459ecfd0ed xe-788-f9855a4be31b723fe67e9b6f6cfb0df7760cd6d8: f9855a4be31b723fe67e9b6f6cfb0df7760cd6d8
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10683/index.html
Patchwork
CI✗ Fi.CI.BAT: failure for tests/kms_universal_plane: Re-work expectations for non-intel hw (rev2)
In reply to Rob Clark== Series Details ==
== Series Details ==
Series: tests/kms_universal_plane: Re-work expectations for non-intel hw (rev2)
URL : https://patchwork.freedesktop.org/series/128450/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14281 -> IGTPW_10683
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_10683 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10683, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/index.html
Participating hosts (36 -> 37)
------------------------------
Additional (3): bat-atsm-1 bat-arls-2 bat-arls-3
Missing (2): fi-apl-guc fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_10683:
### IGT changes ###
#### Possible regressions ####
* igt@dmabuf@all-tests@dma_fence_chain:
- fi-elk-e7500: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14281/fi-elk-e7500/igt@dmabuf@all-tests@dma_fence_chain.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/fi-elk-e7500/igt@dmabuf@all-tests@dma_fence_chain.html
Known issues
------------
Here are the changes found in IGTPW_10683 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][3] ([i915#4083])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][4] ([i915#4077]) +2 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-atsm-1: NOTRUN -> [SKIP][5] ([i915#4079]) +1 other test skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-atsm-1: NOTRUN -> [SKIP][6] ([i915#6621])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: NOTRUN -> [SKIP][7] ([i915#6077]) +37 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-atsm-1: NOTRUN -> [SKIP][8] ([i915#6078]) +17 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-atsm-1: NOTRUN -> [SKIP][9] ([i915#6093]) +4 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:
- bat-atsm-1: NOTRUN -> [SKIP][10] ([i915#1836]) +6 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@kms_prop_blob@basic:
- bat-atsm-1: NOTRUN -> [SKIP][11] ([i915#7357])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- bat-atsm-1: NOTRUN -> [SKIP][12] ([i915#6094])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- bat-atsm-1: NOTRUN -> [SKIP][13] ([fdo#109295] / [i915#6078])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@prime_vgem@basic-fence-mmap:
- bat-atsm-1: NOTRUN -> [SKIP][14] ([fdo#109295] / [i915#4077]) +1 other test skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
* igt@prime_vgem@basic-write:
- bat-atsm-1: NOTRUN -> [SKIP][15] ([fdo#109295]) +2 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#10194]: https://gitlab.freedesktop.org/drm/intel/issues/10194
[i915#10196]: https://gitlab.freedesktop.org/drm/intel/issues/10196
[i915#10197]: https://gitlab.freedesktop.org/drm/intel/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/intel/issues/10200
[i915#10202]: https://gitlab.freedesktop.org/drm/intel/issues/10202
[i915#10206]: https://gitlab.freedesktop.org/drm/intel/issues/10206
[i915#10207]: https://gitlab.freedesktop.org/drm/intel/issues/10207
[i915#10208]: https://gitlab.freedesktop.org/drm/intel/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/intel/issues/10209
[i915#10211]: https://gitlab.freedesktop.org/drm/intel/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/intel/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/intel/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/intel/issues/10214
[i915#10215]: https://gitlab.freedesktop.org/drm/intel/issues/10215
[i915#10216]: https://gitlab.freedesktop.org/drm/intel/issues/10216
[i915#10274]: https://gitlab.freedesktop.org/drm/intel/issues/10274
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9688]: https://gitlab.freedesktop.org/drm/intel/issues/9688
[i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732
[i915#9812]: https://gitlab.freedesktop.org/drm/intel/issues/9812
[i915#9886]: https://gitlab.freedesktop.org/drm/intel/issues/9886
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7715 -> IGTPW_10683
CI-20190529: 20190529
CI_DRM_14281: f9855a4be31b723fe67e9b6f6cfb0df7760cd6d8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10683: 10683
IGT_7715: 7715
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/index.html
Re: ✗ Fi.CI.BAT: failure for tests/kms_universal_plane: Re-work expectations for non-intel hw (rev2)
Hi igt-dev,
Quoted 36 lines · Patchwork
== Series Details ==
Series: tests/kms_universal_plane: Re-work expectations for non-intel hw (rev2)
URL : https://patchwork.freedesktop.org/series/128450/
State : failure== Summary ==
CI Bug Log - changes from
CI_DRM_14281->IGTPW_10683
====================================================Summary
-------**FAILURE**
Serious unknown changes coming with
IGTPW_10683absolutely need to be verified manually.If you think the reported changes have nothing to do with the changes
introduced inIGTPW_10683, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/index.html
Participating hosts (36 -> 37)
------------------------------Additional (3): bat-atsm-1 bat-arls-2 bat-arls-3
Missing (2): fi-apl-guc fi-snb-2520mPossible new issues
-------------------Here are the unknown changes that may have been introduced in
IGTPW_10683:
Quoted 9 lines
### IGT changes ###
#### Possible regressions ####
* igt@dmabuf@all-tests@dma_fence_chain:
- fi-elk-e7500: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14281/fi-elk-e7500/igt@dmabuf@all-tests@dma_fence_chain.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/fi-elk-e7500/igt@dmabuf@all-tests@dma_fence_chain.html
This is unrelated to change in kms test,
Regards,
Kamil
Quoted 15 lines
Known issues
------------Here are the changes found in
IGTPW_10683that come from known issues:### IGT changes ###
#### Issues hit ####
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][3] ([i915#4083])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/bat-atsm-1/igt@[email protected]
...cut...
Quoted 15 lines
Build changes
-------------* CI: CI-20190529 -> None
* IGT:IGT_7715->IGTPW_10683CI-20190529: 20190529
CI_DRM_14281:f9855a4be31b723fe67e9b6f6cfb0df7760cd6d8@git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10683: 10683
IGT_7715: 7715== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10683/index.html
Hi Rob,
Quoted 75 lines · Rob Clark
From: Rob Clark <[email protected]>
The expectation assumptions do not fit for non-intel hw. So re-work the expectations and add msm support.
Signed-off-by Rob Clark <[email protected]>--- tests/kms_universal_plane.c | 58 +++++++++++++++++++++++-------------- 1 file changed, 36 insertions(+), 22 deletions(-)tests/kms_universal_plane.c +26
-22@@ -402,7 +402,7 @@ sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)sanity_test_t test = { .data = data };igt_plane_t *primary;drmModeModeInfo *mode; -int i; +int i, ret;int expect =0 ;igt_output_set_pipe (output, pipe);@@ -432,29 +432,43 @@ sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)igt_plane_set_position (primary,0 ,0 ); -/* Try to use universal plane API to scale down (should fail on pre-gen9) */ +/* Try to use universal plane API to scale down */ if (is_intel_device (data->drm_fd)) expect = (data->display_ver <9 ) ? -ERANGE :0 ; -igt_assert (drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, - output->config.crtc->crtc_id, - test.oversized_fb.fb_id,0 , -0 ,0 , - mode->hdisplay +100 , - mode->vdisplay +100 , -IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), -IGT_FIXED (mode->hdisplay,0 ), -IGT_FIXED (mode->vdisplay,0 )) == expect); - -/* Try to use universal plane API to scale up (should fail on pre-gen9) */ -igt_assert (drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, - output->config.crtc->crtc_id, - test.oversized_fb.fb_id,0 , -0 ,0 , - mode->hdisplay, - mode->vdisplay, -IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), -IGT_FIXED (mode->hdisplay -100 ,0 ), -IGT_FIXED (mode->vdisplay -100 ,0 )) == expect); + ret =drmModeSetPlane (data->drm_fd, primary->drm_plane->plane_id, + output->config.crtc->crtc_id, + test.oversized_fb.fb_id,0 , +0 ,0 , + mode->hdisplay +100 , + mode->vdisplay +100 , +IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), +IGT_FIXED (mode->hdisplay,0 ), +IGT_FIXED (mode->vdisplay,0 )); +if (is_intel_device (data->drm_fd)) { +/* should fail on pre-gen9 */ +igt_assert_eq (ret, (data->display_ver <9 ) ? -ERANGE :0 ); + }else { +/* Could succeed or fail with -ERANGE depending on hw limits: */ +igt_assert ((ret ==0 ) || (ret == -ERANGE )); + } + +/* Try to use universal plane API to scale up */ + ret = drmModeSetPlane(data->drm_fd, primary->drm_plane->plane_id, + output->config.crtc->crtc_id, + test.oversized_fb.fb_id, 0, + 0, 0, + mode->hdisplay, + mode->vdisplay,
tests/kms_universal_plane.c sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output) · line 471
Quoted 10 lines
tests/kms_universal_plane.c +10
-0+IGT_FIXED (0 ,0 ),IGT_FIXED (0 ,0 ), +IGT_FIXED (mode->hdisplay -100 ,0 ), + IGT_FIXED(mode->vdisplay - 100,0)); +if (is_intel_device (data->drm_fd)) { +/* should fail on pre-gen9 */ +igt_assert_eq (ret, (data->display_ver <9 ) ? -ERANGE :0 ); + }else { +/* Could succeed or fail with -ERANGE depending on hw limits: */ +igt_assert ((ret ==0 ) || (ret == -ERANGE )); + }
Quoted 6 lines
tests/kms_universal_plane.c +0
-0/* Find other crtcs and try to program our primary plane on them */ for (i =0 ; i < test.moderes->count_crtcs; i++)Signature · 1 line
2.43.0