Skip to contentSkip to conversation

bus: tegra-aconnect: Update dependency to ARCH_TEGRA

PATCH Applied Peter Robinson 3 participants 5 messages Feb 16, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 bus: tegra-aconnect: Update dependency to ARCH_TEGRA

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just Tegra210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes Tegra210 you don't get this driver.

Fixes 46a88534afb59 ("bus: Add support for Tegra ACONNECT")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>

---

v2: fix spelling of option
v3: Update T210 -> Tegra210
use "and later" rather than all current devices

 drivers/bus/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/bus/Kconfig +3 -2
index e6742998f372c..d5e7fa9173a16 100644
@@ -186,11 +186,12 @@ config SUNXI_RSB
 
 config TEGRA_ACONNECT
 	tristate "Tegra ACONNECT Bus Driver"
-	depends on ARCH_TEGRA_210_SOC
+	depends on ARCH_TEGRA
 	depends on OF && PM
 	help
 	  Driver for the Tegra ACONNECT bus which is used to interface with
-	  the devices inside the Audio Processing Engine (APE) for Tegra210.
+	  the devices inside the Audio Processing Engine (APE) for
+	  Tegra210 and later.
 
 config TEGRA_GMI
 	tristate "Tegra Generic Memory Interface bus driver"
Signature · 1 line
2.43.1
#1 lore raw

PATCH 2/2 dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just Tegra210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes Tegra210 you don't get this driver.

Fixes 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sameer Pujar <[email protected]>
Cc Laxman Dewangan <[email protected]>
Cc Vinod Koul <[email protected]>

---

v2: fix spelling of option
v3: Update T210 -> Tegra210
use "and later" rather than all current devices

 drivers/dma/Kconfig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/dma/Kconfig +7 -7
index e928f2ca0f1e9..ae23b886a6c60 100644
@@ -643,16 +643,16 @@ config TEGRA20_APB_DMA
 
 config TEGRA210_ADMA
 	tristate "NVIDIA Tegra210 ADMA support"
-	depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST)
+	depends on (ARCH_TEGRA || COMPILE_TEST)
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help
-	  Support for the NVIDIA Tegra210 ADMA controller driver. The
-	  DMA controller has multiple DMA channels and is used to service
-	  various audio clients in the Tegra210 audio processing engine
-	  (APE). This DMA controller transfers data from memory to
-	  peripheral and vice versa. It does not support memory to
-	  memory data transfer.
+	  Support for the NVIDIA Tegra210 and later ADMA
+	  controller driver. The DMA controller has multiple DMA channels
+	  and is used to service various audio clients in the Tegra210
+	  audio processing engine (APE). This DMA controller transfers
+	  data from memory to peripheral and vice versa. It does not
+	  support memory to memory data transfer.
 
 config TIMB_DMA
 	tristate "Timberdale FPGA DMA support"
Signature · 1 line
2.43.1
Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA

Quoted 14 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just Tegra210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes Tegra210 you don't get this driver.

Fixes 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sameer Pujar <[email protected]>
Cc Laxman Dewangan <[email protected]>
Cc Vinod Koul <[email protected]>
Quoted 8 lines

---

v2: fix spelling of option
v3: Update T210 -> Tegra210
use "and later" rather than all current devices

 drivers/dma/Kconfig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
maintainer
#3 lore raw

Re: [PATCH 2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA

In reply to Peter Robinson
Quoted 5 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just Tegra210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes Tegra210 you don't get this driver.

??

This is already in linux-next, see 33b7db45533af240fe44e809f9dc4d604cf82d07

Quoted 48 lines
Fixes 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
Cc Jon Hunter <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Sameer Pujar <[email protected]>
Cc Laxman Dewangan <[email protected]>
Cc Vinod Koul <[email protected]>

---

v2: fix spelling of option
v3: Update T210 -> Tegra210
use "and later" rather than all current devices

 drivers/dma/Kconfig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/dma/Kconfig +7 -7
index e928f2ca0f1e9..ae23b886a6c60 100644
@@ -643,16 +643,16 @@ config TEGRA20_APB_DMA
 
 config TEGRA210_ADMA
 	tristate "NVIDIA Tegra210 ADMA support"
-	depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST)
+	depends on (ARCH_TEGRA || COMPILE_TEST)
 	select DMA_ENGINE
 	select DMA_VIRTUAL_CHANNELS
 	help
-	  Support for the NVIDIA Tegra210 ADMA controller driver. The
-	  DMA controller has multiple DMA channels and is used to service
-	  various audio clients in the Tegra210 audio processing engine
-	  (APE). This DMA controller transfers data from memory to
-	  peripheral and vice versa. It does not support memory to
-	  memory data transfer.
+	  Support for the NVIDIA Tegra210 and later ADMA
+	  controller driver. The DMA controller has multiple DMA channels
+	  and is used to service various audio clients in the Tegra210
+	  audio processing engine (APE). This DMA controller transfers
+	  data from memory to peripheral and vice versa. It does not
+	  support memory to memory data transfer.
 
 config TIMB_DMA
 	tristate "Timberdale FPGA DMA support"
Signature · 1 line
2.43.1
Signature · 1 line
~Vinod
#4 lore raw

Re: (subset) [PATCH 1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA

In reply to Peter Robinson

From: Thierry Reding <[email protected]>

Quoted 8 lines · Peter Robinson

Update the architecture dependency to be the generic Tegra because the driver works on the four latest Tegra generations not just Tegra210, if you build a kernel with a specific ARCH_TEGRA_xxx_SOC option that excludes Tegra210 you don't get this driver.

[...]

Applied, thanks!

[1/2] bus: tegra-aconnect: Update dependency to ARCH_TEGRA

      commit: 4acd21a45c1446277e2abaece97d7fa7c2e692a9

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>